https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.clang%2FToTAndroidASan%2F931%2F%2B%2Frecipes%2Fsteps%2Fbase_unittests%2F0%2Fstdout

Traceback (most recent call last):
  File "/b/c/b/ToTAndroidASan/src/build/android/test_runner.py", line 1040, in main
    return RunTestsCommand(args)
  File "/b/c/b/ToTAndroidASan/src/build/android/test_runner.py", line 743, in RunTestsCommand
    return RunTestsInPlatformMode(args)
  File "/b/c/b/ToTAndroidASan/src/build/android/test_runner.py", line 867, in RunTestsInPlatformMode
    with json_writer(), logcats_uploader, env, test_instance, test_run:
  File "/b/c/b/ToTAndroidASan/src/build/android/pylib/base/test_run.py", line 39, in __enter__
    self.SetUp()
  File "/b/c/b/ToTAndroidASan/src/build/android/pylib/local/device/local_device_gtest_run.py", line 353, in SetUp
    self._test_instance.GetDataDependencies())
  File "/b/c/b/ToTAndroidASan/src/third_party/catapult/devil/devil/utils/parallelizer.py", line 263, in pMap
    r.pFinish(None)
  File "/b/c/b/ToTAndroidASan/src/third_party/catapult/devil/devil/utils/parallelizer.py", line 135, in pFinish
    self._objs.JoinAll()
  File "/b/c/b/ToTAndroidASan/src/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 189, in JoinAll
    self._JoinAll(watcher, timeout)
  File "/b/c/b/ToTAndroidASan/src/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 161, in _JoinAll
    thread.ReraiseIfException()
  File "/b/c/b/ToTAndroidASan/src/third_party/catapult/devil/devil/utils/reraiser_thread.py", line 84, in run
    self._ret = self._func(*self._args, **self._kwargs)
  File "/b/c/b/ToTAndroidASan/src/build/android/pylib/local/device/local_device_environment.py", line 66, in wrapper
    return f(dev, *args, **kwargs)
  File "/b/c/b/ToTAndroidASan/src/third_party/catapult/common/py_trace_event/py_trace_event/trace_event_impl/decorators.py", line 52, in traced_function
    return func(*args, **kwargs)
  File "/b/c/b/ToTAndroidASan/src/build/android/pylib/local/device/local_device_gtest_run.py", line 349, in individual_device_set_up
    step()
  File "/b/c/b/ToTAndroidASan/src/build/android/pylib/local/device/local_device_gtest_run.py", line 340, in <lambda>
    return lambda: crash_handler.RetryOnSystemCrash(step, dev)
  File "/b/c/b/ToTAndroidASan/src/third_party/catapult/devil/devil/android/crash_handler.py", line 32, in RetryOnSystemCrash
    return f(device)
  File "/b/c/b/ToTAndroidASan/src/build/android/pylib/local/device/local_device_gtest_run.py", line 327, in init_tool_and_start_servers
    tool.CopyFiles(dev)
  File "/b/c/b/ToTAndroidASan/src/build/android/pylib/valgrind_tools.py", line 49, in CopyFiles
    assert len(libs) == 1
AssertionError


https://cs.chromium.org/chromium/src/build/android/pylib/valgrind_tools.py?q=android/pylib/valgrind_tools.py&sq=package:chromium&g=0&l=1

    libs = glob.glob(os.path.join(DIR_SOURCE_ROOT,
                                  'third_party/llvm-build/Release+Asserts/',
                                  'lib/clang/*/lib/linux/',
                                  'libclang_rt.asan-arm-android.so'))
    assert len(libs) == 1


The glob now matches both versions.


It feels like we've fixed this a few times, but I forget what we usually do. Call update.py --print-revision (but then how do we know we're on a tot bot)? Pass llvm_revision from gn?

(This is at test time, so gn-based things might not work.)

But in general, we can't glob for the version but need to use the explicit version from tools/clang/scrips/update.py somehow.


The glob is old https://chromium.googlesource.com/chromium/src/+/84031828becaeeb7eee7d5f83c675122d3b3e2cc

Maybe we just manually deleted it in the past? Or the android tot bot is new since the last version bump?