Issue metadata
Sign in to add a comment
|
Regression : Unnecessary tab focus is seen on 'Drop down' of User in Sign-out screen |
||||||||||||||||||||||
Issue descriptionChrome Version: 70.0.3511.0/10942.0.0 dev-channel Kip,Celes and Daisy OS: Chrome What steps will reproduce the problem? 1)Sign into User -> Now at Uber Tray select 'Sign out' option -> In Sign out screen Press 'Tab' button until focus is on 'Add person' (2)Now click on 'Enter' button -> Sign-in screen is seen -> click on 'Back' button -> now observe unnecessary focus is seen on 'Drop down' of User (Please refer Video) Expected: Unnecessary tab focus should not be seen on 'Drop down' of User Actual: Instead Unnecessary tab focus is seen on 'Drop down' of User This is Regression Issue as same is working fine in 70.0.3508.3/10933.0.0
,
Aug 6
Always focusing password after dialog is dismissed is probably a reasonable approach here.
,
Aug 6
Seems like this will require a browser->Ash mojo call. Can you think of a way to do it without?
,
Aug 6
We should be able to key off of NotifyOobeDialogVisibility, so no changes chrome-side required. https://cs.chromium.org/chromium/src/ash/public/interfaces/login_screen.mojom?l=133-136&rcl=8d157075e09554fd546d20511ae3691f0516aaf6 +xiaoyinh@ who has a CL which changes this to a more generic method (ie, the full oobe state, instead of just visibility)
,
Aug 6
The CL is here: https://chromium-review.googlesource.com/c/chromium/src/+/1142384 (although this is reverted at the moment due to some incorrect oobe state) For this particular case, maybe we can just request login screen focus when NotifyOobeDialogVisibility == not visible.
,
Aug 6
Sounds good. I'll add you both to the CL when it's ready.
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c6ff3153fecc53f330f85c3a2d2fe6bf22cd6509 commit c6ff3153fecc53f330f85c3a2d2fe6bf22cd6509 Author: Quan Nguyen <qnnguyen@chromium.org> Date: Tue Aug 07 20:00:37 2018 cros: Focus the primary password field when OOBE dialog goes away. As part of this CL, a method has been added to LoginScreenControllerObserver to be notified when the OOBE dialog visibility changes. Bug: 871186 Change-Id: I7b8d9fb7de99c16df6166c43f2eb55f56b93736e Reviewed-on: https://chromium-review.googlesource.com/1164248 Reviewed-by: Mitsuru Oshima <oshima@chromium.org> Reviewed-by: Xiaoyin Hu <xiaoyinh@chromium.org> Reviewed-by: Jacob Dufault <jdufault@chromium.org> Commit-Queue: Quan Nguyen <qnnguyen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581318} [modify] https://crrev.com/c6ff3153fecc53f330f85c3a2d2fe6bf22cd6509/ash/login/login_screen_controller.cc [modify] https://crrev.com/c6ff3153fecc53f330f85c3a2d2fe6bf22cd6509/ash/login/login_screen_controller_observer.cc [modify] https://crrev.com/c6ff3153fecc53f330f85c3a2d2fe6bf22cd6509/ash/login/login_screen_controller_observer.h [modify] https://crrev.com/c6ff3153fecc53f330f85c3a2d2fe6bf22cd6509/ash/login/ui/lock_contents_view.cc [modify] https://crrev.com/c6ff3153fecc53f330f85c3a2d2fe6bf22cd6509/ash/login/ui/lock_contents_view.h [modify] https://crrev.com/c6ff3153fecc53f330f85c3a2d2fe6bf22cd6509/ash/shelf/login_shelf_view.cc [modify] https://crrev.com/c6ff3153fecc53f330f85c3a2d2fe6bf22cd6509/ash/shelf/login_shelf_view.h
,
Aug 7
|
|||||||||||||||||||||||
►
Sign in to add a comment |
|||||||||||||||||||||||
Comment 1 by mmanchala@chromium.org
, Aug 613.9 MB
13.9 MB View Download