New issue
Advanced search Search tips

Issue 871185 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Cc:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Bug



Sign in to add a comment

cros_camera_service doesn't restart after 'restart ui' on betty with vivid

Project Member Reported by keiichiw@chromium.org, Aug 6

Issue description

Chrome Version: 70.0.3508.0
OS: ChromeOS on betty

What steps will reproduce the problem?
(1) Build ChromeOS and Chrome for betty with enabling vivid.
Currently, some cherry-picking is needed. See crbug.com/852302
(2) Start VM and SSH into it.
(3) Run 'sudo modprobe vivid n_devs=1 node_types=0x1'
(4) Run 'restart ui'

What is the expected result?
cros_camera_service should be restarted after (4).

What happens instead?
cros_camera_service failed to restart.

dmesg gave the flowing log:
[  151.720982] init: arc-kmsg-logger main process (1778) killed by TERM signal
[  151.905615] init: cros-camera main process ended, respawning
[  152.928611] blk_update_request: I/O error, dev loop7, sector 0
[  153.896405] audit: type=1400 audit(1533553616.014:21): avc:  denied  { dac_override } for  pid=2931 comm="logd" capability=1  scontext=u:r:logd:s0 tcontext=u:r:logd:s0 tclass=capability permissive=0
[  153.903394] audit: type=1400 audit(1533553616.021:22): avc:  denied  { dac_read_search } for  pid=2931 comm="logd" capability=2  scontext=u:r:logd:s0 tcontext=u:r:logd:s0 tclass=capability permissive=0
[  153.944614] binder: 2946:2946 transaction failed 29189, size 0-0
[  153.977167] audit: type=1400 audit(1533553616.095:23): avc:  denied  { dac_override } for  pid=2945 comm="logd" capability=1  scontext=u:r:logd:s0 tcontext=u:r:logd:s0 tclass=capability permissive=0
[  153.992049] audit: type=1400 audit(1533553616.110:24): avc:  denied  { dac_read_search } for  pid=2945 comm="logd" capability=2  scontext=u:r:logd:s0 tcontext=u:r:logd:s0 tclass=capability permissive=0
[  154.634175] audit: type=1400 audit(1533553616.752:25): avc:  denied  { dac_read_search } for  pid=2950 comm="main" capability=2  scontext=u:r:zygote:s0 tcontext=u:r:zygote:s0 tclass=capability permissive=0
[  154.637548] audit: type=1400 audit(1533553616.756:26): avc:  denied  { dac_read_search } for  pid=2950 comm="main" capability=2  scontext=u:r:zygote:s0 tcontext=u:r:zygote:s0 tclass=capability permissive=0
[  154.640763] audit: type=1400 audit(1533553616.759:27): avc:  denied  { dac_read_search } for  pid=2950 comm="main" capability=2  scontext=u:r:zygote:s0 tcontext=u:r:zygote:s0 tclass=capability permissive=0
[  154.644916] audit: type=1400 audit(1533553616.762:28): avc:  denied  { dac_read_search } for  pid=2950 comm="main" capability=2  scontext=u:r:zygote:s0 tcontext=u:r:zygote:s0 tclass=capability permissive=0
[  154.650030] audit: type=1400 audit(1533553616.768:29): avc:  denied  { dac_read_search } for  pid=2950 comm="main" capability=2  scontext=u:r:zygote:s0 tcontext=u:r:zygote:s0 tclass=capability permissive=0
[  154.973529] init: cros-camera main process ended, respawning

-----
When I execute 'cros_camera_service' manually after it, it started correctly.
Also, without step (3), cros_camera_service restarted.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Sep 14

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/platform/arc-camera/+/40387e4196caec4e46c37c0ca824d7f16b29fa3f

commit 40387e4196caec4e46c37c0ca824d7f16b29fa3f
Author: Shik Chen <shik@chromium.org>
Date: Fri Sep 14 19:08:38 2018

hal_adapter: fix vivid detection after service is restarted

The udev property (ID_V4L_PRODUCT) we used to detect vivid device is
stored in /run/udev/data, so we need to bind it inside the sandbox.

BUG= chromium:871185 , chromium:881300 ,chromium:852302
TEST=On amd64-generic VM, do:
       1. $ modprobe vivid n_devs=1 node_types=0x1
       2. Check vivid is detected
       3. $ restart cros-camera
       4. Check vivid is still detected

Change-Id: Ibfe4b974ed73ae88f42eeb70517ed6fdcf9621dc
Reviewed-on: https://chromium-review.googlesource.com/1214903
Commit-Ready: Shik Chen <shik@chromium.org>
Tested-by: Shik Chen <shik@chromium.org>
Tested-by: Keiichi Watanabe <keiichiw@chromium.org>
Reviewed-by: Keiichi Watanabe <keiichiw@chromium.org>

[modify] https://crrev.com/40387e4196caec4e46c37c0ca824d7f16b29fa3f/hal_adapter/init/cros-camera.conf

Status: Fixed (was: Untriaged)
Fixed. Thanks shik@!

Sign in to add a comment