New issue
Advanced search Search tips

Issue 871184 link

Starred by 3 users
Status: Fixed
Owner:
qnnguyen@chromium.org
Closed: Sep 5
Cc:
ajha@chromium.org
wzang@chromium.org
jdufault@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug-Regression


Participants' hotlists:
LoginRefresh


Sign in to add a comment

Regression : Tab focus is seen missing on 'Shut down' and 'Uber Tray' options when second User sign in screen is opened

Project Member Reported by mmanchala@chromium.org, Aug 6 
Chrome Version: 70.0.3511.0/10942.0.0 dev-channel  Kip,Celes and Daisy
OS: Chrome

What steps will reproduce the problem?
(1)Sign into User -> Now at Uber Tray select 'Sign out' option -> In Sign out screen click on 'Add person'
(2)Sign-in Screen is seen -> Press 'Tab' button and observe focus traversal i.e. tab focus is not seen on 'Shut down' and 'Uber Tray' options
(Please refer Video)

Expected: Tab focus should be seen on 'Shut down' and 'Uber Tray' options
Actual: Instead Tab focus is seen missing

This is Regression Issue as same is working fine in 70.0.3508.3/10933.0.0
Actual_NoTabFocus.mp4
13.3 MB View Download

Comment 1 by mmanchala@chromium.org, Aug 6 

Attaching Expected video for reference
Expected_TabFocus.mp4
12.2 MB View Download

Comment 2 by mmanchala@chromium.org, Aug 6 

 Issue 871181  has been merged into this issue.

Comment 3 by jdufault@chromium.org, Aug 6

Owner: qnnguyen@chromium.org
Status: Assigned (was: Untriaged)
qnnguyen@, this is related to widget focus traversal. There should be an event raised when focus has cycled; when that happens, we need to override default focus behavior to switch widgets instead of going back to the first element.

https://cs.chromium.org/chromium/src/ash/login/ui/lock_contents_view.cc?l=915-928&rcl=0dd4703c5a3b2efb18cbef5a53d2ffe52ae07fd1

Comment 4 by dgagnon@chromium.org, Sep 4 

Friendly ping to get an update as it is marked as RBS. Thanks

Comment 5 by qnnguyen@chromium.org, Sep 4 

Review happening here: https://chromium-review.googlesource.com/c/chromium/src/+/1197785

Having some network trouble at the moment, but fix should be coming out soon.

Comment 6 by qnnguyen@chromium.org, Sep 5

Status: Fixed (was: Assigned)
Fix got merged. Marking as fixed.
Project Member

Comment 7 by blocker...@chrome-infra-auth.iam.gserviceaccount.com, Sep 5

Labels: Merge-TBD
[Auto-generated comment by a script] We noticed that this issue is targeted for M-70; it appears the fix may have landed after branch point, meaning a merge might be required. Please confirm if a merge is required here - if so add Merge-Request-70 label, otherwise remove Merge-TBD label. Thanks.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 5 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3d7a0f0c6585089aa362aa08033a92bb7596590d

commit 3d7a0f0c6585089aa362aa08033a92bb7596590d
Author: Quan Nguyen <qnnguyen@chromium.org>
Date: Tue Sep 04 23:53:55 2018

cros: Make it possible to tab-focus from OOBE dialog to shelf widget.

This CL includes a few major changes:

OobeUIDialogDelegate is now a WebContentsDelegate for the OOBE WebDialogView, so
that it can be notified of focus reaching the end of the WebContents and move
the focus over to the shelf. Because of this change, HandleKeyboardEvent must
be implemented to send accelerators to the webui.

During login, AshFocusRules has a special case that allows the ShelfContainer to
be activated even when the LockSystemModalContainer is active.

Bug:  871184 
Change-Id: Ia5437705304831dbf2f21e29a39f6bbcb3a15307
Reviewed-on: https://chromium-review.googlesource.com/1197785
Commit-Queue: Quan Nguyen <qnnguyen@chromium.org>
Reviewed-by: Xiyuan Xia <xiyuan@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588703}
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/ash/login/login_screen_controller.cc
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/ash/login/login_screen_controller.h
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/ash/login/mock_login_screen_client.h
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/ash/login/ui/lock_screen_sanity_unittest.cc
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/ash/public/interfaces/login_screen.mojom
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/ash/shelf/login_shelf_view.cc
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/ash/shelf/shelf_widget.cc
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/ash/wm/ash_focus_rules.cc
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/ash/wm/ash_focus_rules_unittest.cc
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/chrome/browser/chromeos/login/lock/views_screen_locker.cc
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/chrome/browser/chromeos/login/lock/views_screen_locker.h
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/chrome/browser/chromeos/login/ui/login_display_host_mojo.cc
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/chrome/browser/chromeos/login/ui/login_display_host_mojo.h
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.cc
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/chrome/browser/chromeos/login/ui/oobe_ui_dialog_delegate.h
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/chrome/browser/ui/ash/login_screen_client.cc
[modify] https://crrev.com/3d7a0f0c6585089aa362aa08033a92bb7596590d/chrome/browser/ui/ash/login_screen_client.h
Project Member

Comment 9 by sheriffbot@chromium.org, Oct 18

Labels: -Merge-TBD
►

Sign in to add a comment