New issue
Advanced search Search tips

Issue 871174 link

Starred by 1 user

Issue metadata

Status: Available
Owner: ----
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug



Sign in to add a comment

Fetches with duplicate request URLs are overwritten

Project Member Reported by rayankans@chromium.org, Aug 6

Issue description

Responses are stored in caches, which are keyed by the URL.

The last request would overwrite all previous instances with the same URL.

This is especially important for supporting uploads, since most upload endpoints would have the same URL.  
 
Labels: -Pri-3 Pri-2
Labels: BlocksMVP
Project Member

Comment 3 by bugdroid1@chromium.org, Sep 5

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3f6faa685311313af88b8d0807ef0c8f88382f56

commit 3f6faa685311313af88b8d0807ef0c8f88382f56
Author: Rayan Kanso <rayankans@chromium.org>
Date: Tue Sep 04 19:34:09 2018

[Background Fetch] Record via UMA whether a fetch has duplicate requests

Also reject the registration if that happens with a warning, and add a
failing WPT test.

Bug: 871174,  780025 
Change-Id: Ibdcc49bc47ea959e0c255a48f5d090cb865a6e45
Reviewed-on: https://chromium-review.googlesource.com/1202262
Reviewed-by: Steven Holte <holte@chromium.org>
Reviewed-by: Mugdha Lakhani <nator@chromium.org>
Reviewed-by: Peter Beverloo <peter@chromium.org>
Commit-Queue: Rayan Kanso <rayankans@chromium.org>
Cr-Commit-Position: refs/heads/master@{#588614}
[add] https://crrev.com/3f6faa685311313af88b8d0807ef0c8f88382f56/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window-expected.txt
[modify] https://crrev.com/3f6faa685311313af88b8d0807ef0c8f88382f56/third_party/WebKit/LayoutTests/external/wpt/background-fetch/fetch.https.window.js
[modify] https://crrev.com/3f6faa685311313af88b8d0807ef0c8f88382f56/third_party/blink/renderer/modules/background_fetch/background_fetch_manager.cc
[modify] https://crrev.com/3f6faa685311313af88b8d0807ef0c8f88382f56/tools/metrics/histograms/histograms.xml

Summary of the current situation and proposed plan to fix this:
https://docs.google.com/document/d/1ElmtWMDKmbxTOpBm2TuBOojS12SW-XBMHwqMr9UAPx8/edit
Labels: -BlocksMVP
As the document says, we're waiting for vary header support to be added to Cache Storage. Since we're rejecting the registration in this case, I'm removing the BlocksMVP case.

Sign in to add a comment