Compile //storage/browser with jumbo |
|
Issue description//storage takes around 6.4 CPU minutes to compile, which is around 1 % of the total build time. //storage/browser is the largest part and takes around 6.2 CPU minutes. This target does not compile with jumbo.
,
Aug 8
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c2c3fb3e8c4bf0d9187b07728040f8a954131a86 commit c2c3fb3e8c4bf0d9187b07728040f8a954131a86 Author: Oscar Johansson <oscarj@opera.com> Date: Wed Aug 08 12:53:17 2018 jumbo build: Rename constants to be unique (storage/browser) When building using jumbo, files gets merged and constants with the same name may end up in the same namespace/scope and conflict. This commit solves the issue by renaming the constants to something more file specific. Bug: 871163 Change-Id: Ic4973b976597dbc097897406951ae8c2cbdf6430 Reviewed-on: https://chromium-review.googlesource.com/1163505 Commit-Queue: Oscar Johansson <oscarj@opera.com> Reviewed-by: Victor Costan <pwnall@chromium.org> Cr-Commit-Position: refs/heads/master@{#581535} [modify] https://crrev.com/c2c3fb3e8c4bf0d9187b07728040f8a954131a86/storage/browser/database/database_quota_client.cc [modify] https://crrev.com/c2c3fb3e8c4bf0d9187b07728040f8a954131a86/storage/browser/database/database_tracker.cc [modify] https://crrev.com/c2c3fb3e8c4bf0d9187b07728040f8a954131a86/storage/browser/fileapi/file_system_quota_client.cc [modify] https://crrev.com/c2c3fb3e8c4bf0d9187b07728040f8a954131a86/storage/browser/fileapi/sandbox_directory_database.cc [modify] https://crrev.com/c2c3fb3e8c4bf0d9187b07728040f8a954131a86/storage/browser/fileapi/sandbox_file_system_backend_delegate.cc [modify] https://crrev.com/c2c3fb3e8c4bf0d9187b07728040f8a954131a86/storage/browser/fileapi/sandbox_origin_database.cc [modify] https://crrev.com/c2c3fb3e8c4bf0d9187b07728040f8a954131a86/storage/browser/quota/client_usage_tracker.cc [modify] https://crrev.com/c2c3fb3e8c4bf0d9187b07728040f8a954131a86/storage/browser/quota/quota_database.cc
,
Sep 3
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e0810f3c017fe36fe0a9958e729c2fa9550d8666 commit e0810f3c017fe36fe0a9958e729c2fa9550d8666 Author: Oscar Johansson <oscarj@opera.com> Date: Mon Sep 03 10:25:51 2018 Enable jumbo support in storage/browser //storage/browser takes around 6.2 CPU minutes to build without jumbo. With jumbo the build time is reduced by around 83 %. This commit enables jumbo support in storage/browser. Bug: 871163 Change-Id: I51254087ea584d64fc599aa232ab2b73027791ec Reviewed-on: https://chromium-review.googlesource.com/1170691 Reviewed-by: Kinuko Yasuda <kinuko@chromium.org> Commit-Queue: Oscar Johansson <oscarj@opera.com> Cr-Commit-Position: refs/heads/master@{#588365} [modify] https://crrev.com/e0810f3c017fe36fe0a9958e729c2fa9550d8666/storage/browser/BUILD.gn |
|
►
Sign in to add a comment |
|
Comment 1 by bugdroid1@chromium.org
, Aug 7