New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 871162 link

Starred by 1 user
Status: Fixed
Owner:
█ sweilun@chromium.org
Last visit 18 days ago
Closed: Aug 8
Cc:
yyushkina@chromium.org
pnangunoori@chromium.org
nyerramilli@chromium.org
rbasuvula@chromium.org
█ ramyan@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug



Sign in to add a comment

[RTL]Profile icon is not visible on local NTP when browser is zoomed in to 125% or beyond

Reported by vineetha...@etouch.net, Aug 6 
Chrome Version:70.0.3514.0 (Official Build) Revision e359e11e00b7a42e1b5f7fee1f89b38a48c2dc60-refs/branch-heads/3514@{#1}(32/64-bit)
OS: Windows (7,8,8.1,10), Mac(10.12.6, 10.13.1, 10.14, 10.13.6) and Linux (14.04 LTS).

Pre-condition:
1. Enable 'Enable using the Google local NTP' under chrome://flags.
2. Set 'Force UI direction' to 'Right-to-left' under chrome://flags.

What steps will reproduce the problem?
1. Launch Chrome and Sign-in to chrome with valid credentials.
2. Open NTP, zoom in browser upto 125%(or above) and observe the profile icon.

Actual  : Profile icon is not visible when browser is zoomed in to 125% or beyond.
Expected: Profile icon should be visible even when browser is zoomed in to 125% or beyond.

This is a non-regression issue, seen from M-68 series

Kindly review the attached screen-cast for reference.

Note : On Mac OS the issue is reproducible when browser is zoomed upto 67% and beyond.

Thank you..!!
ActualVideo.mp4
1010 KB View Download

Comment 1 by ramyan@chromium.org, Aug 6

Cc: yyushkina@chromium.org
Owner: sweilun@chromium.org
Confirmed that this doesn't happen in LTR mode.

Weilun, assigning to you to take a look - this might be a good way to learn about the One Google Bar integration in the NTP. Some recent zoom issues include 854072 and 863293.

Comment 2 by yyushkina@chromium.org, Aug 6 

And some other OGB issues with RTL: 869610 and 869341

Comment 3 by sweilun@chromium.org, Aug 7 

The reason for the invisible profile icon might be the wrong implementation on the force UI direction flag. If you open the browser with an actual rtl language such as LANGUAGE=he out/Default/chrome, the profile icon works well. At the same time, I fix the  crbug.com/869610  to make the one google bar align to left when using a rtl language so that it is consistent with the google.com.
capture.webm
9.4 MB View Download

Comment 4 by sweilun@chromium.org, Aug 7

Status: Started (was: Assigned)

Comment 5 by twelling...@chromium.org, Aug 7

Labels: zine-triaged

Comment 6 by ramyan@chromium.org, Aug 7

Cc: -pnangunoori@chromium.org vabr@chromium.org
+vabr@: We're noticing some elements on the NTP behave differently when the force-ui-direction flag is set to RTL mode vs selecting an RTL language. I noticed that you added the force-ui-direction flag - is this feature intended to emulate setting an RTL language, or something more than that? Thanks!

Comment 7 by ramyan@chromium.org, Aug 7

Cc: pnangunoori@chromium.org

Comment 8 by sweilun@chromium.org, Aug 8

Status: Fixed (was: Started)

Comment 9 by sweilun@chromium.org, Aug 8

Status: WontFix (was: Fixed)

Comment 10 by sweilun@chromium.org, Aug 8

Status: Started (was: WontFix)

Comment 12 by yyushkina@chromium.org, Aug 8

Status: Fixed (was: Started)
Marking this fixed and moving c6 to its own bug:  crbug.com/872434

Comment 13 by vabr@chromium.org, Aug 28

Cc: -vabr@chromium.org
Ad #6, please see  https://crbug.com/872434#c1

Comment 14 by yyushkina@chromium.org, Aug 30 

Do we need to add this to the remote NTP?

Comment 15 by ramyan@chromium.org, Sep 10 

No need to add to remote. The remote NTP uses a different version of the OGB, so it should not have been affected by this. In any case, for something of this severity, I'd like to forego remote NTP changes.
►

Sign in to add a comment