New issue
Advanced search Search tips

Issue 871154 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 19
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Feature



Sign in to add a comment

VideoEncodeAccelerator: add initial_framerate to initial Config

Project Member Reported by johnylin@chromium.org, Aug 6

Issue description

Currently on VideoEncodeAccelerator::Initialize() deafult framerate is always used to initialize encoder. As we have profile and level of H.264 encoding in initial Config, framerate should be also adjustable on initialization for the client to configure a supportable parameter set under the limit of of profile/level.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 13

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fc7b5a87f0cb6051946786654a9f594912a0c780

commit fc7b5a87f0cb6051946786654a9f594912a0c780
Author: Pin-chih Lin <johnylin@chromium.org>
Date: Mon Aug 13 05:44:17 2018

video_encode_accelerator: add initial_framerate to initial Config

Currently on VideoEncodeAccelerator::Initialize() deafult framerate is
always used to initialize encoder. As we have profile and level of H.264
encoding in initial Config, framerate should be also adjustable on
initialization for the client to configure a supportable parameter set
under the limit of of profile/level.

BUG= 871154 
TEST=build and deploy chrome on eve
TEST=build and run video_encoder_accelerator_unittest on eve

Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel
Change-Id: Ifd6e33ada82d44c0e1b46f56856caeec9600e139
Reviewed-on: https://chromium-review.googlesource.com/1163592
Reviewed-by: Dan Sanders <sandersd@chromium.org>
Reviewed-by: Pawel Osciak <posciak@chromium.org>
Reviewed-by: Daniel Cheng <dcheng@chromium.org>
Commit-Queue: Pin-chih Lin <johnylin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582510}
[modify] https://crrev.com/fc7b5a87f0cb6051946786654a9f594912a0c780/media/gpu/v4l2/v4l2_video_encode_accelerator.cc
[modify] https://crrev.com/fc7b5a87f0cb6051946786654a9f594912a0c780/media/gpu/v4l2/v4l2_video_encode_accelerator.h
[modify] https://crrev.com/fc7b5a87f0cb6051946786654a9f594912a0c780/media/gpu/vaapi/vaapi_video_encode_accelerator.cc
[modify] https://crrev.com/fc7b5a87f0cb6051946786654a9f594912a0c780/media/gpu/video_encode_accelerator_unittest.cc
[modify] https://crrev.com/fc7b5a87f0cb6051946786654a9f594912a0c780/media/mojo/interfaces/video_encode_accelerator.mojom
[modify] https://crrev.com/fc7b5a87f0cb6051946786654a9f594912a0c780/media/mojo/interfaces/video_encode_accelerator_mojom_traits.cc
[modify] https://crrev.com/fc7b5a87f0cb6051946786654a9f594912a0c780/media/mojo/interfaces/video_encode_accelerator_mojom_traits.h
[modify] https://crrev.com/fc7b5a87f0cb6051946786654a9f594912a0c780/media/video/video_encode_accelerator.cc
[modify] https://crrev.com/fc7b5a87f0cb6051946786654a9f594912a0c780/media/video/video_encode_accelerator.h

Status: Fixed (was: Started)

Sign in to add a comment