New issue
Advanced search Search tips

Issue 871134 link

Starred by 0 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 16
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 3
Type: Feature



Sign in to add a comment

chromite: move run_tests to top level

Project Member Reported by vapier@chromium.org, Aug 6

Issue description

cbuildbot/run_tests is the general chromite test runner.  there are historical reasons for it living there, but we should move it to the top level now.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/chromite/+/9ff80dee982b37b6f1c2c123983107e96aa63136

commit 9ff80dee982b37b6f1c2c123983107e96aa63136
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Aug 15 23:37:14 2018

run_tests: relocate & create toplevel wrapper

Move cbuildbot/run_tests into scripts/ since it works for the entire
repo and is no longer cbuildbot-specific.

Having it in any subdir makes it a bit hard to locate, so add a small
wrapper to the top dir.  This is a somewhat common idiom.

We don't move all 4 files to the top level to avoid adding 3 files
that most people don't care about.  This is also why we write a very
tiny wrapper to hit the right script.

BUG= chromium:871134 
TEST=`./run_tests` passes
CQ-DEPEND=CL:1175426

Change-Id: I0d535be29f311e39442917347c49b710b2c7db8b
Reviewed-on: https://chromium-review.googlesource.com/1175422
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Lann Martin <lannm@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[add] https://crrev.com/9ff80dee982b37b6f1c2c123983107e96aa63136/scripts/run_tests
[add] https://crrev.com/9ff80dee982b37b6f1c2c123983107e96aa63136/scripts/run_tests_unittest
[delete] https://crrev.com/296f4252183dddc005977280480f88dfe5c82fd7/cbuildbot/run_tests_unittest
[add] https://crrev.com/9ff80dee982b37b6f1c2c123983107e96aa63136/run_tests
[delete] https://crrev.com/296f4252183dddc005977280480f88dfe5c82fd7/cbuildbot/run_tests
[rename] https://crrev.com/9ff80dee982b37b6f1c2c123983107e96aa63136/scripts/run_tests.py
[modify] https://crrev.com/9ff80dee982b37b6f1c2c123983107e96aa63136/cbuildbot/stages/test_stages.py
[rename] https://crrev.com/9ff80dee982b37b6f1c2c123983107e96aa63136/scripts/run_tests_unittest.py
[modify] https://crrev.com/9ff80dee982b37b6f1c2c123983107e96aa63136/README.md

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 15

The following revision refers to this bug:
  https://chromium.googlesource.com/chromiumos/overlays/chromiumos-overlay/+/473ec4c5adb2986dd11fed37d246b41a129fdf59

commit 473ec4c5adb2986dd11fed37d246b41a129fdf59
Author: Mike Frysinger <vapier@chromium.org>
Date: Wed Aug 15 23:37:15 2018

chromite: update path to run_tests

BUG= chromium:871134 
TEST=precq passes
CQ-DEPEND=CL:1175422

Change-Id: Ia1f3d02ae262e676e1eefe1c52611c7f454280bb
Reviewed-on: https://chromium-review.googlesource.com/1175426
Commit-Ready: Mike Frysinger <vapier@chromium.org>
Tested-by: Mike Frysinger <vapier@chromium.org>
Reviewed-by: Don Garrett <dgarrett@chromium.org>

[modify] https://crrev.com/473ec4c5adb2986dd11fed37d246b41a129fdf59/chromeos-base/chromite/chromite-9999.ebuild

Status: Fixed (was: Assigned)

Sign in to add a comment