New issue
Advanced search Search tips

Issue 871116 link

Starred by 2 users
Status: Fixed
Owner:
loyso@chromium.org
Closed: Oct 17
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Feature

Blocking:
issue 877898



Sign in to add a comment

Be able to switch between PWA implementations inside the WebAppProvider.

Project Member Reported by loyso@chromium.org, Aug 6 
- Make WebAppProvider a single entry point for all external web_appplications/
clients.
- Introduce DesktopPWAsWithoutExtensions command line switch.
- Be able to switch between old extension-based bookmark_apps/ and
new off-extensions bookmark_apps2/ implementations inside the WebAppProvider.

Comment 1 by loyso@chromium.org, Aug 6

Description: Show this description

Comment 2 by loyso@google.com, Aug 15 

Project BMO (Beemo): "new Bookmark Apps based off-extensions".
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/11c7760b9acac76ae04e2ad209b9cf8ae6cd59d2

commit 11c7760b9acac76ae04e2ad209b9cf8ae6cd59d2
Author: Alexey Baskakov <loyso@chromium.org>
Date: Thu Aug 16 05:51:30 2018

Apps: Extract all extension-specific code from StartupBrowserCreatorImpl

1) Extract all extension-specific code from StartupBrowserCreatorImpl into
platform_app_launch.cc.

2) Redirect all chrome/browser/ui |OpenWindow| queries to apps_launch.h
which allows us to create a BMO implementation.

We will replace this launching code with our extension-independent
implementation later.

Bug:  871116 
Change-Id: Idd6a9c37bb33bfab7bcf75d2af0b4473647a1b89
Reviewed-on: https://chromium-review.googlesource.com/1175507
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Reviewed-by: Dominick Ng <dominickn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583558}
[add] https://crrev.com/11c7760b9acac76ae04e2ad209b9cf8ae6cd59d2/chrome/browser/apps/BUILD.gn
[add] https://crrev.com/11c7760b9acac76ae04e2ad209b9cf8ae6cd59d2/chrome/browser/apps/apps_launch.cc
[add] https://crrev.com/11c7760b9acac76ae04e2ad209b9cf8ae6cd59d2/chrome/browser/apps/apps_launch.h
[modify] https://crrev.com/11c7760b9acac76ae04e2ad209b9cf8ae6cd59d2/chrome/browser/apps/platform_apps/BUILD.gn
[add] https://crrev.com/11c7760b9acac76ae04e2ad209b9cf8ae6cd59d2/chrome/browser/apps/platform_apps/platform_app_launch.cc
[add] https://crrev.com/11c7760b9acac76ae04e2ad209b9cf8ae6cd59d2/chrome/browser/apps/platform_apps/platform_app_launch.h
[modify] https://crrev.com/11c7760b9acac76ae04e2ad209b9cf8ae6cd59d2/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/11c7760b9acac76ae04e2ad209b9cf8ae6cd59d2/chrome/browser/ui/startup/startup_browser_creator_impl.cc

Comment 4 by loyso@google.com, Aug 16

Status: Assigned (was: Started)

Comment 5 by loyso@chromium.org, Aug 27

Blocking: 877898
Project Member

Comment 6 by bugdroid1@chromium.org, Oct 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21

commit fd3894ec9d6adfab26f5e4aa895f2902d8e02d21
Author: Alexey Baskakov <loyso@chromium.org>
Date: Tue Oct 16 06:09:58 2018

WebApp: Introduce WebApp, WebAppRegistrar and InstallManager entities.

Introduce DesktopPWAsWithoutExtensions command line switch.

A WebApp represents single web app.
WebApp objects are owned by WebAppRegistrar.

WebAppRegistrar is a root entity which is able to add/remove new apps.
Later WebAppRegistrar will be able:
- to iterate over all the registered apps.
- to iterate over various subsets of all registered apps (shortcut apps)
- to survive the browser (and ChromeOS) relaunch (persistence)

InstallManager is an abstract manager to plumb 3-dot menu user installation.
We will evolve its WebAppInstallManager implementation
into comprehensive install manager later.

--enable-features=DesktopPWAsWithoutExtensions will enable off-extensions
implementation for Desktop PWAs.

Bug: 891172,  871116 
Change-Id: Iebcbd93cf08eec0f11c7c22dce57ded81a2a2e94
Reviewed-on: https://chromium-review.googlesource.com/c/1275468
Reviewed-by: Ben Wells <benwells@chromium.org>
Reviewed-by: Trent Apted <tapted@chromium.org>
Commit-Queue: Alexey Baskakov <loyso@chromium.org>
Cr-Commit-Position: refs/heads/master@{#599887}
[modify] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/BUILD.gn
[modify] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/chromeos/BUILD.gn
[modify] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/ui/BUILD.gn
[modify] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/ui/browser_commands.cc
[modify] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/BUILD.gn
[modify] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/bookmark_apps/BUILD.gn
[add] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/bookmark_apps/bookmark_app_install_manager.cc
[add] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/bookmark_apps/bookmark_app_install_manager.h
[modify] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/components/BUILD.gn
[add] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/components/install_manager.h
[modify] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/components/install_result_code.h
[modify] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/extensions/BUILD.gn
[add] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/test/web_app_test.cc
[add] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/test/web_app_test.h
[add] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/web_app.cc
[add] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/web_app.h
[add] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/web_app_install_manager.cc
[add] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/web_app_install_manager.h
[add] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/web_app_install_manager_unittest.cc
[modify] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/web_app_provider.cc
[modify] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/web_app_provider.h
[add] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/web_app_registrar.cc
[add] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/web_app_registrar.h
[add] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/web_app_registrar_unittest.cc
[add] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/web_app_utils.cc
[add] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/browser/web_applications/web_app_utils.h
[modify] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/common/chrome_features.cc
[modify] https://crrev.com/fd3894ec9d6adfab26f5e4aa895f2902d8e02d21/chrome/common/chrome_features.h

Comment 7 by loyso@chromium.org, Oct 17

Status: Fixed (was: Assigned)
►

Sign in to add a comment