New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 871113 link

Starred by 8 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 7
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Chrome_Mac: Crash Report - content::internal::ChildProcessLauncherHelper::BeforeLaunchOnLauncherThread

Project Member Reported by crash-fe...@system.gserviceaccount.com, Aug 6

Issue description

reporter:ajha@google.com

Magic Signature: content::internal::ChildProcessLauncherHelper::BeforeLaunchOnLauncherThread

Crash link: https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27content%3A%3Ainternal%3A%3AChildProcessLauncherHelper%3A%3ABeforeLaunchOnLauncherThread%27+AND+product_name%3D%27Chrome_Mac%27+AND+product.Version%3D%2770.0.3513.0%27&stbtiq=&reportid=&index=0

-------------------------------------------------------------------------------
Sample Report
-------------------------------------------------------------------------------
Product name: Chrome_Mac
Magic Signature : content::internal::ChildProcessLauncherHelper::BeforeLaunchOnLauncherThread
Product Version: 70.0.3513.0
Process type: browser
Report ID: 606c2cb8619b9744
Report Url: https://crash.corp.google.com/606c2cb8619b9744
Report Time: 2018-08-05T19:54:43-07:00
Upload Time: 2018-08-05T19:54:44.18-07:00
Uptime: 35000 ms
OS Name: Mac OS X
OS Version: 10.13.6 17G65
CPU Architecture: amd64
CPU Info: family 6 model 42 stepping 7

-------------------------------------------------------------------------------
Crashing thread: Thread index: 23. Stack Quality: 83%. Thread id: 22641.
-------------------------------------------------------------------------------
0x000000010515f9b1 (Google Chrome Framework - child_process_launcher_helper_mac.cc: 136)	content::internal::ChildProcessLauncherHelper::BeforeLaunchOnLauncherThread(content::PosixFileDescriptorInfo const&, base::LaunchOptions*)
0x000000010515eda9 (Google Chrome Framework - child_process_launcher_helper.cc: 112)	content::internal::ChildProcessLauncherHelper::LaunchOnLauncherThread()
0x00000001068346d1 (Google Chrome Framework - callback.h: 99)	base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*)
0x00000001068aab1c (Google Chrome Framework - task_tracker.cc: 529)	base::internal::TaskTracker::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool)
0x00000001068ea8c2 (Google Chrome Framework - task_tracker_posix.cc: 23)	base::internal::TaskTrackerPosix::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool)
0x00000001068aa38f (Google Chrome Framework - task_tracker.cc: 404)	base::internal::TaskTracker::RunAndPopNextTask(scoped_refptr<base::internal::Sequence>, base::internal::CanScheduleSequenceObserver*)
0x00000001068a39ae (Google Chrome Framework - scheduler_worker.cc: 330)	base::internal::SchedulerWorker::RunWorker()
0x00000001068a3813 (Google Chrome Framework - scheduler_worker.cc: 248)	base::internal::SchedulerWorker::RunDedicatedWorker()
0x00000001068ead06 (Google Chrome Framework - platform_thread_posix.cc: 76)	base::(anonymous namespace)::ThreadFunc(void*)
0x00007fff57874660 (libsystem_pthread.dylib + 0x00003660)	_pthread_body
0x00007fff5787450c (libsystem_pthread.dylib + 0x0000350c)	_pthread_start
0x00007fff57873bf8 (libsystem_pthread.dylib + 0x00002bf8)	thread_start
0x00000001068eacaf (Google Chrome Framework + 0x023fbcaf)	

-------------------------------------------------------------------------------
Manual regression range finder link
-------------------------------------------------------------------------------
https://crash.corp.google.com/browse?q=expanded_custom_data.ChromeCrashProto.magic_signature_1.name%3D%27content%3A%3Ainternal%3A%3AChildProcessLauncherHelper%3A%3ABeforeLaunchOnLauncherThread%27#-property-selector,-samplereports,+productname,+productversion:1000,+directory,-clientid,+operatingsystem,+url,+simplifiedurl,+extensions

 
Cc: kerrnel@chromium.org abdulsyed@chromium.org ajha@chromium.org ligim...@chromium.org
Components: Internals
Labels: -Type-Bug -Pri-2 RegressedIn-70 ReleaseBlock-Dev TE-CrashTriage Target-70 M-70 FoundIn-70 Pri-1 Type-Bug-Regression
Owner: rsesek@chromium.org
Status: Assigned (was: Untriaged)
Spiked on the Mac canary since 70.0.3512.0 and has reported 3 digits of crashes in last 2 canary and is ranked as #1 browser process relate crash.

https://chromium.googlesource.com/chromium/src/+log/70.0.3511.0..70.0.3512.0?pretty=fuller&n=10000

suspected CL: https://chromium-review.googlesource.com/c/chromium/src/+/1152080.

kerrnel@/ rsesek@: Could you please take a look at these crashes and revert the suspected CL as we have scheduled M-70 dev release tomorrow.
Owner: ellyjo...@chromium.org
Taking this since rsesek@ is OOO.
Cc: gov...@chromium.org
I see a revert of the suspected CL by sheriffs: <https://chromium-review.googlesource.com/c/chromium/src/+/1163230>

That revert did not make today's canary, but the culprit commit made it into 70.0.3512.0.

+cc govind@ - we probably need a Mac canary respin, this bug kills it :)
Issue 871240 has been merged into this issue.

Comment 6 Deleted

Comment 7 Deleted

Thank you ellyjones@.

I've merged the revert to canary branch 3514 - https://chromium.googlesource.com/chromium/src.git/+/3792c7a03e8548e70b3457a6ea4710b8b72a363c. Pls review. 

+abduslyed@ (M70 Desktop Release TPM) to trigger new Mac Canary when ready.
Abdul triggered new canary #70.0.3514.2 with revert listed at #8 in. 
Labels: -Restrict-View-EditIssue
Status: Started (was: Assigned)
Stripping R-V-EI since a) this is not exploitable and b) I need to be able to link people to this bug :)
 Issue 871346  has been merged into this issue.
Crash is resolved in the latest mac canary- 70.0.3514.2	
Status: Fixed (was: Started)
#12: Thanks!

Sign in to add a comment