New issue
Advanced search Search tips

Issue 871106 link

Starred by 2 users

Issue metadata

Status: Fixed
Owner: ----
Closed: Aug 6
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: ----



Sign in to add a comment

browser_tests failing on Mac

Project Member Reported by sheriff-...@appspot.gserviceaccount.com, Aug 6

Issue description

Filed by sheriff-o-matic@appspot.gserviceaccount.com on behalf of ksakamoto@google.com

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28413
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14761

failures:
PPAPINaClGLibcTest.UDPSocket_ReadWrite
PPAPINaClGLibcTest.UDPSocket_ParallelSend
NewlibPackagedAppTest.NoSocketPermissions
PPAPINaClGLibcTest.UDPSocket_SetOption
NaClBrowserTestNewlibVcacheExtension.ValidationCacheOfMainNexe
NaClGdbDebugStubTest.Breakpoint
LazyBackgroundPageApiTest.NaClInBackgroundPage
NaClBrowserTestGLibcVcacheExtension.ValidationCacheOfMainNexe
NaClBrowserTestPnaclDebugMasked.PnaclDebugURLFlagMaskedOff
NaClBrowserTestStatic.CrossOriginCORS
PPAPINaClGLibcTest.UDPSocket_Multicast
NaClBrowserTestStatic.RelativeManifest
NaClBrowserTestPnaclSubzero.SuccessfulLoadUMA
PPAPINaClTestDisallowedSockets.HostResolverPrivateDisallowed
PPAPINaClTestDisallowedSockets.TCPServerSocketPrivateDisallowed
PPAPINaClGLibcTest.UDPSocket_SetOption_1_0
PPAPINaClGLibcTest.UDPSocket_SetOption_1_1
PPAPINaClTestDisallowedSockets.UDPSocketPrivateDisallowed
ChromeServiceWorkerFetchPPAPITest.NotInterceptedByServiceWorker
NaClGdbDebugStubTest.Empty
NaClBrowserTestPnaclDebug.PnaclDebugURLFlagAndURL
PPAPINaClGLibcTest.AudioConfig
NaClBrowserTestStatic.SameOriginCookie
PPAPINaClGLibcTest.UDPSocket_Broadcast
LazyBackgroundPageApiTest.NaClInView
PPAPINaClTestDisallowedSockets.TCPSocketPrivateDisallowed
NaClBrowserTestPnaclDebug.PnaclDebugURLFlagNoURL
MediaGalleriesPlatformAppPpapiTest.SendFilesystem
NaClBrowserTestPnaclSubzero.PnaclErrorHandling
AppBackgroundPageNaClTest.BackgroundKeepaliveActive
... 3 more (33 total) ...

[16821:42243:0803/172415.210423:FATAL:child_process_launcher_helper_mac.cc(136)] Check failed: false.
0   browser_tests                       0x0000000106ae11ac base::debug::StackTrace::StackTrace(unsigned long) + 28
1   browser_tests                       0x0000000106a41551 logging::LogMessage::~LogMessage() + 225
2   browser_tests                       0x00000001056f8f4c content::internal::ChildProcessLauncherHelper::BeforeLaunchOnLauncherThread(content::PosixFileDescriptorInfo const&, base::LaunchOptions*) + 844
3   browser_tests                       0x00000001056f847a content::internal::ChildProcessLauncherHelper::LaunchOnLauncherThread() + 90
4   browser_tests                       0x0000000106a2f782 base::debug::TaskAnnotator::RunTask(char const*, base::PendingTask*) + 242
5   browser_tests                       0x0000000106aa89bd base::internal::TaskTracker::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) + 909
6   browser_tests                       0x0000000106ae9f23 base::internal::TaskTrackerPosix::RunOrSkipTask(base::internal::Task, base::internal::Sequence*, bool) + 83
7   browser_tests                       0x0000000106aa824a base::internal::TaskTracker::RunAndPopNextTask(scoped_refptr<base::internal::Sequence>, base::internal::CanScheduleSequenceObserver*) + 282
8   browser_tests                       0x0000000106aa172f base::internal::SchedulerWorker::RunWorker() + 383
9   browser_tests                       0x0000000106aa1594 base::internal::SchedulerWorker::RunDedicatedWorker() + 20
10  browser_tests                       0x0000000106aea407 base::(anonymous namespace)::ThreadFunc(void*) + 87
11  libsystem_pthread.dylib             0x00007fffcf3bb93b _pthread_body + 180
12  libsystem_pthread.dylib             0x00007fffcf3bb887 _pthread_body + 0
13  libsystem_pthread.dylib             0x00007fffcf3bb08d thread_start + 13

Suspecting https://chromium-review.googlesource.com/c/chromium/src/+/1152080

 
 Issue 871101  has been merged into this issue.
 Issue 871100  has been merged into this issue.
 Issue 871099  has been merged into this issue.
 Issue 871098  has been merged into this issue.
 Issue 871046  has been merged into this issue.
 Issue 871032  has been merged into this issue.
 Issue 871014  has been merged into this issue.
 Issue 871044  has been merged into this issue.
 Issue 871096  has been merged into this issue.
 Issue 871097  has been merged into this issue.
 Issue 871095  has been merged into this issue.
Project Member

Comment 12 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/581f1e6240de644f7f3bcd671355187f28d3fd00

commit 581f1e6240de644f7f3bcd671355187f28d3fd00
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Mon Aug 06 03:03:15 2018

Revert "[Mac] Bring up the audio service sandbox."

This reverts commit dc7c07308016766a798dac600d8a9cb2bb44a43d.

Reason for revert: suspected of breakage in 'browser_tests' on Mac:  crbug.com/871106 

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28413
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14761


Original change's description:
> [Mac] Bring up the audio service sandbox.
> 
> This requires --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox
> 
> Bug:  850878 
> Change-Id: I9c759b2537483612f9b3106bdf2ec193b343f198
> Reviewed-on: https://chromium-review.googlesource.com/1152080
> Reviewed-by: Greg Kerr <kerrnel@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580672}

TBR=avi@chromium.org,kerrnel@chromium.org,rsesek@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  850878 , 871106 
Change-Id: I022d7308ff4e351a2c657c4d2157bd0e3d8fcd89
Reviewed-on: https://chromium-review.googlesource.com/1163230
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580793}
[modify] https://crrev.com/581f1e6240de644f7f3bcd671355187f28d3fd00/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/581f1e6240de644f7f3bcd671355187f28d3fd00/services/service_manager/sandbox/BUILD.gn
[modify] https://crrev.com/581f1e6240de644f7f3bcd671355187f28d3fd00/services/service_manager/sandbox/mac/BUILD.gn
[delete] https://crrev.com/2ce2ffc84e03b4e03e019ae89d536e2126f1372d/services/service_manager/sandbox/mac/audio.sb
[modify] https://crrev.com/581f1e6240de644f7f3bcd671355187f28d3fd00/services/service_manager/sandbox/mac/common_v2.sb
[modify] https://crrev.com/581f1e6240de644f7f3bcd671355187f28d3fd00/services/service_manager/sandbox/mac/sandbox_mac.mm
[modify] https://crrev.com/581f1e6240de644f7f3bcd671355187f28d3fd00/services/service_manager/sandbox/sandbox_type.cc

Status: Fixed (was: Available)
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 6

Labels: merge-merged-3514
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3792c7a03e8548e70b3457a6ea4710b8b72a363c

commit 3792c7a03e8548e70b3457a6ea4710b8b72a363c
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Mon Aug 06 15:02:20 2018

Revert "[Mac] Bring up the audio service sandbox."

This reverts commit dc7c07308016766a798dac600d8a9cb2bb44a43d.

Reason for revert: suspected of breakage in 'browser_tests' on Mac:  crbug.com/871106 

https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28413
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14761


Original change's description:
> [Mac] Bring up the audio service sandbox.
> 
> This requires --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox
> 
> Bug:  850878 
> Change-Id: I9c759b2537483612f9b3106bdf2ec193b343f198
> Reviewed-on: https://chromium-review.googlesource.com/1152080
> Reviewed-by: Greg Kerr <kerrnel@chromium.org>
> Reviewed-by: Avi Drissman <avi@chromium.org>
> Commit-Queue: Robert Sesek <rsesek@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580672}

TBR=avi@chromium.org,kerrnel@chromium.org,rsesek@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  850878 , 871106 
Change-Id: I022d7308ff4e351a2c657c4d2157bd0e3d8fcd89
Reviewed-on: https://chromium-review.googlesource.com/1163230
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#580793}(cherry picked from commit 581f1e6240de644f7f3bcd671355187f28d3fd00)
Reviewed-on: https://chromium-review.googlesource.com/1162117
Reviewed-by: Krishna Govind <govind@chromium.org>
Cr-Commit-Position: refs/branch-heads/3514@{#3}
Cr-Branched-From: d614235c00db75b9ab192974fcbd16755a557471-refs/heads/master@{#580790}
[modify] https://crrev.com/3792c7a03e8548e70b3457a6ea4710b8b72a363c/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/3792c7a03e8548e70b3457a6ea4710b8b72a363c/services/service_manager/sandbox/BUILD.gn
[modify] https://crrev.com/3792c7a03e8548e70b3457a6ea4710b8b72a363c/services/service_manager/sandbox/mac/BUILD.gn
[delete] https://crrev.com/4d5325a62a5be7f88c50524f8e4f4807908cd514/services/service_manager/sandbox/mac/audio.sb
[modify] https://crrev.com/3792c7a03e8548e70b3457a6ea4710b8b72a363c/services/service_manager/sandbox/mac/common_v2.sb
[modify] https://crrev.com/3792c7a03e8548e70b3457a6ea4710b8b72a363c/services/service_manager/sandbox/mac/sandbox_mac.mm
[modify] https://crrev.com/3792c7a03e8548e70b3457a6ea4710b8b72a363c/services/service_manager/sandbox/sandbox_type.cc

Project Member

Comment 15 by bugdroid1@chromium.org, Aug 8

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aec2d9df7e61a6d5fb13e8a6ec018a06126c1135

commit aec2d9df7e61a6d5fb13e8a6ec018a06126c1135
Author: Marina Ciocea <marinaciocea@chromium.org>
Date: Wed Aug 08 08:27:55 2018

Reland "[Mac] Bring up the audio service sandbox."

This reverts commit 581f1e6240de644f7f3bcd671355187f28d3fd00.

Reason for revert: Found issue causing initial revert, minor fix required.

Original change's description:
> Revert "[Mac] Bring up the audio service sandbox."
>
> This reverts commit dc7c07308016766a798dac600d8a9cb2bb44a43d.
>
> Reason for revert: suspected of breakage in 'browser_tests' on Mac:  crbug.com/871106 
>
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.11%20Tests/28413
> https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Mac10.12%20Tests/14761
>
>
> Original change's description:
> > [Mac] Bring up the audio service sandbox.
> >
> > This requires --enable-features=AudioServiceAudioStreams,AudioServiceOutOfProcess,AudioServiceSandbox
> >
> > Bug:  850878 
> > Change-Id: I9c759b2537483612f9b3106bdf2ec193b343f198
> > Reviewed-on: https://chromium-review.googlesource.com/1152080
> > Reviewed-by: Greg Kerr <kerrnel@chromium.org>
> > Reviewed-by: Avi Drissman <avi@chromium.org>
> > Commit-Queue: Robert Sesek <rsesek@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#580672}
>
> TBR=avi@chromium.org,kerrnel@chromium.org,rsesek@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug:  850878 , 871106 
> Change-Id: I022d7308ff4e351a2c657c4d2157bd0e3d8fcd89
> Reviewed-on: https://chromium-review.googlesource.com/1163230
> Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580793}

TBR=avi@chromium.org,ksakamoto@chromium.org,kerrnel@chromium.org,rsesek@chromium.org


Bug:  850878 ,  871106 
Change-Id: I88ac82097e8cd0af0bc72c7cac3b90f63dcf633b
Reviewed-on: https://chromium-review.googlesource.com/1164983
Reviewed-by: Marina Ciocea <marinaciocea@chromium.org>
Commit-Queue: Marina Ciocea <marinaciocea@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581500}
[modify] https://crrev.com/aec2d9df7e61a6d5fb13e8a6ec018a06126c1135/content/browser/child_process_launcher_helper_mac.cc
[modify] https://crrev.com/aec2d9df7e61a6d5fb13e8a6ec018a06126c1135/services/service_manager/sandbox/BUILD.gn
[modify] https://crrev.com/aec2d9df7e61a6d5fb13e8a6ec018a06126c1135/services/service_manager/sandbox/mac/BUILD.gn
[add] https://crrev.com/aec2d9df7e61a6d5fb13e8a6ec018a06126c1135/services/service_manager/sandbox/mac/audio.sb
[modify] https://crrev.com/aec2d9df7e61a6d5fb13e8a6ec018a06126c1135/services/service_manager/sandbox/mac/common_v2.sb
[modify] https://crrev.com/aec2d9df7e61a6d5fb13e8a6ec018a06126c1135/services/service_manager/sandbox/mac/sandbox_mac.mm
[modify] https://crrev.com/aec2d9df7e61a6d5fb13e8a6ec018a06126c1135/services/service_manager/sandbox/sandbox_type.cc

Sign in to add a comment