New issue
Advanced search Search tips

Issue 871042 link

Starred by 1 user

Issue metadata

Status: Verified
Owner:
Closed: Aug 6
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug



Sign in to add a comment

ASSERT: type == ObjectType::kCompressed

Project Member Reported by ClusterFuzz, Aug 4

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4670990152630272

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  type == ObjectType::kCompressed
  CPDF_Parser::LoadCrossRefV5
  CPDF_Parser::LoadAllCrossRefV5
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=580751:580752

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4670990152630272

Issue filed automatically.

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 4

Components: Internals>Plugins>PDF
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Aug 4

Labels: Test-Predator-Auto-Owner
Owner: thestig@chromium.org
Status: Assigned (was: Untriaged)
Automatically assigning owner based on suspected regression changelist https://pdfium.googlesource.com/pdfium/+/ac1dfb0ef15e273aab6476a460dfd4f2778e9703 (Clarify integer types in CPDF_Parser::LoadCrossRefV5().).

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label. If you aren't the correct owner for this issue, please unassign yourself as soon as possible so it can be re-triaged.
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://pdfium.googlesource.com/pdfium/+/475565477e431cd2925a6192b348d142beb21b4d

commit 475565477e431cd2925a6192b348d142beb21b4d
Author: Lei Zhang <thestig@chromium.org>
Date: Mon Aug 06 18:08:45 2018

Check for null object type in CPDF_Parser::LoadCrossRefV5().

BUG= chromium:871042 

Change-Id: Id4566b29270ab738c69d46cb96fc134485d6ee2f
Reviewed-on: https://pdfium-review.googlesource.com/39510
Reviewed-by: Art Snake <art-snake@yandex-team.ru>
Commit-Queue: Lei Zhang <thestig@chromium.org>

[modify] https://crrev.com/475565477e431cd2925a6192b348d142beb21b4d/core/fpdfapi/parser/cpdf_parser.cpp

Status: Fixed (was: Assigned)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2bcd41ba7ab4142b74b4d95a4417c78161774d93

commit 2bcd41ba7ab4142b74b4d95a4417c78161774d93
Author: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Mon Aug 06 20:03:29 2018

Roll src/third_party/pdfium a7a957f7cec2..f3a3393a2f96 (5 commits)

https://pdfium.googlesource.com/pdfium.git/+log/a7a957f7cec2..f3a3393a2f96


git log a7a957f7cec2..f3a3393a2f96 --date=short --no-merges --format='%ad %ae %s'
2018-08-06 thestig@chromium.org Avoid invalid object numbers in CPDF_Parser::LoadCrossRefV5().
2018-08-06 tsepez@chromium.org Small optimization in CJBig2_Image::SubImage()
2018-08-06 thestig@chromium.org Check for null object type in CPDF_Parser::LoadCrossRefV5().
2018-08-06 thestig@chromium.org Do more CPDF_Parser::LoadCrossRefV5() cleanup.
2018-08-06 rharrison@chromium.org Clean up a nit that was identified after CQing an earlier CL


Created with:
  gclient setdep -r src/third_party/pdfium@f3a3393a2f96

The AutoRoll server is located here: https://pdfium-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.



BUG= chromium:865272 , chromium:871042 , chromium:863098 
TBR=dsinclair@chromium.org

Change-Id: I244334140b9abd5f018f052799d278320c51e5fc
Reviewed-on: https://chromium-review.googlesource.com/1163845
Reviewed-by: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: pdfium-chromium-autoroll <pdfium-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580959}
[modify] https://crrev.com/2bcd41ba7ab4142b74b4d95a4417c78161774d93/DEPS

Project Member

Comment 6 by ClusterFuzz, Aug 7

ClusterFuzz has detected this issue as fixed in range 580951:581109.

Detailed report: https://clusterfuzz.com/testcase?key=4670990152630272

Fuzzer: libFuzzer_pdfium_xfa_fuzzer
Job Type: libfuzzer_chrome_asan_debug
Platform Id: linux

Crash Type: ASSERT
Crash Address: 
Crash State:
  type == ObjectType::kCompressed
  CPDF_Parser::LoadCrossRefV5
  CPDF_Parser::LoadAllCrossRefV5
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=580751:580752
Fixed: https://clusterfuzz.com/revisions?job=libfuzzer_chrome_asan_debug&range=580951:581109

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4670990152630272

See https://chromium.googlesource.com/chromium/src/+/master/testing/libfuzzer/reference.md for more information.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 7 by ClusterFuzz, Aug 7

Labels: ClusterFuzz-Verified
Status: Verified (was: Fixed)
ClusterFuzz testcase 4670990152630272 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment