150,000 lines of "glSetColorSpaceMetadataCHROMIUM: no image associated with texture" in layout test stderr |
|||
Issue descriptionOn the mac bots we get 150,000+ lines of the following error when running layout tests: ----------------8<---------------- 15:52:27.806 13879 [13912:775:0802/155227.452902:ERROR:gles2_cmd_decoder.cc(12758)] [.RenderCompositor-0x7fdfd6819600]GL ERROR :GL_INVALID_VALUE : glSetColorSpaceMetadataCHROMIUM: no image associated with texture ----------------8<---------------- https://logs.chromium.org/v/?s=chromium%2Fbb%2Fchromium.webkit%2FWebKit_Mac10.13__retina_%2F654%2F%2B%2Frecipes%2Fsteps%2Fwebkit_layout_tests_on_ATI_GPU_on_Mac_Retina_on_Mac-10.13.5%2F0%2Fstdout Is this error important? It makes the stderr logs difficult to read. It was added in https://chromium-review.googlesource.com/c/chromium/src/+/567580 but John Bauman has left. @dcheng, can you take a look?
,
Aug 5
Yes, it's that patch that is producing the spew ... but the fact that we're seeing that error suggests that something is going very wrong in those tests and they've just been silently going through a bad path.
,
Aug 5
It looks that these tests are creating lots of raster buffers but then not rasterizing anything into them (and so never allocating a GMB). Adding a comment that "don't log errors if you don't see a GMB, cause it'll spam everything".
,
Aug 5
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/dba5d7b0a7e5d683e98eaec38bd0acf468f62214 commit dba5d7b0a7e5d683e98eaec38bd0acf468f62214 Author: Christopher Cameron <ccameron@chromium.org> Date: Sun Aug 05 21:18:24 2018 Don't log unallocated GpuMemoryBuffers in ZeroCopyRasterBufferProvider Many blink layout tests take this path, resulting in lots of console spam. TBR=sunnyps Bug: 871031 , 654631 Cq-Include-Trybots: luci.chromium.try:android_optional_gpu_tests_rel;master.tryserver.blink:linux_trusty_blink_rel Change-Id: I683c42de3c9d956c3ea97f18027e4e1fbe3e5e8e Reviewed-on: https://chromium-review.googlesource.com/1163179 Reviewed-by: ccameron <ccameron@chromium.org> Commit-Queue: ccameron <ccameron@chromium.org> Cr-Commit-Position: refs/heads/master@{#580783} [modify] https://crrev.com/dba5d7b0a7e5d683e98eaec38bd0acf468f62214/cc/raster/zero_copy_raster_buffer_provider.cc
,
Aug 6
|
|||
►
Sign in to add a comment |
|||
Comment 1 by dcheng@chromium.org
, Aug 4