New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 871010 link

Starred by 4 users
Status: Started
Owner:
█ ramyan@chromium.org
OOO Jan 14 - 25
Cc:
yyushkina@chromium.org
kmilka@chromium.org
kristip...@chromium.org
█ sweilun@chromium.org
█ ramyan@chromium.org
ma...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux
Pri: 1
Type: Bug
Flaky-Test: BrowserNavigatorTest.Disposition_NewPopupFromAppPopup

Blocked on:
issue 466089


Sign in to add a comment

BrowserNavigatorTest.Disposition_NewPopupFromAppPopup and TabRestoreTest.RestoreWindowBounds are Flaky

Project Member Reported by Findit, Aug 4

Comment 3 by ksakamoto@chromium.org, Aug 6

Owner: ramyan@chromium.org
Status: Assigned (was: Available)
ramyan@ PTAL?

Comment 4 by ksakamoto@chromium.org, Aug 6 

Since Findit identified r580314 as the culprit of another regression too, I'm reverting it for now.

Comment 5 by ramyan@chromium.org, Aug 6

Cc: ma...@chromium.org yyushkina@chromium.org sweilun@chromium.org kristip...@chromium.org kmilka@chromium.org
Copied from comments in https://chromium-review.googlesource.com/c/chromium/src/+/1160925 (TabRestoreTest.RestoreWindowBounds is the other flaky test):

https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTQ1NThiNjYyZDliZjY5YjJlMzRiZjJkMTk4Y2FkOGRlNzQ3NzZkZgw

"NewTabPageCustomLinks" & "NewTabPageIcons" were the features enabled by experiment re-ordering in this CL. Will investigate further tomorrow.
Project Member

Comment 6 by bugdroid1@chromium.org, Aug 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94006a2aba37481e624cd8128908e3b303f28a52

commit 94006a2aba37481e624cd8128908e3b303f28a52
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Mon Aug 06 05:55:50 2018

Revert "[NTP] Adds an experiment for M69 NTP features."

This reverts commit 94558b662d9bf69b2e34bf2d198cad8de74776df.

Reason for revert: Findit thinks this made the following tests flaky:
TabRestoreTest.RestoreWindowBounds ( crbug.com/870945 )
BrowserNavigatorTest.Disposition_NewPopupFromAppPopup (crbug.com/871010)

Original change's description:
> [NTP] Adds an experiment for M69 NTP features.
> 
> Only the first experiment entry gets covered by perf waterfall, so adding
> this item ensures better test coverage. Also, the existing experiment,
> NewTabPageAllBirthday_Enabled, could not be re-used since
> go/revising-finch-configs recommends creating a new experiment when
> changing size or behavior of existing groups.
> 
> Bug: 831910
> Change-Id: I95ebc6f2768fe25d34993c05c71e35c22e2bdcc5
> Reviewed-on: https://chromium-review.googlesource.com/1160925
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580314}

TBR=holte@chromium.org,ramyan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 831910, 870945 ,871010
Change-Id: Ifb86fbc322d939eba40f84b1ee32a21d76361f86
Reviewed-on: https://chromium-review.googlesource.com/1163361
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580806}
[modify] https://crrev.com/94006a2aba37481e624cd8128908e3b303f28a52/testing/variations/fieldtrial_testing_config.json

Comment 7 by engedy@chromium.org, Aug 6

Labels: -Sheriff-Chromium

Comment 8 by engedy@chromium.org, Aug 6

Summary: BrowserNavigatorTest.Disposition_NewPopupFromAppPopup and TabRestoreTest.RestoreWindowBounds are Flaky (was: BrowserNavigatorTest.Disposition_NewPopupFromAppPopup is Flaky)

Comment 9 by engedy@chromium.org, Aug 6 

 Issue 870945  has been merged into this issue.

Comment 10 by ramyan@chromium.org, Aug 6

Status: Started (was: Assigned)

Comment 11 by ramyan@chromium.org, Aug 6 

After reviewing the links at https://findit-for-me.appspot.com/waterfall/flake/flake-culprit?key=ag9zfmZpbmRpdC1mb3ItbWVyQwsSDEZsYWtlQ3VscHJpdCIxY2hyb21pdW0vOTQ1NThiNjYyZDliZjY5YjJlMzRiZjJkMTk4Y2FkOGRlNzQ3NzZkZgw, and analyzing what happens in these browser tests, I don't think it has anything to do with the commit reviewed on https://chromium-review.googlesource.com/1160925

Both logs available for BrowserNavigatorTest.Disposition_NewPopupFromAppPopup indicate that account service was unreachable before a fatal error occurred:

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939152781923854080/+/steps/network_service_browser_tests/0/stdout:

[11514:11514:0803/213533.267074:WARNING:gaia_auth_fetcher.cc(924)] Could not reach Google Accounts servers: errno -11
[11514:11596:0803/213533.455015:FATAL:bind_internal.h(810)] Check failed: receiver->HasAtLeastOneRef(). base::Bind() refuses to create the first reference to ref-counted objects. That is typically happens around PostTask() in their constructor, and such objects can be destroyed before `new` returns if the task resolves fast enough.
#0 0x0000f75eccc9 base::debug::StackTrace::StackTrace()
#1 0x0000f72fc06e base::debug::StackTrace::StackTrace()


https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939065284424853760/+/steps/network_service_browser_tests/0/stdout:

[1716:2628:0804/205556.742:WARNING:gaia_auth_fetcher.cc(924)] Could not reach Google Accounts servers: errno -102
[1716:3460:0804/205556.742:WARNING:embedded_test_server.cc(238)] Request not handled. Returning 404: /favicon.ico
../../chrome/browser/password_manager/password_manager_browsertest.cc(845): error: Value of: prompt_observer->IsSavePromptShownAutomatically()
  Actual: false
Expected: true

The same is true for TabRestoreTest.RestoreWindowBounds:

https://logs.chromium.org/logs/chromium/buildbucket/cr-buildbucket.appspot.com/8939181963486694144/+/steps/network_service_browser_tests/0/stdout:

[13508:13508:0803/140147.124642:WARNING:gaia_auth_fetcher.cc(924)] Could not reach Google Accounts servers: errno -11
[13508:13764:0803/140147.377056:WARNING:embedded_test_server.cc(238)] Request not handled. Returning 404: /favicon.ico
../../base/test/metrics/histogram_tester.cc:202: Failure
Expected equality of these values:
  expected_count
    Which is: 1
  actual_count
    Which is: 0
Histogram "Autofill.SaveCreditCardPrompt.Local.FirstShow" does not have the right number of samples (1) in the expected bucket (3). It has (0).

Comment 12 by ramyan@chromium.org, Aug 6

Cc: ramyan@chromium.org
Owner: ksakamoto@chromium.org
This dashboard ends at 580769:

https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyxAELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCKNAWNocm9taXVtLndpbi9XaW43IFRlc3RzIChkYmcpKDEpLzcwNjk1L25ldHdvcmtfc2VydmljZV9icm93c2VyX3Rlc3RzL1FuSnZkM05sY2s1aGRtbG5ZWFJ2Y2xSbGMzUXVSR2x6Y0c5emFYUnBiMjVmVG1WM1VHOXdkWEJHY205dFFYQndVRzl3ZFhBPQwLEhNNYXN0ZXJGbGFrZUFuYWx5c2lzGAEM

 
Is there a way to refresh it to include 580806 (the revert cl), and afterwards? 

I'd like to confirm that the flakes continued after my config CL was reverted.

Comment 13 by ksakamoto@chromium.org, Aug 8

Owner: ramyan@chromium.org
Not sure whether we can update the findit dashboard, but this shows the tests are not flaky right now:

https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=network_service_browser_tests&tests=BrowserNavigatorTest.Disposition_NewPopupFromAppPopup%2CTabRestoreTest.RestoreWindowBounds

I think you can reland it and see if the test flakes again.
(My sheriff shift has ended, please ping current sheriffs.)

Comment 14 by ramyan@chromium.org, Aug 8 

Thanks, I've sent https://chromium-review.googlesource.com/c/chromium/src/+/1167562 to reland the change.

Comment 17 by fhorschig@chromium.org, Aug 20

Components: Tests>Flaky
Labels: OS-Linux
At least TabRestoreTest.RestoreWindowBounds is very, very flaky on  Linux Tests (dbg)(1)(32): https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=network_service_browser_tests&tests=BrowserNavigatorTest.Disposition_NewPopupFromAppPopup%2CTabRestoreTest.RestoreWindowBounds

This introduces quite some noise on the bot, so I am going to disable it for Linux now with https://crrev.com/c/1181048.

Latest failing build:
https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20Tests%20%28dbg%29%281%29%2832%29/52198

Example log:
[ RUN      ] TabRestoreTest.RestoreWindowBounds
Xlib:  extension "RANDR" missing on display ":99".
[7720:7720:0820/044330.035608:ERROR:browser_dm_token_storage_linux.cc(93)] Error: /etc/machine-id contains 32 characters (32 were expected).
[7720:7757:0820/044330.314153:ERROR:bus.cc(394)] Failed to connect to the bus: Could not parse server address: Unknown address type (examples of valid types are "tcp" and on UNIX "unix")
[7720:7720:0820/044330.355222:WARNING:password_store_factory.cc(261)] Using basic (unencrypted) store for password storage. See https://chromium.googlesource.com/chromium/src/+/master/docs/linux_password_storage.md for more information about password storage options.
[7755:7801:0820/044331.185642:WARNING:file_path_watcher_linux.cc(656)] Watch failed for /etc/../run/resolvconf: No such file or directory (2)
[7720:7720:0820/044331.286595:WARNING:gaia_auth_fetcher.cc(931)] Could not reach Google Accounts servers: errno -11
[7720:7720:0820/044332.537470:WARNING:gaia_auth_fetcher.cc(931)] Could not reach Google Accounts servers: errno -11
[7720:7720:0820/044332.889558:WARNING:render_frame_host_impl.cc(452)] InterfaceRequest was dropped, the document is no longer active: content.mojom.RendererAudioOutputStreamFactory
[7720:7720:0820/044332.889731:WARNING:render_frame_host_impl.cc(452)] InterfaceRequest was dropped, the document is no longer active: resource_coordinator.mojom.FrameCoordinationUnit
[7720:7720:0820/044333.002177:FATAL:web_contents_observer_sanity_checker.cc(317)] Check failed: is_loading_.
#0 0x0000f75f0fc9 base::debug::StackTrace::StackTrace()
#1 0x0000f7300b2e base::debug::StackTrace::StackTrace()
#2 0x0000f736e08e logging::LogMessage::~LogMessage()
#3 0x00000e634fbf content::WebContentsObserverSanityChecker::DidStopLoading()
#4 0x0000ee5b563f content::WebContentsImpl::LoadingStateChanged()
#5 0x0000ee5c5482 content::WebContentsImpl::DidStopLoading()
#6 0x0000ee5c556b content::WebContentsImpl::DidStopLoading()
#7 0x0000eda1618d content::FrameTreeNode::DidStopLoading()
#8 0x0000eda15d9e content::FrameTreeNode::~FrameTreeNode()
#9 0x0000eda1ce47 std::__1::__vector_base<>::~__vector_base()
#10 0x0000eda1b936 std::__1::vector<>::~vector()
#11 0x0000eda172f1 content::FrameTreeNode::ResetForNewProcess()
#12 0x0000edaab43f content::RenderFrameHostImpl::OnRenderProcessGone()
#13 0x0000edaf9756 _ZN4base20DispatchToMethodImplIPN7content19RenderFrameHostImplEMS2_FvN5blink18WebScrollDirectionENS4_20WebScrollGranularityEENSt3__15tupleIJS5_S6_EEEJLj0ELj1EEEEvRKT_T0_OT1_NS9_16integer_sequenceIjJXspT2_EEEE
#14 0x0000edaf9690 _ZN4base16DispatchToMethodIPN7content19RenderFrameHostImplEMS2_FvN5blink18WebScrollDirectionENS4_20WebScrollGranularityEENSt3__15tupleIJS5_S6_EEEEEvRKT_T0_OT1_
#15 0x0000edaf960f _ZN3IPC16DispatchToMethodIN7content19RenderFrameHostImplEMS2_FviiEvNSt3__15tupleIJiiEEEEEvPT_T0_PT1_OT2_
#16 0x0000edad8fa9 _ZN3IPC8MessageTI35FrameHostMsg_RenderProcessGone_MetaNSt3__15tupleIJiiEEEvE8DispatchIN7content19RenderFrameHostImplES8_vMS8_FviiEEEbPKNS_7MessageEPT_PT0_PT1_T2_
#17 0x0000edaa97da content::RenderFrameHostImpl::OnMessageReceived()
#18 0x0000ee180a62 content::RenderProcessHostImpl::ProcessDied()
#19 0x0000ee1801c7 content::RenderProcessHostImpl::FastShutdownIfPossible()
#20 0x000011375435 TabStripModel::CloseWebContentses()
#21 0x00001136ebb7 TabStripModel::InternalCloseTabs()
#22 0x00001136e86a TabStripModel::CloseAllTabs()
#23 0x0000112c25e9 Browser::OnWindowClosing()
#24 0x000011682fd4 BrowserView::CanClose()
#25 0x0000116830bb BrowserView::CanClose()
#26 0x0000f2e47c50 views::NonClientView::CanClose()
#27 0x0000f2e2fecf views::Widget::Close()
#28 0x000011676b52 BrowserView::Close()
#29 0x00000d99f6af BrowserCloseManager::CloseBrowsers()
#30 0x00000d99fc75 BrowserCloseManager::CheckForDownloadsInProgress()
#31 0x00000d99fab5 BrowserCloseManager::TryToCloseBrowsers()
#32 0x00000d99f0e2 BrowserCloseManager::StartClosingBrowsers()
#33 0x00000d53ed59 chrome::CloseAllBrowsers()
#34 0x00000d2e931e BrowserProcessPlatformPartBase::AttemptExit()
#35 0x00000d53ec5b chrome::AttemptExitInternal()
#36 0x00000d53f241 chrome::AttemptExit()
#37 0x0000087cd216 _ZN4base8internal13FunctorTraitsIPFvvEvE6InvokeIS3_JEEEvOT_DpOT0_
#38 0x0000087cd1dc _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIPFvvEJEEEvOT_DpOT0_
#39 0x00000884c523 _ZN4base8internal7InvokerINS0_9BindStateIPFvvEJEEES3_E7RunImplIRKS4_RKNSt3__15tupleIJEEEJEEEvOT_OT0_NSA_16integer_sequenceIjJXspT1_EEEE
#40 0x00000884c4da _ZN4base8internal7InvokerINS0_9BindStateIPFvvEJEEES3_E3RunEPNS0_13BindStateBaseE
#41 0x0000f72b56a7 _ZNO4base12OnceCallbackIFvvEE3RunEv
#42 0x0000f7302154 base::debug::TaskAnnotator::RunTask()
#43 0x0000f7392216 base::MessageLoop::RunTask()
#44 0x0000f7392538 base::MessageLoop::DeferOrRunPendingTask()
#45 0x0000f7392a38 base::MessageLoop::DoWork()
#46 0x0000f739c422 base::MessagePumpGlib::Run()
#47 0x0000f73918fb base::MessageLoop::Run()
#48 0x0000f7391951 base::MessageLoop::Run()
#49 0x0000f7439000 base::RunLoop::Run()
#50 0x00000d223143 InProcessBrowserTest::RunUntilBrowserProcessQuits()
#51 0x00000d225746 InProcessBrowserTest::QuitBrowsers()
#52 0x00000d2254aa InProcessBrowserTest::PostRunTestOnMainThread()
#53 0x00000e565235 content::BrowserTestBase::ProxyRunTestOnMainThreadLoop()
#54 0x000008526bf7 _ZN4base8internal13FunctorTraitsIM25RenderViewContextMenuBaseFvvEvE6InvokeIS4_P21RenderViewContextMenuJEEEvT_OT0_DpOT1_
#55 0x000008526b38 _ZN4base8internal12InvokeHelperILb0EvE8MakeItSoIM25RenderViewContextMenuBaseFvvEJP21RenderViewContextMenuEEEvOT_DpOT0_
#56 0x00000e567ac7 _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE7RunImplIRKS6_RKNSt3__15tupleIJS8_EEEJLj0EEEEvOT_OT0_NSF_16integer_sequenceIjJXspT1_EEEE
#57 0x00000e5679ca _ZN4base8internal7InvokerINS0_9BindStateIMN7content15BrowserTestBaseEFvvEJNS0_17UnretainedWrapperIS4_EEEEEFvvEE3RunEPNS0_13BindStateBaseE
#58 0x000008517281 _ZNKR4base17RepeatingCallbackIFvvEE3RunEv
#59 0x00000d384abb ChromeBrowserMainParts::PreMainMessageLoopRunImpl()
#60 0x00000d38249d ChromeBrowserMainParts::PreMainMessageLoopRun()
#61 0x0000ed529625 content::BrowserMainLoop::PreMainMessageLoopRun()
Project Member

Comment 18 by bugdroid1@chromium.org, Aug 20 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/527ee6525de281eef90887d441d675af4f635d3e

commit 527ee6525de281eef90887d441d675af4f635d3e
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Mon Aug 20 13:29:08 2018

[Linux][Flaky] Disable TabRestoreTest.RestoreWindowBounds on Linux only

This test is very flaky for quite a while now. For details, check the
linked bug.

TBR=ramyan@chromium.org, sky@chromium.org

Bug: 871010
Change-Id: I5d64a708f84d11a9b4981edc2cf53ad6b1a4151d
Reviewed-on: https://chromium-review.googlesource.com/1181048
Reviewed-by: Friedrich Horschig <fhorschig@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#584424}
[modify] https://crrev.com/527ee6525de281eef90887d441d675af4f635d3e/chrome/browser/sessions/tab_restore_browsertest.cc

Comment 19 by steve...@chromium.org, Dec 17

Blockedon: 466089
Project Member

Comment 20 by bugdroid1@chromium.org, Jan 11 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/51bdda57a8d838112c315e6b95e45b979f41fd6e

commit 51bdda57a8d838112c315e6b95e45b979f41fd6e
Author: James Cook <jamescook@chromium.org>
Date: Fri Jan 11 18:33:58 2019

Remove CHECK in WebContentsObserverSanityChecker::DidStopLoading

The check causes low-level browser_test flake across a wide variety of
test suites, usually due to check failures during test suite teardown.
This is test-only code, so relax the check until the root cause can be
investigated further.

Bug: 466089, 871010, 913006, 915360,  919347 
Test: browser_tests
Change-Id: Ife2ab6a6d260471f79873b6f0fd2914a4c7bb71d
Reviewed-on: https://chromium-review.googlesource.com/c/1403353
Reviewed-by: Camille Lamy <clamy@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#622067}
[modify] https://crrev.com/51bdda57a8d838112c315e6b95e45b979f41fd6e/content/test/web_contents_observer_sanity_checker.cc
Project Member

Comment 21 by bugdroid1@chromium.org, Jan 17 (5 days ago) 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a071d93e277ce9b1312c5333c1e9108e5c5fd270

commit a071d93e277ce9b1312c5333c1e9108e5c5fd270
Author: James Cook <jamescook@chromium.org>
Date: Thu Jan 17 17:15:40 2019

Enable tests that were CHECK failing in WebContentsObserverSanityChecker

There's an underlying issue with the is_loading_ cycle in WebContents.
I've removed the check while the root cause is under investigation.
Re-enable tests that were disabled because of this check:

ForceMaximizeOnFirstRunTest.PRE_TwoRuns
ForceMaximizeOnFirstRunTest.TwoRuns
TabRestoreTest.RestoreWindowBounds

Bug: 871010,  919100 , 466089
Test: browser_tests on linux and chromeos
Change-Id: Iaf20faf7f7329044df19aef7df55b50bd8ecaecd
Reviewed-on: https://chromium-review.googlesource.com/c/1409554
Reviewed-by: Scott Violet <sky@chromium.org>
Reviewed-by: Julian Pastarmov <pastarmovj@chromium.org>
Commit-Queue: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#623730}
[modify] https://crrev.com/a071d93e277ce9b1312c5333c1e9108e5c5fd270/chrome/browser/chromeos/policy/force_maximize_on_first_run_chromeos_browsertest.cc
[modify] https://crrev.com/a071d93e277ce9b1312c5333c1e9108e5c5fd270/chrome/browser/sessions/tab_restore_browsertest.cc
►

Sign in to add a comment