New issue
Advanced search Search tips

Issue 870945 link

Starred by 1 user

Issue metadata

Status: Duplicate
Merged: issue 871010
Owner: ----
Closed: Aug 6
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: TabRestoreTest.RestoreWindowBounds



Sign in to add a comment

TabRestoreTest.RestoreWindowBounds is Flaky

Project Member Reported by Findit, Aug 4

Issue description

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/94006a2aba37481e624cd8128908e3b303f28a52

commit 94006a2aba37481e624cd8128908e3b303f28a52
Author: Kunihiko Sakamoto <ksakamoto@chromium.org>
Date: Mon Aug 06 05:55:50 2018

Revert "[NTP] Adds an experiment for M69 NTP features."

This reverts commit 94558b662d9bf69b2e34bf2d198cad8de74776df.

Reason for revert: Findit thinks this made the following tests flaky:
TabRestoreTest.RestoreWindowBounds ( crbug.com/870945 )
BrowserNavigatorTest.Disposition_NewPopupFromAppPopup (crbug.com/871010)

Original change's description:
> [NTP] Adds an experiment for M69 NTP features.
> 
> Only the first experiment entry gets covered by perf waterfall, so adding
> this item ensures better test coverage. Also, the existing experiment,
> NewTabPageAllBirthday_Enabled, could not be re-used since
> go/revising-finch-configs recommends creating a new experiment when
> changing size or behavior of existing groups.
> 
> Bug: 831910
> Change-Id: I95ebc6f2768fe25d34993c05c71e35c22e2bdcc5
> Reviewed-on: https://chromium-review.googlesource.com/1160925
> Reviewed-by: Steven Holte <holte@chromium.org>
> Commit-Queue: Ramya Nagarajan <ramyan@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#580314}

TBR=holte@chromium.org,ramyan@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug: 831910, 870945 ,871010
Change-Id: Ifb86fbc322d939eba40f84b1ee32a21d76361f86
Reviewed-on: https://chromium-review.googlesource.com/1163361
Reviewed-by: Kunihiko Sakamoto <ksakamoto@chromium.org>
Commit-Queue: Kunihiko Sakamoto <ksakamoto@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580806}
[modify] https://crrev.com/94006a2aba37481e624cd8128908e3b303f28a52/testing/variations/fieldtrial_testing_config.json

Mergedinto: 871010
Status: Duplicate (was: Available)

Sign in to add a comment