Chrome OS Web UI Typography |
||||||||||
Issue descriptionOn Chrome OS version 70.0.03498.0 For textfields the font-weight of the label should be 10px,Medium (similar to browser Web UI) However, it is currently 10px, Regular. Similarly body text in Chrome OS dialogs looks lighter than browser WebUI
,
Aug 6
,
Aug 6
,
Aug 6
I think the "bold" looking screenshot might just be Mac's screen being different from other platforms. Comparing Linux and CrOS the texts look the same. Per offline discussion, the input labels were originally not Medium so we're gonna make it Medium and request for merge
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/79cb8be88bfbea78d3354c0ad01a7a12a1a0c483 commit 79cb8be88bfbea78d3354c0ad01a7a12a1a0c483 Author: Scott Chen <scottchen@chromium.org> Date: Tue Aug 07 01:45:30 2018 WebUI: fix cr-input label font weight Improves a11y (readability). Bug: 870937 Change-Id: Id07c24f7661af0139595b59b056cb5d5a2481894 Reviewed-on: https://chromium-review.googlesource.com/1164244 Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/heads/master@{#581089} [modify] https://crrev.com/79cb8be88bfbea78d3354c0ad01a7a12a1a0c483/ui/webui/resources/cr_elements/shared_vars_css.html
,
Aug 7
,
Aug 7
+cindyb@ (Chrome OS M69 TPM) for M69 merge review. Thank you.
,
Aug 7
Merge approved M69.
,
Aug 7
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0218708bf5381b1f13150b59498e64c45ad46e67 commit 0218708bf5381b1f13150b59498e64c45ad46e67 Author: Scott Chen <scottchen@chromium.org> Date: Tue Aug 07 20:03:35 2018 WebUI: fix cr-input label font weight Improves a11y (readability). Bug: 870937 Change-Id: Id07c24f7661af0139595b59b056cb5d5a2481894 Reviewed-on: https://chromium-review.googlesource.com/1164244 Reviewed-by: Esmael El-Moslimany <aee@chromium.org> Commit-Queue: Scott Chen <scottchen@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#581089}(cherry picked from commit 79cb8be88bfbea78d3354c0ad01a7a12a1a0c483) Reviewed-on: https://chromium-review.googlesource.com/1165903 Reviewed-by: Scott Chen <scottchen@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#472} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/0218708bf5381b1f13150b59498e64c45ad46e67/ui/webui/resources/cr_elements/shared_vars_css.html
,
Aug 7
,
Aug 14
+abdulsyed@ fyi, M69 merges taken for Proj-MdRefresh . |
||||||||||
►
Sign in to add a comment |
||||||||||
Comment 1 by markchang@chromium.org
, Aug 6