New issue
Advanced search Search tips

Issue 870922 link

Starred by 1 user
Status: Available
Owner: ----
Cc:
katie@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 2
Type: Bug
Team-Accessibility



Sign in to add a comment

STS button collapses other windows upon pressing button, unable to use on native UI

Project Member Reported by leberly@chromium.org, Aug 3 
Google Chrome	70.0.3511.0 (Official Build) canary (64-bit)
Firmware Version	Google_Eve.9584.160.0

Steps to repro:
# Enable Select To Speak in Settings > Manage Accessibility settings
# Open UI to be read such as the Status bar or launcher
# Invoke the STS button to enable feature
Expected: able to use feature on native UI
Actual: pressing button collapses all native UI

This means that you can't use STS on native UI in tablet mode.

Comment 1 by leberly@chromium.org, Aug 6

Labels: M68ExTest

Comment 3 by katie@chromium.org, Aug 13 

Some ideas (from afakhry):
Check: ChromeViewsDelegate::ProcessAcceleratorWhileMenuShowing().
There should be a call to AcceleratorController::ShouldCloseMenuAndRepostAccelerator() which checks if this accelerator should keep the menu open or not.MenuPreTargetHandler could pre-handle mouse events

Oshima may know more

Comment 4 by katie@chromium.org, Aug 15

Owner: katie@chromium.org
Status: Started (was: Available)
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 16 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ecdb6a3b7887523a80b75a0fa774533a7cb93ac7

commit ecdb6a3b7887523a80b75a0fa774533a7cb93ac7
Author: Katie D <katie@chromium.org>
Date: Thu Aug 16 16:59:08 2018

Tapping an Select-to-Speak tray icon cancels further event propagation.

This makes it possible to read content in menus with the Select-to-Speak
tray button, for example on tablet mode.

Bug: 870922
Change-Id: I3501625721c8d49a2ec422377a83b9f8f036b228
Reviewed-on: https://chromium-review.googlesource.com/1176181
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: James Cook <jamescook@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583694}
[modify] https://crrev.com/ecdb6a3b7887523a80b75a0fa774533a7cb93ac7/ash/BUILD.gn
[modify] https://crrev.com/ecdb6a3b7887523a80b75a0fa774533a7cb93ac7/ash/system/accessibility/select_to_speak_tray.cc
[modify] https://crrev.com/ecdb6a3b7887523a80b75a0fa774533a7cb93ac7/ash/system/accessibility/select_to_speak_tray.h
[add] https://crrev.com/ecdb6a3b7887523a80b75a0fa774533a7cb93ac7/ash/system/accessibility/select_to_speak_tray_utils.cc
[add] https://crrev.com/ecdb6a3b7887523a80b75a0fa774533a7cb93ac7/ash/system/accessibility/select_to_speak_tray_utils.h
[modify] https://crrev.com/ecdb6a3b7887523a80b75a0fa774533a7cb93ac7/chrome/browser/chromeos/accessibility/DEPS
[modify] https://crrev.com/ecdb6a3b7887523a80b75a0fa774533a7cb93ac7/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc
[modify] https://crrev.com/ecdb6a3b7887523a80b75a0fa774533a7cb93ac7/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.h

Comment 6 by katie@chromium.org, Aug 16

Labels: a11y-testers
Status: Fixed (was: Started)
Project Member

Comment 7 by bugdroid1@chromium.org, Aug 24 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d23ef8c44c09c587650beef05184a69ee1b48bb2

commit d23ef8c44c09c587650beef05184a69ee1b48bb2
Author: Katie D <katie@chromium.org>
Date: Fri Aug 24 05:07:33 2018

Revert "Tapping an Select-to-Speak tray icon cancels further event propagation."

This reverts commit ecdb6a3b7887523a80b75a0fa774533a7cb93ac7.

Reason for revert:
This is causing a weird behavior where if you mouse-down on the button and
then hold and drag way, select-to-speak is activated anyway. Select-to-Speak
can also be activated from behind the on-screen keyboard.

TBR=jamescook@chromium.org,dtseng@chromium.org

Bug: 870922
Change-Id: Ib9b7395e3a66c491a6c3274dd93898b4e064dd4d
Reviewed-on: https://chromium-review.googlesource.com/1187728
Commit-Queue: Katie Dektar <katie@chromium.org>
Reviewed-by: Katie Dektar <katie@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585684}
[modify] https://crrev.com/d23ef8c44c09c587650beef05184a69ee1b48bb2/ash/BUILD.gn
[modify] https://crrev.com/d23ef8c44c09c587650beef05184a69ee1b48bb2/ash/system/accessibility/select_to_speak_tray.cc
[modify] https://crrev.com/d23ef8c44c09c587650beef05184a69ee1b48bb2/ash/system/accessibility/select_to_speak_tray.h
[delete] https://crrev.com/5a19eb524012d2eb81339eeac2b4e5fe2bf45c2b/ash/system/accessibility/select_to_speak_tray_utils.cc
[delete] https://crrev.com/5a19eb524012d2eb81339eeac2b4e5fe2bf45c2b/ash/system/accessibility/select_to_speak_tray_utils.h
[modify] https://crrev.com/d23ef8c44c09c587650beef05184a69ee1b48bb2/chrome/browser/chromeos/accessibility/DEPS
[modify] https://crrev.com/d23ef8c44c09c587650beef05184a69ee1b48bb2/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.cc
[modify] https://crrev.com/d23ef8c44c09c587650beef05184a69ee1b48bb2/chrome/browser/chromeos/accessibility/select_to_speak_event_handler.h

Comment 8 by katie@chromium.org, Aug 24

Cc: katie@chromium.org
Owner: ----
Status: Available (was: Fixed)
There were some problems with the initial solution:
* it activated behind the on-screen keyboard
* clicking down on the button but dragging away from it still activated STS

Comment 9 by leberly@chromium.org, Sep 21

Labels: -a11y-testers
Google Chrome	71.0.3554.0 (Official Build) dev (64-bit)
Firmware Version	Google_Caroline.7820.384.0

I can see that this was reverted, ok. When you're ready for verification, please just add the a11y-testers label back on. Thanks!
►

Sign in to add a comment