New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870895 link

Starred by 1 user

Issue metadata

Status: Started
Owner:
Last visit > 30 days ago
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: Bug



Sign in to add a comment

Implement Live Page Sharing

Project Member Reported by romax@chromium.org, Aug 3

Issue description

Implement live page sharing which saves the current loaded live page and share it after saving completes.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/36b4b5b0612e49e56a018bbe0aeb911db181b0c3

commit 36b4b5b0612e49e56a018bbe0aeb911db181b0c3
Author: Yafei Duan <romax@chromium.org>
Date: Tue Aug 07 00:40:03 2018

[Offline Pages] Adding flag for live page sharing.

Adding flag for live page sharing of Offline Pages.

Bug: 870895
Change-Id: Id34ae2ebcc1c83e736505f69a9d78055d3aec94e
Reviewed-on: https://chromium-review.googlesource.com/1162824
Commit-Queue: Yafei Duan <romax@chromium.org>
Reviewed-by: Dmitry Titov <dimich@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581057}
[modify] https://crrev.com/36b4b5b0612e49e56a018bbe0aeb911db181b0c3/chrome/android/java/src/org/chromium/chrome/browser/ChromeFeatureList.java
[modify] https://crrev.com/36b4b5b0612e49e56a018bbe0aeb911db181b0c3/chrome/browser/about_flags.cc
[modify] https://crrev.com/36b4b5b0612e49e56a018bbe0aeb911db181b0c3/chrome/browser/android/chrome_feature_list.cc
[modify] https://crrev.com/36b4b5b0612e49e56a018bbe0aeb911db181b0c3/chrome/browser/flag_descriptions.cc
[modify] https://crrev.com/36b4b5b0612e49e56a018bbe0aeb911db181b0c3/chrome/browser/flag_descriptions.h
[modify] https://crrev.com/36b4b5b0612e49e56a018bbe0aeb911db181b0c3/components/offline_pages/core/offline_page_feature.cc
[modify] https://crrev.com/36b4b5b0612e49e56a018bbe0aeb911db181b0c3/components/offline_pages/core/offline_page_feature.h
[modify] https://crrev.com/36b4b5b0612e49e56a018bbe0aeb911db181b0c3/components/offline_pages/core/offline_page_feature_unittest.cc
[modify] https://crrev.com/36b4b5b0612e49e56a018bbe0aeb911db181b0c3/tools/metrics/histograms/enums.xml

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 11

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/514ffca0bacb2fce140defae3a4ae3dcab37bfa0

commit 514ffca0bacb2fce140defae3a4ae3dcab37bfa0
Author: Yafei Duan <romax@chromium.org>
Date: Sat Aug 11 01:45:19 2018

[Offline Pages] Implement live page sharing.

Implement live page sharing:
- Adding a new temporary client namespace for the usage of live page
  sharing, which has a limit of one page per url and expiration period
  as one hour.
- Adding saveAndSharePage in OfflinePageUtils, implementing the workflow
  of save page, get page and share page.

Bug: 870895
Change-Id: Iab5f074dfa955ba30f8b125a70cedb87e8610246
Reviewed-on: https://chromium-review.googlesource.com/1162827
Reviewed-by: Peter Williamson <petewil@chromium.org>
Reviewed-by: Theresa <twellington@chromium.org>
Commit-Queue: Yafei Duan <romax@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582418}
[add] https://crrev.com/514ffca0bacb2fce140defae3a4ae3dcab37bfa0/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/GetPagesByNamespaceForLivePageSharingCallback.java
[modify] https://crrev.com/514ffca0bacb2fce140defae3a4ae3dcab37bfa0/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageBridge.java
[modify] https://crrev.com/514ffca0bacb2fce140defae3a4ae3dcab37bfa0/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/OfflinePageUtils.java
[add] https://crrev.com/514ffca0bacb2fce140defae3a4ae3dcab37bfa0/chrome/android/java/src/org/chromium/chrome/browser/offlinepages/SavePageAndShareCallback.java
[modify] https://crrev.com/514ffca0bacb2fce140defae3a4ae3dcab37bfa0/chrome/android/java/src/org/chromium/chrome/browser/share/ShareMenuActionHandler.java
[modify] https://crrev.com/514ffca0bacb2fce140defae3a4ae3dcab37bfa0/chrome/android/java_sources.gni
[modify] https://crrev.com/514ffca0bacb2fce140defae3a4ae3dcab37bfa0/components/offline_pages/core/client_namespace_constants.cc
[modify] https://crrev.com/514ffca0bacb2fce140defae3a4ae3dcab37bfa0/components/offline_pages/core/client_namespace_constants.h
[modify] https://crrev.com/514ffca0bacb2fce140defae3a4ae3dcab37bfa0/components/offline_pages/core/client_policy_controller.cc
[modify] https://crrev.com/514ffca0bacb2fce140defae3a4ae3dcab37bfa0/components/offline_pages/core/client_policy_controller_unittest.cc
[modify] https://crrev.com/514ffca0bacb2fce140defae3a4ae3dcab37bfa0/components/offline_pages/core/model/offline_page_model_utils.cc
[modify] https://crrev.com/514ffca0bacb2fce140defae3a4ae3dcab37bfa0/tools/metrics/histograms/enums.xml

Sign in to add a comment