New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870894 link

Starred by 1 user

Issue metadata

Status: WontFix
Owner:
Closed: Aug 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug

Blocking:
issue 837855



Sign in to add a comment

Correctly handle flaky step that has a matching "without patch" step

Project Member Reported by liaoyuke@chromium.org, Aug 3

Issue description

The query that is used to detect flaky tests on CQ has a bug: https://cs.chromium.org/chromium/infra/appengine/findit/services/flake_detection/flaky_tests.cq_false_rejection.sql?l=301.

The bug is that it assumes all the failed tests in a flaky build are flaky tests, however, this is not necessarily true. For example, in the following scenario:

base_unittests (with patch) failed with t1 and t2, and base_unittests (without patch) failed with t1. In this case, base_unittests (with patch) is deemed as a flaky build because the matching "retry summary" step is red, which is correct, however, t1 shouldn't be considered as a flaky test because it also failed in base_unittests (without patch).

This bug may cause false positives that labels consistent failures as a flaky test, and the correctly solution is to filter out failed tests that also failed in the "without patch" step.
 
stgao@, can you double-check in case I missed something?
Status: WontFix (was: Assigned)
Nice! Thanks for catching it, I missed those lines.

Sign in to add a comment