Picture-in-Picture: changing video source during playback sometimes lead to broken state |
|||||||
Issue descriptionWhat steps will reproduce the problem? 1. Open https://www.w3.org/2010/05/video/mediaevents.html 2. Play video 3. Send to PIP 4. Click on "Bunny Trailer" button on the right side 5. Video pauses 6. Click "Play" in the PIP window What is the expected result? - video plays What happens instead of that? - video does not play ond PIP window state changes to playing Other steps that probably are related: 1. Open https://www.w3.org/2010/05/video/mediaevents.html 2. Play video 3. Send to PIP 4. Click on "Bunny Trailer" button on the right side 5. Close PIP window What is the expected result? - video no longer is in the Picture-in-Picture state What happens instead of that? - video appears in the Picture-in-Picture state
,
Aug 7
I have a fix for this.
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/e8bd6854356ed7da696b0877e62e0b5fd3ee5540 commit e8bd6854356ed7da696b0877e62e0b5fd3ee5540 Author: Mounir Lamouri <mlamouri@chromium.org> Date: Thu Aug 09 03:49:22 2018 Picture-in-Picture: update status when new player is loaded for a video in PIP. Bug: 870853 Change-Id: Ib1621a1016d226f03d10a745dfb35a2c9cfe5dec Reviewed-on: https://chromium-review.googlesource.com/1166337 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Cr-Commit-Position: refs/heads/master@{#581778} [modify] https://crrev.com/e8bd6854356ed7da696b0877e62e0b5fd3ee5540/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [add] https://crrev.com/e8bd6854356ed7da696b0877e62e0b5fd3ee5540/chrome/test/data/media/picture-in-picture/player_preload_none.html [modify] https://crrev.com/e8bd6854356ed7da696b0877e62e0b5fd3ee5540/content/browser/media/media_web_contents_observer.cc [modify] https://crrev.com/e8bd6854356ed7da696b0877e62e0b5fd3ee5540/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc [modify] https://crrev.com/e8bd6854356ed7da696b0877e62e0b5fd3ee5540/media/blink/webmediaplayer_impl.cc
,
Aug 10
Tested on Canary. Asking for M69 merge. The feature is behind a Finch flag and it should have no impact outside of the feature itself.
,
Aug 10
This bug requires manual review: M69 has already been promoted to the beta branch, so this requires manual review Please contact the milestone owner if you have questions. Owners: amineer@(Android), kariahda@(iOS), cindyb@(ChromeOS), govind@(Desktop) For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 10
Approving merge to M69 branch 3497 based on comment #4, pls merge before 4:00 PM PT Monday (08/13). Thank you.
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/bc5b1491887c7453f1d43bf10812af358f58e09d commit bc5b1491887c7453f1d43bf10812af358f58e09d Author: Mounir Lamouri <mlamouri@chromium.org> Date: Fri Aug 10 19:09:25 2018 Picture-in-Picture: update status when new player is loaded for a video in PIP. Bug: 870853 Change-Id: Ib1621a1016d226f03d10a745dfb35a2c9cfe5dec Reviewed-on: https://chromium-review.googlesource.com/1166337 Commit-Queue: Mounir Lamouri <mlamouri@chromium.org> Reviewed-by: Frank Liberato <liberato@chromium.org> Reviewed-by: apacible <apacible@chromium.org> Cr-Original-Commit-Position: refs/heads/master@{#581778}(cherry picked from commit e8bd6854356ed7da696b0877e62e0b5fd3ee5540) Reviewed-on: https://chromium-review.googlesource.com/1171423 Reviewed-by: Mounir Lamouri <mlamouri@chromium.org> Cr-Commit-Position: refs/branch-heads/3497@{#543} Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753} [modify] https://crrev.com/bc5b1491887c7453f1d43bf10812af358f58e09d/chrome/browser/picture_in_picture/picture_in_picture_window_controller_browsertest.cc [add] https://crrev.com/bc5b1491887c7453f1d43bf10812af358f58e09d/chrome/test/data/media/picture-in-picture/player_preload_none.html [modify] https://crrev.com/bc5b1491887c7453f1d43bf10812af358f58e09d/content/browser/media/media_web_contents_observer.cc [modify] https://crrev.com/bc5b1491887c7453f1d43bf10812af358f58e09d/content/browser/picture_in_picture/picture_in_picture_window_controller_impl.cc [modify] https://crrev.com/bc5b1491887c7453f1d43bf10812af358f58e09d/media/blink/webmediaplayer_impl.cc
,
Aug 10
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by mlamouri@chromium.org
, Aug 3