New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870847 link

Starred by 1 user

Issue metadata

Status: Closed
Owner:
Last visit > 30 days ago
Closed: Aug 22
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug



Sign in to add a comment

Setting label fontlist and lineheight

Project Member Reported by oxyflush@chromium.org, Aug 3

Issue description

I've noticed numerous cases in the code where people have had to call SetFontList() followed by SetLineHeight(), including the file I am currently working in (SearchResultTileItemView). 

Would be beneficial/a good idea to make a method in label that does both?


 
Cc: oxyflush@google.com
Owner: oxyflush@chromium.org
I haven't looked for instances of this, but offhand, I don't think that really makes sense. The line height should be adjusted automatically for the font list. If the automatic adjustment isn't giving the right value, we should fix that.

I'm not actively work on RenderText now, but I'll help advise/review. Please triage this yourself.
Cc: -oxyflush@google.com
Need some clarification: Do you mean that the line height should be adjusted automatically whenever a font list is set?
Status: Closed (was: Untriaged)

Sign in to add a comment