New issue
Advanced search Search tips

Issue 870844 link

Starred by 4 users

Issue metadata

Status: Fixed
Owner:
Closed: Aug 8
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Cocoa high contrast mode inactive tabs broken in M69

Reported by pe...@schussheim.com, Aug 3

Issue description

UserAgent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10_13_6) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3511.0 Safari/537.36

Steps to reproduce the problem:
1. open a few tabs in Canary 
2. 
3. 

What is the expected behavior?

What went wrong?
Starting approximately two weeks ago, the tab bar changed the colors of its elements.  Aside from no option to configure this, it makes it incredibly difficult to read the titles of inactive (unfocused) tabs.

Did this work before? Yes 

Chrome version: 70.0.3511.0  Channel: canary
OS Version: OS X 10.13.6
Flash Version:
 
Accessibility Inspector001.png
157 KB View Download
Accessibility Inspector002.png
25.3 KB View Download
chrome-good.png
14.1 KB View Download
Note: image titled "chrome-good.png" is an example from Chrome stable and is what i'd expect to see as a default color scheme in canary.
Cc: ellyjo...@chromium.org
Labels: Proj-MacViews
Thanks for the report. I can reproduce it with the MacViews Theme. But the MacViews Theme will be replaced by the MdRefresh Theme.

I'm wondering, because I thought the MdRefresh Theme is on by default in Canary?

Do you have any flags active to disable the new Theme?
Status: Untriaged (was: Unconfirmed)
+screenshots
MacViewsTheme.png
42.4 KB View Download
MdRefreshTheme.png
43.1 KB View Download
Hi,

thanks for this information.  I can enable MdRefresh by setting the 'upcoming-ui' flag,  otherwise canary appears to be using MacViews by default.


Cc: -ellyjo...@chromium.org robliao@chromium.org
Labels: Target-70 M-70
Owner: ellyjo...@chromium.org
Status: Assigned (was: Untriaged)
Summary: MD refresh should be on by default on trunk (was: Dark tab bar color scheme makes inactive tab titles unreadable)
Huh, that's a good point. I made views-browser-windows on by default; I should probably also make md-refresh on by default.
Labels: -Target-70 -M-70 Target-69 M-69
Summary: Cocoa high contrast mode inactive tabs broken in M69 (was: MD refresh should be on by default on trunk)
Okay, I took a peek at the state of the flags.

The default behavior of canary is MacViews enabled + MD Refresh enabled. The screenshot mehmet posted in #3 is MacViews enabled + MD Refresh disabled. The screenshot in the OP is MacViews disabled - the bold text on the tab title is a giveaway since I never implemented title bolding in MacViews.

So, the actual summary of this bug is that the Cocoa browser accessibility is screwed up in high contrast mode in M69. I'll fix and merge :(
Project Member

Comment 8 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/188f2595a21350b8b1e3a194bf417fbdb47fdaf9

commit 188f2595a21350b8b1e3a194bf417fbdb47fdaf9
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Tue Aug 07 22:14:07 2018

themes: constrain IncreasedContrastThemeSupplier to refresh-only

The inverted background tab design doesn't work at all with pre-Refresh tabs.

Bug:  870844 
Change-Id: I598b92ed8d6e8fa8b586166fb7352df1d13c8360
Reviewed-on: https://chromium-review.googlesource.com/1163316
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581361}
[modify] https://crrev.com/188f2595a21350b8b1e3a194bf417fbdb47fdaf9/chrome/browser/themes/theme_service.cc

Labels: Merge-Request-69
This does need an M69 merge - an accessibility mode is basically broken. :(
Is the change listed at #8 looking good in canary?
#10: Yes, it looks good in 70.0.3516.0.
Labels: -Merge-Request-69 Merge-Approved-69
Approving merge to M69 branch 3497 based on comment #9 and #11. 
Status: Fixed (was: Started)
https://chromium-review.googlesource.com/c/chromium/src/+/1167402 merge complete
Project Member

Comment 14 by bugdroid1@chromium.org, Aug 8

Labels: -merge-approved-69 merge-merged-3497
The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bb3359ed70292688fbdafdeb93fcd7c6be011f26

commit bb3359ed70292688fbdafdeb93fcd7c6be011f26
Author: Elly Fong-Jones <ellyjones@chromium.org>
Date: Wed Aug 08 15:01:28 2018

themes: constrain IncreasedContrastThemeSupplier to refresh-only

The inverted background tab design doesn't work at all with pre-Refresh tabs.

Bug:  870844 
Change-Id: I598b92ed8d6e8fa8b586166fb7352df1d13c8360
Reviewed-on: https://chromium-review.googlesource.com/1163316
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#581361}(cherry picked from commit 188f2595a21350b8b1e3a194bf417fbdb47fdaf9)
Reviewed-on: https://chromium-review.googlesource.com/1167402
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Cr-Commit-Position: refs/branch-heads/3497@{#493}
Cr-Branched-From: 271eaf50594eb818c9295dc78d364aea18c82ea8-refs/heads/master@{#576753}
[modify] https://crrev.com/bb3359ed70292688fbdafdeb93fcd7c6be011f26/chrome/browser/themes/theme_service.cc

Verified the fix on Chrome version 69.0.3497.32 using below steps(Thank you Elly)


Steps followed :
1. Install Chrome 69.0.3497.32 or later.
2. Navigate to Mac System Preferences --> Accessibility --> Display --> Check [Increase  Contrast]
3. Navigate to Chrome://flags and make sure to "disable the views-browser-windows and upcoming-ui-features flag's" if they are enabled.
4. Open couple of tabs and webpages.


Observed behavior :
Both Active and Non-Active Tab titles Should be black(Before the fix non active tabs titles were white).

Sign in to add a comment