New issue
Advanced search Search tips

Issue 870843 link

Starred by 1 user
Status: Fixed
Owner:
tedc...@chromium.org
Closed: Aug 7
Cc:
klo...@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Android
Pri: 2
Type: ----



Sign in to add a comment

Share menu option missing from CustomTabs launched by Webapks

Project Member Reported by tedc...@chromium.org, Aug 3 
The share menu option is not enabled by default:
https://chromium.googlesource.com/chromium/src/+/ec30509da1c2ee90874cd16b131136398844f182/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java#230

For custom tabs launched by Chrome (that aren't special cases like payments), we should show share IMO.
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 7 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/879dbe10cf00373d52c045a426d7e8dc1d044930

commit 879dbe10cf00373d52c045a426d7e8dc1d044930
Author: Ted Choc <tedchoc@google.com>
Date: Tue Aug 07 17:27:25 2018

Enable share by default for Chrome opened CCTs.

BUG= 870843 

Change-Id: I1ae9d16a9238fd5f669ab487eeed02f45068ba92
Reviewed-on: https://chromium-review.googlesource.com/1162708
Commit-Queue: Ted Choc <tedchoc@chromium.org>
Reviewed-by: Peter Conn <peconn@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581269}
[modify] https://crrev.com/879dbe10cf00373d52c045a426d7e8dc1d044930/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabIntentDataProvider.java

Comment 2 by tedc...@chromium.org, Aug 7

Status: Fixed (was: Started)
►

Sign in to add a comment