New issue
Advanced search Search tips

Issue 870841 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: iOS
Pri: 2
Type: Bug



Sign in to add a comment

Clean up chevron transform rotations

Project Member Reported by sczs@chromium.org, Aug 3

Issue description

Due to  crbug.com/869142  we are currently manually rotating the chevron accessory views. This needs to be clean up and preferably use the default accessory type or create a utility function if it stays this way.
 
Cc: martijnb@chromium.org
Labels: Proj-UIRefresh
Leaving as P2 since this is a refactoring task and is currently working.

+Martijn: Would it be OK to use the default iOS chevrons for Cells? You can check  crbug.com/869142  for context
For any cell in Bijou? 

I think the most important thing is that we use the same chevron style in both LTR and RTL. If that means having to use the iOS chevron in both situations, that be would be fine to me. 
Yes, for any cell in Bijou.

We currently have the same custom chevron style for both LTR and RTL, but we're handling the rotation ourselves. 
Rohit thought it could be worth exploring the option of just using the custom chevron since we get all of that for free. 
If you think keeping the custom chevron is important, we can leave it as is (probably refactor the code a little bit to share the rotation functionality)
I see. 

Is it true that we are also using the default chevrons for accordions (sticky headers in Recents)? 

It seems like we are. In that case I'd be happy using the default chevrons everywhere, since it will also improve consistency. 

The sticky headers in Recent Tabs are using the custom chevrons right now.
So currently we have consistency everywhere, but we're handling the "right/horizontal" chevron rotation manually.

We do need a custom chevron for Recent Tabs sticky headers, or make a custom that looks just like the ios default.

We can also just leave it as is if we want to keep consistency with horizontal/vertical chevrons and use the custom one.
Cc: -martijnb@chromium.org sczs@chromium.org
Labels: Needs-Feedback
Owner: martijnb@chromium.org

Sign in to add a comment