Clean up chevron transform rotations |
||
Issue descriptionDue to crbug.com/869142 we are currently manually rotating the chevron accessory views. This needs to be clean up and preferably use the default accessory type or create a utility function if it stays this way.
,
Aug 10
For any cell in Bijou? I think the most important thing is that we use the same chevron style in both LTR and RTL. If that means having to use the iOS chevron in both situations, that be would be fine to me.
,
Aug 10
Yes, for any cell in Bijou. We currently have the same custom chevron style for both LTR and RTL, but we're handling the rotation ourselves. Rohit thought it could be worth exploring the option of just using the custom chevron since we get all of that for free. If you think keeping the custom chevron is important, we can leave it as is (probably refactor the code a little bit to share the rotation functionality)
,
Aug 14
I see. Is it true that we are also using the default chevrons for accordions (sticky headers in Recents)? It seems like we are. In that case I'd be happy using the default chevrons everywhere, since it will also improve consistency.
,
Aug 14
The sticky headers in Recent Tabs are using the custom chevrons right now. So currently we have consistency everywhere, but we're handling the "right/horizontal" chevron rotation manually. We do need a custom chevron for Recent Tabs sticky headers, or make a custom that looks just like the ios default. We can also just leave it as is if we want to keep consistency with horizontal/vertical chevrons and use the custom one.
,
Sep 28
,
Dec 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/40c7ab374ac8af68f922376ded00ad3cca212df7 commit 40c7ab374ac8af68f922376ded00ad3cca212df7 Author: Yi Su <mrsuyi@chromium.org> Date: Fri Dec 21 15:44:00 2018 Fix TableViewImageItem for accessibility font size. TableViewImageItem's Autolayout constraints are not well-defined for accessibility font size. This CL fixes it, and removes unused chevron view. Bug: 891283 ,870841 Change-Id: Ia27bb25d158163a405dbb888050558fbd95dbb00 Reviewed-on: https://chromium-review.googlesource.com/c/1386784 Commit-Queue: Yi Su <mrsuyi@chromium.org> Reviewed-by: Sergio Collazos <sczs@chromium.org> Cr-Commit-Position: refs/heads/master@{#618535} [modify] https://crrev.com/40c7ab374ac8af68f922376ded00ad3cca212df7/ios/chrome/browser/ui/recent_tabs/recent_tabs_table_view_controller.mm [modify] https://crrev.com/40c7ab374ac8af68f922376ded00ad3cca212df7/ios/chrome/browser/ui/settings/table_cell_catalog_view_controller.mm [modify] https://crrev.com/40c7ab374ac8af68f922376ded00ad3cca212df7/ios/chrome/browser/ui/table_view/cells/table_view_image_item.h [modify] https://crrev.com/40c7ab374ac8af68f922376ded00ad3cca212df7/ios/chrome/browser/ui/table_view/cells/table_view_image_item.mm [modify] https://crrev.com/40c7ab374ac8af68f922376ded00ad3cca212df7/ios/chrome/browser/ui/table_view/cells/table_view_image_item_unittest.mm |
||
►
Sign in to add a comment |
||
Comment 1 by sczs@chromium.org
, Aug 7Labels: Proj-UIRefresh