New issue
Advanced search Search tips

Issue 870811 link

Starred by 1 user
Status: Fixed
Owner:
r...@igalia.com
Closed: Sep 14
Cc:
robertma@chromium.org
e...@chromium.org
style-bugs@google.com
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: ----
Type: ----



Sign in to add a comment

[WPT] New failures introduced in external/wpt/css by import https://crrev.com/c/1162273

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Aug 3 
WPT import https://crrev.com/c/1162273 introduced new failures in external/wpt/css:

List of new failures:
external/wpt/css/css-contain/contain-paint-021.html [ Failure ]
external/wpt/css/css-contain/contain-paint-001.html [ Failure ]
external/wpt/css/css-contain/contain-layout-016.html [ Failure ]

This import contains upstream changes from e6422d28a641dcb82a419c1f63efb975588960cf to 79f585c4b5c1391a62e94b87bfb5f89719e82e99:
Merge pull request #12269 from mrego/css-contain-stacking-context: https://github.com/web-platform-tests/wpt/commit/79f585c4b5c1391a62e94b87bfb5f89719e82e99
Parametrize capabilities tests.: https://github.com/web-platform-tests/wpt/commit/d0018e6667d7f81d7a47fa19cfb3dbffc7c08a7c
Move timeouts test to separate file.: https://github.com/web-platform-tests/wpt/commit/c1c2431945fbcdcb28a42f78f2dd74d7e8bb2ce1
Move platformName test to separate file.: https://github.com/web-platform-tests/wpt/commit/698c9024050d90f0d251b6b1f786e8728bf803dd
Merge pull request #12270 from mrego/css-contain-fixes: https://github.com/web-platform-tests/wpt/commit/391abef11d9f9849d973360f9de82eaeac61153b
[workers] Detect errors to avoid timeouts: https://github.com/web-platform-tests/wpt/commit/f6a31bd95542385975678941578b2460766d32ed
[css-contain] Apply different changes to improve tests: https://github.com/web-platform-tests/wpt/commit/e3910484923005af20116ac2458aa9ed9881cb41 [affecting this directory]
Compress wpt_report.json on Taskcluster: https://github.com/web-platform-tests/wpt/commit/aca56865f3f8d5ceed64582fa45b87bfa2bf6874
MarionetteTestharnessExecutor sets a timeout of 0 when running with a debugger: https://github.com/web-platform-tests/wpt/commit/dc7bc57b1e9ac0f9cecb6568ad9d074601cf6f56
[wdspec] Add tests for no browsing context.: https://github.com/web-platform-tests/wpt/commit/19444c98d1c673d0e61f6ec495b5708b5f7d0b6b
[css-contain] Containment and stacking contexts: https://github.com/web-platform-tests/wpt/commit/d5d196cb8c34a05276e51c5e32c39747bf64c9fb [affecting this directory]

Comment 1 by r...@igalia.com, Aug 6

Cc: e...@chromium.org
Owner: r...@igalia.com
Status: Assigned (was: Untriaged)
I'm linking the failures to the proper bugs in:
https://chromium-review.googlesource.com/c/chromium/src/+/1163673

Apart from that external/wpt/css/css-contain/contain-paint-001.html
failure is due to a mistake in a change in WPT by myself
(I forgot to update the reference file).
That has been fixed in https://github.com/web-platform-tests/wpt/pull/12314
so I guess this will re-start passing in the next import.

Maybe we can keep this open until that happens and confirms that everything is right.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 6 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbc976dff2f1d80d5244de1efa91c4fdd5815066

commit dbc976dff2f1d80d5244de1efa91c4fdd5815066
Author: Manuel Rego Casasnovas <rego@igalia.com>
Date: Mon Aug 06 15:29:29 2018

[css-contain] Link failures in WPT tests to the related bugs

Two of the failures are related to stacking contexts:
* external/wpt/css/css-contain/contain-paint-021.html
* external/wpt/css/css-contain/contain-layout-016.html

The other one was a mistake that has been already fixed in WPT
(see https://github.com/web-platform-tests/wpt/pull/12314):
* external/wpt/css/css-contain/contain-paint-001.html

TBR=eae@chromium.org

BUG= 870811 , 868102 , 870157 

Change-Id: I60e89decd2f939d1d9a850a1b8b556d31658e872
Reviewed-on: https://chromium-review.googlesource.com/1163673
Reviewed-by: Manuel Rego <rego@igalia.com>
Commit-Queue: Manuel Rego <rego@igalia.com>
Cr-Commit-Position: refs/heads/master@{#580878}
[modify] https://crrev.com/dbc976dff2f1d80d5244de1efa91c4fdd5815066/third_party/WebKit/LayoutTests/TestExpectations

Comment 3 by r...@igalia.com, Sep 14

Status: Fixed (was: Assigned)
These issues have been all fixed.
►

Sign in to add a comment