We should get this data as soon as posslble to ensure we are able to evaluate upcoming changes to the LevelDB infrastructure, so setting target to M-69.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c67cfe86a16a2c174ab32af869e3b434ccc93400

commit c67cfe86a16a2c174ab32af869e3b434ccc93400
Author: Troy Hildebrandt <thildebr@chromium.org>
Date: Mon Aug 13 18:14:40 2018

Add and record a histogram for LevelDB memory use after init.

Adds LevelDB.ApproximateMemoryUse.<clientname> histograms for memory
use after initialization. This should give us the size of the MemTable
right after initialization.

BUG= 870806 ,870813

Change-Id: I2c6ea6f176e92c319718ed29b6fb9192792bf7f1
Reviewed-on: https://chromium-review.googlesource.com/1162357
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Reviewed-by: Mark Pearson <mpearson@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582641}
[modify] https://crrev.com/c67cfe86a16a2c174ab32af869e3b434ccc93400/components/leveldb_proto/leveldb_database.cc
[modify] https://crrev.com/c67cfe86a16a2c174ab32af869e3b434ccc93400/components/leveldb_proto/leveldb_database.h
[modify] https://crrev.com/c67cfe86a16a2c174ab32af869e3b434ccc93400/tools/metrics/histograms/histograms.xml

I think that when this has gone through a day of canary, we should ask for a merge to M69. You might want to give the TPM a heads up though.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/f802f9338c8a1c8dd115db21feae55eec77be553

commit f802f9338c8a1c8dd115db21feae55eec77be553
Author: Troy Hildebrandt <thildebr@chromium.org>
Date: Mon Sep 17 18:12:19 2018

Fix LevelDB approximate memory use histogram calculation.

Subtracts the share block cache charge from the approximate memory use
we receive from the LevelDB.

Bug:  870806 ,870813
Change-Id: I90f22d6ad9c7acc29746618bde77386ab3741e17
Reviewed-on: https://chromium-review.googlesource.com/1180271
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591740}
[modify] https://crrev.com/f802f9338c8a1c8dd115db21feae55eec77be553/components/leveldb_proto/leveldb_database.cc
[modify] https://crrev.com/f802f9338c8a1c8dd115db21feae55eec77be553/components/leveldb_proto/leveldb_database.h
[modify] https://crrev.com/f802f9338c8a1c8dd115db21feae55eec77be553/tools/metrics/histograms/histograms.xml

Requesting a merge for the CL in #5.

Confirmed it's collecting good data in dev/canary for the last few days with no issues, very small change that just makes the approximate memory histogram more meaningful, and is very low risk.

Interest in this being merged has also been expressed by ssid@ to potentially help track down a memory regression.

This bug requires manual review: M70 has already been promoted to the beta branch, so this requires manual review
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Please mark which OS's this is impacting. 

The issue I'm trying to track using the UMA is issue 887068, mentioned in comment #6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/382c65b67da8ef30805792f74aa9f82d5acacbd2

commit 382c65b67da8ef30805792f74aa9f82d5acacbd2
Author: Troy Hildebrandt <thildebr@chromium.org>
Date: Mon Sep 24 17:34:27 2018

Fix LevelDB approximate memory use histogram calculation.

Subtracts the share block cache charge from the approximate memory use
we receive from the LevelDB.

Bug:  870806 ,870813
Change-Id: I90f22d6ad9c7acc29746618bde77386ab3741e17
Reviewed-on: https://chromium-review.googlesource.com/1180271
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591740}(cherry picked from commit f802f9338c8a1c8dd115db21feae55eec77be553)
Reviewed-on: https://chromium-review.googlesource.com/1240198
Reviewed-by: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#590}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/382c65b67da8ef30805792f74aa9f82d5acacbd2/components/leveldb_proto/leveldb_database.cc
[modify] https://crrev.com/382c65b67da8ef30805792f74aa9f82d5acacbd2/components/leveldb_proto/leveldb_database.h
[modify] https://crrev.com/382c65b67da8ef30805792f74aa9f82d5acacbd2/tools/metrics/histograms/histograms.xml

The following revision refers to this bug: 
https://chromium.googlesource.com/chromium/src.git/+/382c65b67da8ef30805792f74aa9f82d5acacbd2

Commit: 382c65b67da8ef30805792f74aa9f82d5acacbd2
Author: thildebr@chromium.org
Commiter: thildebr@chromium.org
Date: 2018-09-24 17:34:27 +0000 UTC

Fix LevelDB approximate memory use histogram calculation.

Subtracts the share block cache charge from the approximate memory use
we receive from the LevelDB.

Bug:  870806 ,870813
Change-Id: I90f22d6ad9c7acc29746618bde77386ab3741e17
Reviewed-on: https://chromium-review.googlesource.com/1180271
Reviewed-by: Alexei Svitkine <asvitkine@chromium.org>
Reviewed-by: Tommy Nyquist <nyquist@chromium.org>
Commit-Queue: Troy Hildebrandt <thildebr@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#591740}(cherry picked from commit f802f9338c8a1c8dd115db21feae55eec77be553)
Reviewed-on: https://chromium-review.googlesource.com/1240198
Reviewed-by: Troy Hildebrandt <thildebr@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#590}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}