[MacViews] SHIFT-CMD-ENTER doesn't open the new tab in the foreground |
||||||||
Issue descriptionChrome Version: Canary 70.0.3511.0 OS: macOS 10.13.6 What steps will reproduce the problem? (1) type google.com into the Omnibox (2) press SHIFT-CMD-ENTER What is the expected result? google.com opens in a new tab, but the new tab should be open in the foreground. What happens instead? The new tab opens in the background. (Same as you press CMD-ENTER) This works fine in Cocoa-Mode in Chrome 68. Seems to be a MacVievs issue. Thanks Mehmet
,
Aug 3
Oh yes, thanks. ALT-ENTER works for me in MacViews. Never noticed that ALT-ENTER is working in Cocoa as well.
,
Aug 7
Weird. This works for me on 70.0.3515.0. mehmet: Can you try to repro on latest canary?
,
Aug 7
,
Aug 7
Hi erikchen@, I still can reproduce it with Canary Version 70.0.3515.0 on macOS 10.13.6 :-( SHIFT-CMD-ENTER opens the tab in the background (like CMD-ENTER). Maybe a Keyboard layout settings issue? I am using the Keyboard with the German layout settings.
,
Aug 7
Thank you for providing more feedback. Adding the requester to the cc list. For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot
,
Aug 7
"but the new tab should be open in the foreground." Ahh, missed that. Yeah, it opens in the background for me as well. I've confirmed that on Linux, alt + enter opens in foreground. This sounds like Views is explicitly using alt + enter on all platforms, even though it should use different behavior on macOS. Should be an easy fix. Marking as Pri-1, M-70
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b72eac084f64f9aa76c959bd8077e752abb10c4f commit b72eac084f64f9aa76c959bd8077e752abb10c4f Author: Kevin Bailey <krb@chromium.org> Date: Fri Aug 10 18:48:04 2018 [omnibox mac] Make command-shift-enter open tab in foreground Currently the code falls through to "if (command) then open in background." This change breaks out the variation if shift is also pressed. Bug: 870789 Change-Id: Ie96d355c7c75bec276ed5322aac03f0d3f472a9b Reviewed-on: https://chromium-review.googlesource.com/1170860 Reviewed-by: Tommy Li <tommycli@chromium.org> Commit-Queue: Kevin Bailey <krb@chromium.org> Cr-Commit-Position: refs/heads/master@{#582268} [modify] https://crrev.com/b72eac084f64f9aa76c959bd8077e752abb10c4f/chrome/browser/ui/views/omnibox/omnibox_view_views.cc
,
Aug 10
,
Aug 13
Able to reproduce the issue on chrome version 70.0.3511.0 (build without fix) as per the comment #0. Verified the fix on Mac 10.13.5 using Chrome version # 70.0.3521.0 . Attaching screen-cast for reference. Observed that " the new tab opened in the foreground " The fix is working as expected, adding Verified labels Thanks...!!
,
Sep 14
Issue 884110 has been merged into this issue. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by jdonnelly@chromium.org
, Aug 3