New issue
Advanced search Search tips

Issue 870782 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 3
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Task
Proj-VR
Proj-XR
Proj-XR-VR



Sign in to add a comment

Support changing VR settings mid-test

Project Member Reported by bsheedy@chromium.org, Aug 3

Issue description

VrCore has recently started exposing a service that allows tests to change VrCore settings instead of relying on changing the shared preference files directly. Since this is handled entirely through intents/services, it should be easy to implement in Chromium instrumentation tests.
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/catapult/+/d30f10814bd09c01a756225499b652ca335d6785

commit d30f10814bd09c01a756225499b652ca335d6785
Author: bsheedy <bsheedy@chromium.org>
Date: Fri Aug 03 18:55:12 2018

Fix ReplaceSystemApp not granting permissions

Fixes _TemporarilyInstallApp used by ReplaceSystemApp not granting
permissions to the installed app. For some reason, it was directly
using adb install instead of DeviceUtils' install.

Bug:  chromium:870782 
Change-Id: I9483baedda7cabd2daeee7a28a26555f460657ba
Reviewed-on: https://chromium-review.googlesource.com/1162515
Reviewed-by: Ben Pastene <bpastene@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>

[modify] https://crrev.com/d30f10814bd09c01a756225499b652ca335d6785/devil/devil/android/tools/system_app.py

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dc75293950578cd260b9f91b3d47570d6c853818

commit dc75293950578cd260b9f91b3d47570d6c853818
Author: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Date: Fri Aug 03 21:12:48 2018

Roll src/third_party/catapult 27928c385ec6..d30f10814bd0 (2 commits)

https://chromium.googlesource.com/catapult.git/+log/27928c385ec6..d30f10814bd0


git log 27928c385ec6..d30f10814bd0 --date=short --no-merges --format='%ad %ae %s'
2018-08-03 bsheedy@chromium.org Fix ReplaceSystemApp not granting permissions
2018-08-03 wangge@google.com Long Term Health Tool File Reorganization


Created with:
  gclient setdep -r src/third_party/catapult@d30f10814bd0

The AutoRoll server is located here: https://catapult-roll.skia.org

Documentation for the AutoRoller is here:
https://skia.googlesource.com/buildbot/+/master/autoroll/README.md

If the roll is causing failures, please contact the current sheriff, who should
be CC'd on the roll, and stop the roller if necessary.

CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel

BUG= chromium:870782 , chromium:863390 
TBR=sullivan@chromium.org

Change-Id: I61cecf50cbb85a042494bab6182d719c6cb8b714
Reviewed-on: https://chromium-review.googlesource.com/1162387
Reviewed-by: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Commit-Queue: catapult-chromium-autoroll <catapult-chromium-autoroll@skia-buildbots.google.com.iam.gserviceaccount.com>
Cr-Commit-Position: refs/heads/master@{#580651}
[modify] https://crrev.com/dc75293950578cd260b9f91b3d47570d6c853818/DEPS

Project Member

Comment 3 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9

commit dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9
Author: bsheedy <bsheedy@chromium.org>
Date: Fri Aug 03 22:45:28 2018

Add support for dynamic VrCore settings in tests

Adds support for dynamically changing VrCore's settings during VR tests
using the VR settings service instead of only relying on them being
statically set before the test suite starts. Most tests still use the
old method since dynamic settings have additional overhead. However,
less standard test configurations such as enabling the DON flow are good
candidates for using this functionality.

Also changes the test suites that ran with the DON flow enabled to be
a generic "run with dynamic settings" test suite, which currently only
includes the DON flow tests.

Bug:  870782 
Change-Id: I81482c959f0197c743e9a5a827d80c1b30a56757
Reviewed-on: https://chromium-review.googlesource.com/1162352
Reviewed-by: John Budorick <jbudorick@chromium.org>
Reviewed-by: Michael Thiessen <mthiesse@chromium.org>
Commit-Queue: Brian Sheedy <bsheedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580682}
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/android/BUILD.gn
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/android/javatests/src/org/chromium/chrome/browser/vr/README.md
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrVrTestFramework.java
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/android/javatests/src/org/chromium/chrome/browser/vr/WebXrVrTransitionTest.java
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/android/javatests/src/org/chromium/chrome/browser/vr/adding_new_tests.md
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/ChromeTabbedActivityVrTestRule.java
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/CustomTabActivityVrTestRule.java
[add] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrSettingsFile.java
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/VrTestRule.java
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/android/javatests/src/org/chromium/chrome/browser/vr/rules/WebappActivityVrTestRule.java
[add] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrSettingsServiceUtils.java
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/android/javatests/src/org/chromium/chrome/browser/vr/util/VrTestRuleUtils.java
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/android/javatests/src/org/chromium/chrome/browser/vr/xr_instrumentation_deep_dive.md
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/android/shared_preference_files/test/vr_cardboard_skipdon_setupcomplete.json
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/android/shared_preference_files/test/vr_ddview_skipdon_setupcomplete.json
[add] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/android/shared_preference_files/test/vr_enable_vr_settings_service.json
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/test/android/javatests/src/org/chromium/chrome/test/ChromeJUnit4ClassRunner.java
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/test/android/javatests/src/org/chromium/chrome/test/util/ChromeRestriction.java
[add] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/chrome/test/data/xr/e2e_test_files/vr_settings_files/ddview_donenabled.txt
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/testing/buildbot/chromium.android.json
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/testing/buildbot/chromium.fyi.json
[modify] https://crrev.com/dbeb3b0ff1d612d24f6b0ce5820d248b84452bd9/testing/buildbot/test_suites.pyl

Status: Fixed (was: Assigned)

Sign in to add a comment