According to the mojo style guide: https://cs.chromium.org/chromium/src/services/device/public/mojom/sensor.mojom?l=10 It is recommended not to define placeholder enumerator values. Currently, sensor::SensorType defines two such values: FIRST and LAST: https://chromium.googlesource.com/chromium/src/+/master/docs/security/mojo.md#do-not-define-placeholder-enumerator-values It would be better to remove these according to the above mojo style guide.
According to the mojo style guide: https://chromium.googlesource.com/chromium/src/+/master/docs/security/mojo.md#do-not-define-placeholder-enumerator-values It is recommended not to define placeholder enumerator values. Currently, sensor::SensorType defines two such values: FIRST and LAST: https://cs.chromium.org/chromium/src/services/device/public/mojom/sensor.mojom?l=10 It would be better to remove these according to the above mojo style guide.
Assigned this issue to me for now, anyone who is interested in working on it, feel free to take the ownership of this issue.
CL merged: https://chromium-review.googlesource.com/c/chromium/src/+/1197423
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/a4b605bff8e031e952baea11163c8cf1ad883460 commit a4b605bff8e031e952baea11163c8cf1ad883460 Author: Jun Cai <juncai@chromium.org> Date: Tue Sep 04 22:42:16 2018 Device Sensor: Remove placeholder enumerator values in the sensor::SensorType According to the mojo style guide: https://chromium.googlesource.com/chromium/src/+/master/docs/security/mojo.md#do-not-define-placeholder-enumerator-values It is recommended not to define placeholder enumerator values. Currently, sensor::SensorType defines two such values: FIRST and LAST. This CL removes these two placeholder values. Bug: 870781 Cq-Include-Trybots: luci.chromium.try:win_optional_gpu_tests_rel Change-Id: I8b275bc5680c8c0d97fe2e7208301d6f33236cbe Reviewed-on: https://chromium-review.googlesource.com/1197423 Commit-Queue: Jun Cai <juncai@chromium.org> Reviewed-by: Tom Sepez <tsepez@chromium.org> Reviewed-by: Reilly Grant <reillyg@chromium.org> Cr-Commit-Position: refs/heads/master@{#588678} [modify] https://crrev.com/a4b605bff8e031e952baea11163c8cf1ad883460/device/vr/orientation/orientation_device_provider_unittest.cc [modify] https://crrev.com/a4b605bff8e031e952baea11163c8cf1ad883460/device/vr/orientation/orientation_device_unittest.cc [modify] https://crrev.com/a4b605bff8e031e952baea11163c8cf1ad883460/services/device/generic_sensor/fake_platform_sensor_and_provider.cc [modify] https://crrev.com/a4b605bff8e031e952baea11163c8cf1ad883460/services/device/generic_sensor/linux/sensor_device_manager.cc [modify] https://crrev.com/a4b605bff8e031e952baea11163c8cf1ad883460/services/device/generic_sensor/platform_sensor_provider_base.cc [modify] https://crrev.com/a4b605bff8e031e952baea11163c8cf1ad883460/services/device/public/cpp/generic_sensor/sensor_reading.cc [modify] https://crrev.com/a4b605bff8e031e952baea11163c8cf1ad883460/services/device/public/cpp/generic_sensor/sensor_traits.cc [modify] https://crrev.com/a4b605bff8e031e952baea11163c8cf1ad883460/services/device/public/cpp/test/fake_sensor_and_provider.cc [modify] https://crrev.com/a4b605bff8e031e952baea11163c8cf1ad883460/services/device/public/mojom/sensor.mojom [modify] https://crrev.com/a4b605bff8e031e952baea11163c8cf1ad883460/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/generic_sensor_mocks.js [modify] https://crrev.com/a4b605bff8e031e952baea11163c8cf1ad883460/third_party/WebKit/LayoutTests/external/wpt/resources/chromium/sensor.mojom.js [modify] https://crrev.com/a4b605bff8e031e952baea11163c8cf1ad883460/third_party/WebKit/LayoutTests/http/tests/resources/sensor-helpers.js [modify] https://crrev.com/a4b605bff8e031e952baea11163c8cf1ad883460/third_party/WebKit/LayoutTests/http/tests/security/powerfulFeatureRestrictions/old-powerful-features-on-insecure-origin-expected.txt
Comment 1 by juncai@chromium.org
, Aug 3