New issue
Advanced search Search tips

Issue 870775 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Jan 10
Components:
EstimatedDays: ----
NextAction: ----
OS: Chrome
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

A11y: Chrome://settings add accessibility features has nested controls

Project Member Reported by dsexton@chromium.org, Aug 3

Issue description

Chrome: 69.0.3497.23 (Official Build) beta (64-bit) (cohort: Beta)
JAWS: 2018
NVDA: 2018.2.1

Steps to repro:
# With NVDA or JAWS on, visit Chrome://settings
# Click 'Advanced'
# Navigate to 'Accessibility'
# Use arrows and tab to read the 'Add accessibility features' control
# Notice that it is a button element inside a link
Add accessibility features (link)
Open Chrome Web Store (link)
Add accessibility features (button)

Expected: This should be only a link

Actual: Different screen readers will treat nested controls differently and it is confusing to users which control should be used.

 
Labels: a11y-WebUI a11y-Settings
Labels: pm-markchang
Labels: jaws
Labels: -JAWS
Labels: -Pri-2 Pri-1
Bumping up priority since this is the accessibility portion of settings and should be smooth
Labels: Group-WebUI
Labels: -Group-WebUI Group-WebUI_Settings
Labels: OS-Chrome
Status: Started (was: Available)
Owner: aee@chromium.org
Project Member

Comment 11 by bugdroid1@chromium.org, Jan 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/984fed296cf3f5b681b998496d822876738f62a6

commit 984fed296cf3f5b681b998496d822876738f62a6
Author: Esmael El-Moslimany <aee@chromium.org>
Date: Thu Jan 10 00:48:11 2019

Settings WebUI: change web store nested button in a link into a cr-link-row

Bug:  870775 
Change-Id: I903d2da29b2c332da67e3d7eb062d9198db72b35
Reviewed-on: https://chromium-review.googlesource.com/c/1403634
Reviewed-by: Hector Carmona <hcarmona@chromium.org>
Commit-Queue: Esmael El-Moslimany <aee@chromium.org>
Cr-Commit-Position: refs/heads/master@{#621395}
[modify] https://crrev.com/984fed296cf3f5b681b998496d822876738f62a6/chrome/browser/resources/settings/a11y_page/a11y_page.html
[modify] https://crrev.com/984fed296cf3f5b681b998496d822876738f62a6/chrome/browser/resources/settings/a11y_page/a11y_page.js

Status: Fixed (was: Started)

Sign in to add a comment