Duet bottom toolbar obscures bottom of NTP |
|||
Issue descriptionThe bottom toolbar in Duet obscures the "learn more" footer of the NTP. This is likely due to the fact that the NTP is not a BasicNativePage which handles top and bottom margin due to browser controls. We need to add this bottom margin to the NTP when Duet is enabled.
,
Aug 9
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/00f54c8bbbcbe8b00c1e7d86e52333cb78efee1a commit 00f54c8bbbcbe8b00c1e7d86e52333cb78efee1a Author: Matthew Jones <mdjones@chromium.org> Date: Fri Aug 10 16:02:42 2018 Fix padding issues on Duet NTP This patch reduces the padding above the logo on the NTP to reduce the unneeded whitespace and adds padding to the bottom so that the footer is not obscured by the bottom toolbar. Bug: 870748 , 869612 Change-Id: I9e003149d32d54b2652e20e1a45524724985abff Reviewed-on: https://chromium-review.googlesource.com/1169587 Reviewed-by: Theresa <twellington@chromium.org> Commit-Queue: Matthew Jones <mdjones@chromium.org> Cr-Commit-Position: refs/heads/master@{#582185} [modify] https://crrev.com/00f54c8bbbcbe8b00c1e7d86e52333cb78efee1a/chrome/android/java/res/values/dimens.xml [modify] https://crrev.com/00f54c8bbbcbe8b00c1e7d86e52333cb78efee1a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageLayout.java [modify] https://crrev.com/00f54c8bbbcbe8b00c1e7d86e52333cb78efee1a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
,
Aug 10
|
|||
►
Sign in to add a comment |
|||
Comment 1 by twelling...@chromium.org
, Aug 7