Make Dawn build in Chromium |
||||||||
Issue descriptionDawn is the "ANGLE for WebGPU", integrate it inside the Chromium build so we can start using it in the GPU process and to run tests on the Chromium waterfall.
,
Aug 12
,
Aug 12
,
Aug 13
,
Aug 23
,
Aug 23
,
Sep 25
The following revision refers to this bug: https://dawn.googlesource.com/dawn/+/038a8554ad2c46517d04bc0f1e4f6abe7fcbc64b commit 038a8554ad2c46517d04bc0f1e4f6abe7fcbc64b Author: Corentin Wallez <cwallez@chromium.org> Date: Tue Sep 25 20:53:37 2018 Add component to OWNERS and fixup repo URL in README.chromium BUG= chromium:870747 Change-Id: I678393ca29f934ecc23f0140d2d211fccf619a5f Reviewed-on: https://dawn-review.googlesource.com/1640 Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> [modify] https://crrev.com/038a8554ad2c46517d04bc0f1e4f6abe7fcbc64b/OWNERS [modify] https://crrev.com/038a8554ad2c46517d04bc0f1e4f6abe7fcbc64b/README.chromium
,
Sep 25
The following revision refers to this bug: https://dawn.googlesource.com/dawn/+/299ce6c69cacc6a11cbce3df860002564682b76a commit 299ce6c69cacc6a11cbce3df860002564682b76a Author: Corentin Wallez <cwallez@chromium.org> Date: Tue Sep 25 21:50:44 2018 BUILD.gn: Make SPIRV-Cross includes relative to repo. BUG= chromium:870747 Change-Id: I9dfdc4f88b0f17b9c2a4e102610d9eb125087bba Reviewed-on: https://dawn-review.googlesource.com/1642 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> [modify] https://crrev.com/299ce6c69cacc6a11cbce3df860002564682b76a/third_party/BUILD.gn
,
Sep 25
The following revision refers to this bug: https://dawn.googlesource.com/dawn/+/76664ed8d03e9fb353c1bab9484bd7f70f2df682 commit 76664ed8d03e9fb353c1bab9484bd7f70f2df682 Author: Corentin Wallez <cwallez@chromium.org> Date: Tue Sep 25 21:52:44 2018 BUILD.gn: Make dawn_standalone default to false BUG= chromium:870747 Change-Id: I9d80bb8a73227a9a9e5a7c466ac5b40a10fc0106 Reviewed-on: https://dawn-review.googlesource.com/1641 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> [modify] https://crrev.com/76664ed8d03e9fb353c1bab9484bd7f70f2df682/build_overrides/dawn.gni [modify] https://crrev.com/76664ed8d03e9fb353c1bab9484bd7f70f2df682/scripts/dawn_overrides_with_defaults.gni
,
Sep 25
The following revision refers to this bug: https://chromium.googlesource.com/angle/angle/+/a883dd0653f461886245f31afa780743a3818faa commit a883dd0653f461886245f31afa780743a3818faa Author: Corentin Wallez <cwallez@chromium.org> Date: Tue Sep 25 22:45:36 2018 Use SPIRV-Tools' BUILD.gn files This adds build_overrides/spirv_tools.gni to tell it where to find its dependencies. BUG= chromium:870747 Change-Id: Id1d9fb836e74597860a4411df0a4fd0651840f57 Reviewed-on: https://chromium-review.googlesource.com/1162240 Reviewed-by: Jamie Madill <jmadill@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> [add] https://crrev.com/a883dd0653f461886245f31afa780743a3818faa/build_overrides/spirv_tools.gni [modify] https://crrev.com/a883dd0653f461886245f31afa780743a3818faa/third_party/vulkan-validation-layers/BUILD.gn [modify] https://crrev.com/a883dd0653f461886245f31afa780743a3818faa/DEPS [delete] https://crrev.com/8b57fae57908d5be0b0c3882d6f1c40b97b3cb56/third_party/spirv-tools/BUILD.gn
,
Sep 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b8531b9e4ce52daff1e9291f7c2ab93375c6a438 commit b8531b9e4ce52daff1e9291f7c2ab93375c6a438 Author: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Date: Wed Sep 26 02:53:58 2018 Roll src/third_party/angle 8b57fae57908..cf8ad760955d (4 commits) https://chromium.googlesource.com/angle/angle.git/+log/8b57fae57908..cf8ad760955d git log 8b57fae57908..cf8ad760955d --date=short --no-merges --format='%ad %ae %s' 2018-09-26 jiawei.shao@intel.com ES31: Support translating textureGatherOffset into HLSL 2018-09-26 jmadill@chromium.org Skip NoBufferData test on NVIDIA Shield TV. 2018-09-25 geofflang@chromium.org Vulkan: Use automatic row length and image height for texture copies. 2018-09-25 cwallez@chromium.org Use SPIRV-Tools' BUILD.gn files Created with: gclient setdep -r src/third_party/angle@cf8ad760955d The AutoRoll server is located here: https://autoroll.skia.org/r/angle-chromium-autoroll Documentation for the AutoRoller is here: https://skia.googlesource.com/buildbot/+/master/autoroll/README.md If the roll is causing failures, please contact the current sheriff, who should be CC'd on the roll, and stop the roller if necessary. CQ_INCLUDE_TRYBOTS=luci.chromium.try:android_optional_gpu_tests_rel;luci.chromium.try:linux_optional_gpu_tests_rel;luci.chromium.try:mac_optional_gpu_tests_rel;luci.chromium.try:win_optional_gpu_tests_rel BUG= chromium:889303 , chromium:870747 TBR=syoussefi@chromium.org Change-Id: I902040a60b3448dfb5bedf6ae814f8c883b142b9 Reviewed-on: https://chromium-review.googlesource.com/1244938 Reviewed-by: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Commit-Queue: chromium-autoroll <chromium-autoroll@skia-public.iam.gserviceaccount.com> Cr-Commit-Position: refs/heads/master@{#594198} [modify] https://crrev.com/b8531b9e4ce52daff1e9291f7c2ab93375c6a438/DEPS
,
Oct 4
The following revision refers to this bug: https://dawn.googlesource.com/dawn/+/16092faa163b20f6b85ff407b1ec1d61cb9d7f2a commit 16092faa163b20f6b85ff407b1ec1d61cb9d7f2a Author: Corentin Wallez <cwallez@chromium.org> Date: Thu Oct 04 17:17:57 2018 Roll shaderc and glslang and use their BUILD.gn This rolls glslang and shaderc to be able to use their BUILD.gn files, and also rolls SPIRV-Tools and spirv-headers to have compatible versions. BUG= chromium:870747 Change-Id: I13c615f6f3d148c9b69f06547992bf5910e04e62 Reviewed-on: https://dawn-review.googlesource.com/c/1680 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> [modify] https://crrev.com/16092faa163b20f6b85ff407b1ec1d61cb9d7f2a/scripts/dawn_overrides_with_defaults.gni [add] https://crrev.com/16092faa163b20f6b85ff407b1ec1d61cb9d7f2a/build_overrides/shaderc.gni [modify] https://crrev.com/16092faa163b20f6b85ff407b1ec1d61cb9d7f2a/third_party/spirv-tools [modify] https://crrev.com/16092faa163b20f6b85ff407b1ec1d61cb9d7f2a/third_party/shaderc [modify] https://crrev.com/16092faa163b20f6b85ff407b1ec1d61cb9d7f2a/BUILD.gn [add] https://crrev.com/16092faa163b20f6b85ff407b1ec1d61cb9d7f2a/build_overrides/glslang.gni [modify] https://crrev.com/16092faa163b20f6b85ff407b1ec1d61cb9d7f2a/third_party/glslang [modify] https://crrev.com/16092faa163b20f6b85ff407b1ec1d61cb9d7f2a/build_overrides/dawn.gni [modify] https://crrev.com/16092faa163b20f6b85ff407b1ec1d61cb9d7f2a/DEPS [modify] https://crrev.com/16092faa163b20f6b85ff407b1ec1d61cb9d7f2a/third_party/BUILD.gn [modify] https://crrev.com/16092faa163b20f6b85ff407b1ec1d61cb9d7f2a/third_party/spirv-headers
,
Oct 15
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/382f3853b1ed90c29d95225d30b2c021fec66c96 commit 382f3853b1ed90c29d95225d30b2c021fec66c96 Author: Corentin Wallez <cwallez@chromium.org> Date: Mon Oct 15 20:46:38 2018 Add Dawn, SPIRV-Cross and GLFW to //third_party Dawn is a library implementing WebGPU in native. It uses SPIRV-Cross to translate shaders from SPIRV to other shading languages, and requires glfw for testing. Adds the Zlib license to the list of allowed license for Android. This also adds back shaderc that was very recently removed. So hopefully a new third_party review isn't required. BUG= chromium:870747 Change-Id: I506156072f34e70e12797f922a979aa8c743bd6e Reviewed-on: https://chromium-review.googlesource.com/c/1244817 Reviewed-by: Will Harris <wfh@chromium.org> Reviewed-by: Jochen Eisinger <jochen@chromium.org> Reviewed-by: dsinclair <dsinclair@chromium.org> Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#599740} [modify] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/BUILD.gn [modify] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/DEPS [add] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/build_overrides/dawn.gni [add] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/build_overrides/glslang.gni [add] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/build_overrides/shaderc.gni [modify] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/third_party/.gitignore [modify] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/third_party/PRESUBMIT.py [add] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/third_party/glfw/OWNERS [add] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/third_party/glfw/README.chromium [add] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/third_party/shaderc/OWNERS [add] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/third_party/shaderc/README.chromium [add] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/third_party/spirv-cross/OWNERS [add] https://crrev.com/382f3853b1ed90c29d95225d30b2c021fec66c96/third_party/spirv-cross/README.chromium
,
Oct 16
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/b5e6f7410f740c4279c884000a22007e984bdbe9 commit b5e6f7410f740c4279c884000a22007e984bdbe9 Author: John Budorick <jbudorick@chromium.org> Date: Tue Oct 16 00:31:01 2018 Revert "Add Dawn, SPIRV-Cross and GLFW to //third_party" This reverts commit 382f3853b1ed90c29d95225d30b2c021fec66c96. Reason for revert: crbug.com/895592 Original change's description: > Add Dawn, SPIRV-Cross and GLFW to //third_party > > Dawn is a library implementing WebGPU in native. It uses SPIRV-Cross to > translate shaders from SPIRV to other shading languages, and requires > glfw for testing. > > Adds the Zlib license to the list of allowed license for Android. > > This also adds back shaderc that was very recently removed. So hopefully > a new third_party review isn't required. > > BUG= chromium:870747 > > Change-Id: I506156072f34e70e12797f922a979aa8c743bd6e > Reviewed-on: https://chromium-review.googlesource.com/c/1244817 > Reviewed-by: Will Harris <wfh@chromium.org> > Reviewed-by: Jochen Eisinger <jochen@chromium.org> > Reviewed-by: dsinclair <dsinclair@chromium.org> > Reviewed-by: Kai Ninomiya <kainino@chromium.org> > Commit-Queue: Corentin Wallez <cwallez@chromium.org> > Cr-Commit-Position: refs/heads/master@{#599740} TBR=dsinclair@chromium.org,cwallez@chromium.org,wfh@chromium.org,kainino@chromium.org,jochen@chromium.org,dominic@google.com Change-Id: I861d000856773e66a6a2c060ae737599b3be3e4d No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: chromium:870747 Reviewed-on: https://chromium-review.googlesource.com/c/1281879 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: John Budorick <jbudorick@chromium.org> Cr-Commit-Position: refs/heads/master@{#599793} [modify] https://crrev.com/b5e6f7410f740c4279c884000a22007e984bdbe9/BUILD.gn [modify] https://crrev.com/b5e6f7410f740c4279c884000a22007e984bdbe9/DEPS [delete] https://crrev.com/bbe547af1bca45c9bd728d90c1e6685fc314f001/build_overrides/dawn.gni [delete] https://crrev.com/bbe547af1bca45c9bd728d90c1e6685fc314f001/build_overrides/glslang.gni [delete] https://crrev.com/bbe547af1bca45c9bd728d90c1e6685fc314f001/build_overrides/shaderc.gni [modify] https://crrev.com/b5e6f7410f740c4279c884000a22007e984bdbe9/third_party/.gitignore [modify] https://crrev.com/b5e6f7410f740c4279c884000a22007e984bdbe9/third_party/PRESUBMIT.py [delete] https://crrev.com/bbe547af1bca45c9bd728d90c1e6685fc314f001/third_party/glfw/OWNERS [delete] https://crrev.com/bbe547af1bca45c9bd728d90c1e6685fc314f001/third_party/glfw/README.chromium [delete] https://crrev.com/bbe547af1bca45c9bd728d90c1e6685fc314f001/third_party/shaderc/OWNERS [delete] https://crrev.com/bbe547af1bca45c9bd728d90c1e6685fc314f001/third_party/shaderc/README.chromium [delete] https://crrev.com/bbe547af1bca45c9bd728d90c1e6685fc314f001/third_party/spirv-cross/OWNERS [delete] https://crrev.com/bbe547af1bca45c9bd728d90c1e6685fc314f001/third_party/spirv-cross/README.chromium
,
Oct 16
,
Oct 21
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/955059ffeb5a1bacff833b648b12296ff55e8c11 commit 955059ffeb5a1bacff833b648b12296ff55e8c11 Author: Corentin Wallez <cwallez@chromium.org> Date: Sun Oct 21 10:47:39 2018 Reland 'Add Dawn, SPIRV-Cross and GLFW to //third_party' This is a reland after contacting the infra team about the addition of dawn.googlesource.com to allowed_hosts. It also doesn't have the Dawn build targets listed in BUILD.gn. These will be listed separately. Dawn is a library implementing WebGPU in native. It uses SPIRV-Cross to translate shaders from SPIRV to other shading languages, and requires glfw for testing. Adds the Zlib license to the list of allowed license for Android. This also adds back shaderc that was very recently removed. So hopefully a new third_party review isn't required. BUG= chromium:870747 Change-Id: Ib5bb0530fc147e41a4f31796c30542e032bf0603 Reviewed-on: https://chromium-review.googlesource.com/c/1286135 Reviewed-by: Jochen Eisinger <jochen@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#601445} [modify] https://crrev.com/955059ffeb5a1bacff833b648b12296ff55e8c11/DEPS [add] https://crrev.com/955059ffeb5a1bacff833b648b12296ff55e8c11/build_overrides/dawn.gni [add] https://crrev.com/955059ffeb5a1bacff833b648b12296ff55e8c11/build_overrides/glslang.gni [add] https://crrev.com/955059ffeb5a1bacff833b648b12296ff55e8c11/build_overrides/shaderc.gni [modify] https://crrev.com/955059ffeb5a1bacff833b648b12296ff55e8c11/third_party/.gitignore [modify] https://crrev.com/955059ffeb5a1bacff833b648b12296ff55e8c11/third_party/PRESUBMIT.py [add] https://crrev.com/955059ffeb5a1bacff833b648b12296ff55e8c11/third_party/glfw/OWNERS [add] https://crrev.com/955059ffeb5a1bacff833b648b12296ff55e8c11/third_party/glfw/README.chromium [add] https://crrev.com/955059ffeb5a1bacff833b648b12296ff55e8c11/third_party/shaderc/OWNERS [add] https://crrev.com/955059ffeb5a1bacff833b648b12296ff55e8c11/third_party/shaderc/README.chromium [add] https://crrev.com/955059ffeb5a1bacff833b648b12296ff55e8c11/third_party/spirv-cross/OWNERS [add] https://crrev.com/955059ffeb5a1bacff833b648b12296ff55e8c11/third_party/spirv-cross/README.chromium
,
Oct 23
The following revision refers to this bug: https://dawn.googlesource.com/dawn/+/5aac265dcb72d37e71d906b4f65e793e27124201 commit 5aac265dcb72d37e71d906b4f65e793e27124201 Author: Corentin Wallez <cwallez@chromium.org> Date: Tue Oct 23 12:50:10 2018 Roll glslang and shaderc These new versions contain the fix for not having static libraries with no sources depending on source sets in their BUILD.gn BUG= chromium:870747 Change-Id: Ib979d5ee581f37db22347f0f725086a9b9833d07 Reviewed-on: https://dawn-review.googlesource.com/c/1900 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> [modify] https://crrev.com/5aac265dcb72d37e71d906b4f65e793e27124201/third_party/glslang [modify] https://crrev.com/5aac265dcb72d37e71d906b4f65e793e27124201/third_party/shaderc [modify] https://crrev.com/5aac265dcb72d37e71d906b4f65e793e27124201/DEPS
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f90c2427021734c4c157d6f5b3d390b08565b9f commit 1f90c2427021734c4c157d6f5b3d390b08565b9f Author: Corentin Wallez <cwallez@chromium.org> Date: Tue Oct 23 14:18:35 2018 Roll src/third_party/shaderc/src/ 196d38f64..909f0d3d3 (5 commits) https://chromium.googlesource.com/external/github.com/google/shaderc.git/+log/196d38f64e4d..909f0d3d31e7 $ git log 196d38f64..909f0d3d3 --date=short --no-merges --format='%ad %ae %s' 2018-10-17 cwallez BUILD.gn: remove the static_library target. 2018-10-11 antiagainst [kokoro] Report error if ctest fails 2018-10-10 antiagainst [kokoro] Compile for x86_64 and print CMake version on Windows 2018-10-09 dneto VS builds: Pin an older googletest to avoid around a CMake problem 2018-10-09 antiagainst Disable layout and relax logical pointer for optimizer validation Created with: roll-dep src/third_party/shaderc/src R=dsinclair@chromium.org BUG= chromium:870747 Change-Id: I6550188776c5023ecd1bb7df5bd3d673dbeef0b9 Reviewed-on: https://chromium-review.googlesource.com/c/1296497 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#601940} [modify] https://crrev.com/1f90c2427021734c4c157d6f5b3d390b08565b9f/DEPS
,
Oct 23
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c552f4039b472221af7123d78e660c5bcfa0beb1 commit c552f4039b472221af7123d78e660c5bcfa0beb1 Author: Corentin Wallez <cwallez@chromium.org> Date: Tue Oct 23 14:22:28 2018 Roll src/third_party/glslang/src/ ca042a0ff..a08f465d5 (10 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/ca042a0ffbb6..a08f465d5398 $ git log ca042a0ff..a08f465d5 --date=short --no-merges --format='%ad %ae %s' 2018-10-20 cepheus Build: Fix #1490, unused variables. 2018-10-20 cepheus Fix #1536: use string instead of TString for uniform-location override. 2018-10-17 cwallez BUILD.gn: remove the static_library target. 2018-10-17 rex.xu Fix a parse issue of imageAtomicCompSwap() 2018-10-15 jbolz Fix flags.nonprivate to be true for workgroup memory, which is implicitly workgroupcoherent/nonprivate 2018-10-10 webmaster Create CODE_OF_CONDUCT.md 2018-10-04 chaoc For GL_NV_geometry_shader_passthrough extension, the Inferred output primitive for ElgTriangles should be ElgTriangleStrip. 2018-10-04 sparmar Allow redeclaration of builtin interface blocks in mesh shader 2018-03-20 nroberts Add an option to set the base uniform location 2018-03-20 nroberts Add a command-line option to override uniform locations Created with: roll-dep src/third_party/glslang/src R=dsinclair@chromium.org BUG= chromium:870747 Change-Id: Icfa80ce00b8b244399bf3325690014e876626e92 Reviewed-on: https://chromium-review.googlesource.com/c/1296496 Reviewed-by: dsinclair <dsinclair@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#601944} [modify] https://crrev.com/c552f4039b472221af7123d78e660c5bcfa0beb1/DEPS
,
Oct 30
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/0b71452bda0aa3a220d2bc626c379bc472ed0163 commit 0b71452bda0aa3a220d2bc626c379bc472ed0163 Author: Corentin Wallez <cwallez@chromium.org> Date: Tue Oct 30 17:35:00 2018 gpu: Add "main" files for Dawn's gtest targets. Also changes existing test targets to use base::BindOnce instead of the deprecated base::Bind, and removes some unused includes. R=kbr@chromium.org BUG= chromium:870747 Change-Id: Ib94ffd228a6057a7010e8581ccb3392ae700c357 Reviewed-on: https://chromium-review.googlesource.com/c/1307510 Reviewed-by: Kenneth Russell <kbr@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#603945} [modify] https://crrev.com/0b71452bda0aa3a220d2bc626c379bc472ed0163/gpu/angle_deqp_tests_main.cc [modify] https://crrev.com/0b71452bda0aa3a220d2bc626c379bc472ed0163/gpu/angle_end2end_tests_main.cc [modify] https://crrev.com/0b71452bda0aa3a220d2bc626c379bc472ed0163/gpu/angle_perftests_main.cc [modify] https://crrev.com/0b71452bda0aa3a220d2bc626c379bc472ed0163/gpu/angle_unittest_main.cc [add] https://crrev.com/0b71452bda0aa3a220d2bc626c379bc472ed0163/gpu/dawn_end2end_tests_main.cc [add] https://crrev.com/0b71452bda0aa3a220d2bc626c379bc472ed0163/gpu/dawn_unittests_main.cc [modify] https://crrev.com/0b71452bda0aa3a220d2bc626c379bc472ed0163/gpu/swiftshader_tests_main.cc
,
Oct 31
The following revision refers to this bug: https://dawn.googlesource.com/dawn/+/e92ad5bb893c1486942bdf60c318bf5f827c5d15 commit e92ad5bb893c1486942bdf60c318bf5f827c5d15 Author: Corentin Wallez <cwallez@chromium.org> Date: Wed Oct 31 10:49:21 2018 Build with a different gtest harness when in Chromium Running test in a Chromium build requires using their gtest and gmock targets as well as a harness that is in //base. Since we want to run Dawn tests on the Chromium GPU bots, we need to support two configurations both building tests standalone and in Chromium. BUG= chromium:870747 Change-Id: I862e62a607e193a27562ece0f1f6d46d8728e446 Reviewed-on: https://dawn-review.googlesource.com/c/2080 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Reviewed-by: Stephen White <senorblanco@chromium.org> Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> [modify] https://crrev.com/e92ad5bb893c1486942bdf60c318bf5f827c5d15/BUILD.gn [modify] https://crrev.com/e92ad5bb893c1486942bdf60c318bf5f827c5d15/third_party/BUILD.gn
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/aef6564ddf4edfa8aaf5019cfd4a8fb500fa852c commit aef6564ddf4edfa8aaf5019cfd4a8fb500fa852c Author: Corentin Wallez <cwallez@chromium.org> Date: Wed Oct 31 13:48:03 2018 Roll src/third_party/dawn/ 16092faa1..61791eae3 (19 commits) https://dawn.googlesource.com/dawn.git/+log/16092faa163b..61791eae36b8 $ git log 16092faa1..61791eae3 --date=short --no-merges --format='%ad %ae %s' 2018-10-31 cwallez Roll glslang to get a `gn check` fix. 2018-10-31 cwallez Remove support for CMake builds 2018-10-31 jiawei.shao Rename mipLevel to levelCount in TextureDescriptor 2018-10-31 cwallez Build with a different gtest harness when in Chromium 2018-10-30 yunchao.he Initialize BlendDescriptor with default values. 2018-10-29 jiawei.shao Support creating texture view with descriptor on OpenGL version >= 4.3 2018-10-29 yunchao.he Use blend descriptor to replace a blend struct. 2018-10-26 senorblanco Fix D3D12 Buffer::UnmapImpl() for MapWriteAsync(). 2018-10-26 yunchao.he make the names in dawn.json consistent. 2018-10-26 jiawei.shao Create texture view with descriptor on D3D12 and Metal - Part I 2018-10-25 cwallez Add copy constructors to the C++ Dawn interface 2018-10-23 cwallez Roll glslang and shaderc 2018-10-23 jiawei.shao Implement creating texture view with descriptor on Vulkan 2018-10-18 jiawei.shao Implement CreateDefaultTextureView by CreateTextureView 2018-10-16 cwallez Suppress test failure on Vulkan 2018-10-15 cwallez Put the reference to DeviceBase in a new ObjectBase 2018-10-12 jiawei.shao Add entry point of creating texture view by TextureViewDescriptor 2018-10-09 jiawei.shao Support creating default texture view on 2D array textures 2018-10-08 cwallez Remove references to Github in README and CONTRIBUTING Created with: roll-dep src/third_party/dawn TBR=kainino@chromium.org Bug: 870747 Change-Id: I09ed7e4233cace90ff88117705db579c5ee9cb99 Reviewed-on: https://chromium-review.googlesource.com/c/1309783 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#604233} [modify] https://crrev.com/aef6564ddf4edfa8aaf5019cfd4a8fb500fa852c/DEPS
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/39c6fbea496641a6514e34c0ab689871d14e6d52 commit 39c6fbea496641a6514e34c0ab689871d14e6d52 Author: Corentin Wallez <cwallez@chromium.org> Date: Wed Oct 31 13:49:36 2018 Roll src/third_party/glslang/src/ a08f465d5..0ac199df3 (8 commits) https://chromium.googlesource.com/external/github.com/KhronosGroup/glslang.git/+log/a08f465d5398..0ac199df3268 $ git log a08f465d5..0ac199df3 --date=short --no-merges --format='%ad %ae %s' 2018-10-30 cwallez BUILD.gn: remove reference to non-existent header 2018-10-29 cwallez Fix MSVC warning C4065: 'default' but no 'case' labels 2018-10-26 cepheus Build: Pin googletest to a version that works with visual studio 2013. 2018-10-26 cepheus SPV/Standalone: Support specifying arbitrary versions of SPIR-V. 2018-10-23 neil.henning Fix 8-bit storage nearly always using the UniformAndStorageBuffer8BitAccess capability. 2018-10-25 sparmar Allow GL_NV_mesh_shader in fragment shaders for perprimitiveNV 2018-10-25 cepheus PP: Fix #155: Don't give error on HLSL PP-only parsing. 2018-10-24 dsinclair Fixup unused parameter warnings Created with: roll-dep src/third_party/glslang/src TBR=dsinclair@chromium.org Bug: 870747 Change-Id: Iba9e47a7ed03898808a682157d92f540dc9f27a9 Reviewed-on: https://chromium-review.googlesource.com/c/1309738 Reviewed-by: Corentin Wallez <cwallez@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#604234} [modify] https://crrev.com/39c6fbea496641a6514e34c0ab689871d14e6d52/DEPS
,
Oct 31
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/20b9646d6f88780e70d0f376b72423c48764582f commit 20b9646d6f88780e70d0f376b72423c48764582f Author: Corentin Wallez <cwallez@chromium.org> Date: Wed Oct 31 14:43:03 2018 Compile Dawn test binaries in "all" on Win/Mac/Linux This will allow us to run Dawn's GPU tests on the Chromium GPU FYI waterfall and GPU trybots. BUG= chromium:870747 Change-Id: I026cd1851aadbf1dae2446c539901bf4a755dfd8 Reviewed-on: https://chromium-review.googlesource.com/c/1299089 Reviewed-by: John Budorick <jbudorick@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> Cr-Commit-Position: refs/heads/master@{#604249} [modify] https://crrev.com/20b9646d6f88780e70d0f376b72423c48764582f/BUILD.gn
,
Nov 1
Hi all, enabling unconditional compilation of Dawn test binaries for Linux, broke the build for non x86 architectures. For MIPS arch there is a an error coming from common/Compiler.h:39:10: error "Implement BREAKPOINT on your platform" This can be seen at our buildbot: http://www.rt-rk.com/mips-buildbot/builders/chromium_continuous_build/builds/348/steps/Build%20Chromium/logs/stdio Is there a possibility that something like enable_dawn could be added? Or should I make a change that removes "//third_party/dawn:dawn_end2end_tests" and "//third_party/dawn:dawn_unittests" from deps in BUILD.gn when current_cpu is mipsel or mips64el? Thanks, Milko
,
Nov 1
Thanks for the head's up. I have a CL up that should fix the issue: https://dawn-review.googlesource.com/c/dawn/+/2140 Looking at Chrome's BUILD.gn there isn't really precedent to compile on only certain platforms (except Swiftshader because it includes a JIT). So I'd like to compile Dawn unconditionally on Linux and make sure it compiles on all platforms. Right now either waiting for the CL above to land (and Dawn to roll) or reverting the last commit would be ok (I'd reland it after the roll).
,
Nov 1
The following revision refers to this bug: https://dawn.googlesource.com/dawn/+/2960ec33667a11bb4445dfe8154aef133c741afe commit 2960ec33667a11bb4445dfe8154aef133c741afe Author: Corentin Wallez <cwallez@chromium.org> Date: Thu Nov 01 14:30:24 2018 Add support for all of Chromium's CPU architectures. BUG= chromium:870747 Change-Id: I421819871f5c45ac07850585e5dcc600d1ff8086 Reviewed-on: https://dawn-review.googlesource.com/c/2140 Reviewed-by: Stephen White <senorblanco@chromium.org> Commit-Queue: Corentin Wallez <cwallez@chromium.org> [modify] https://crrev.com/2960ec33667a11bb4445dfe8154aef133c741afe/src/common/Compiler.h [modify] https://crrev.com/2960ec33667a11bb4445dfe8154aef133c741afe/src/common/Platform.h
,
Nov 1
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/1f40f2ee77633472981b39b41b21da368208a970 commit 1f40f2ee77633472981b39b41b21da368208a970 Author: Corentin Wallez <cwallez@chromium.org> Date: Thu Nov 01 16:38:45 2018 Roll src/third_party/dawn/ 61791eae3..2960ec336 (2 commits) https://dawn.googlesource.com/dawn.git/+log/61791eae36b8..2960ec33667a $ git log 61791eae3..2960ec336 --date=short --no-merges --format='%ad %ae %s' 2018-11-01 cwallez Add support for all of Chromium's CPU architectures. 2018-11-01 senorblanco D3D12 fix for register binding offsets. Created with: roll-dep src/third_party/dawn TBR=kainino@chromium.org BUG= 870747 Change-Id: I6942e2e387f367be3aee7f707152375e6d6c0254 Reviewed-on: https://chromium-review.googlesource.com/c/1311932 Reviewed-by: Kai Ninomiya <kainino@chromium.org> Commit-Queue: Kai Ninomiya <kainino@chromium.org> Cr-Commit-Position: refs/heads/master@{#604612} [modify] https://crrev.com/1f40f2ee77633472981b39b41b21da368208a970/DEPS
,
Nov 1
The latest MIPS build went past the previous point so it seems to have recovered.
,
Nov 2
Thanks for the quick response and for fixing the build issue.
,
Nov 5
Building dawn in Chrome stuck. Marking this as fixed. |
||||||||
►
Sign in to add a comment |
||||||||
Comment 1 by bugdroid1@chromium.org
, Aug 7