New issue
Advanced search Search tips

Issue 870744 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug
Flaky-Test: SitePerProcessHitTestBrowserTest.RootWindowTransform/0



Sign in to add a comment

SitePerProcessHitTestBrowserTest.RootWindowTransform/0 is Flaky

Project Member Reported by Findit, Aug 3

Issue description

Cc: riajiang@chromium.org
Components: Internals>Core Tests>Flaky
Hi riajiang@, could you see if the July 19th change above could be responsible for the flakiness?
Cc: -riajiang@chromium.org
Owner: riajiang@chromium.org
Status: Assigned (was: Available)
 Issue 871321  has been merged into this issue.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 7

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/ac13eb1b044a0b4a75fdcb2545d79156fe554f74

commit ac13eb1b044a0b4a75fdcb2545d79156fe554f74
Author: Rune Lillesveen <futhark@chromium.org>
Date: Tue Aug 07 14:14:25 2018

Disabled flaky browser test.

SitePerProcessHighDPIHitTestBrowserTest.RootWindowTransform/0 and
SitePerProcessHitTestBrowserTest.RootWindowTransform/0 are reported as
flaky. Disabling.

TBR=riajiang@chromium.org

Bug:  871321 , 870744
Change-Id: I4003753932b98f83e509dfb0bea5f69b03eb7d1e
Reviewed-on: https://chromium-review.googlesource.com/1164961
Commit-Queue: Rune Lillesveen <futhark@chromium.org>
Reviewed-by: Rune Lillesveen <futhark@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581216}
[modify] https://crrev.com/ac13eb1b044a0b4a75fdcb2545d79156fe554f74/content/browser/site_per_process_hit_test_browsertest.cc

Cc: sadrul@chromium.org
Labels: -Sheriff-Chromium
The test is disabled, nothing is left here for sheriffs.
https://chromium-review.googlesource.com/c/chromium/src/+/1172723 was landed to address some of the other flakes in SitePerProcessHitTestBrowserTest, I'll keep an eye on it to see if that can fix other flakes.
Project Member

Comment 8 by bugdroid1@chromium.org, Sep 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/1094a6a2ba925f7e708251ddd182afc2ecb97274

commit 1094a6a2ba925f7e708251ddd182afc2ecb97274
Author: W. James MacLean <wjmaclean@chromium.org>
Date: Mon Sep 10 20:44:08 2018

Tentatively re-enable SitePerProcess*HitTestBrowserTest.RootWindowTransform.

A number of changes have landed recently that may eliminate the
flakieness seen in this test. This CL re-enables the test, but feel
free to revert this if the flakes continue.

Bug: 870744
Change-Id: I859f7170dbcdd334f3e872b117d48412721b7fa0
Reviewed-on: https://chromium-review.googlesource.com/1217089
Reviewed-by: Ken Buchanan <kenrb@chromium.org>
Commit-Queue: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#590050}
[modify] https://crrev.com/1094a6a2ba925f7e708251ddd182afc2ecb97274/content/browser/site_per_process_hit_test_browsertest.cc

Sign in to add a comment