Selection should invalidate slotted nodes.
Reported by
sylvain....@gmail.com,
Aug 3
|
|||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 6.1; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/70.0.3511.0 Safari/537.36 Steps to reproduce the problem: 1. Open the test file in Chrome 70 (Canary) 2. Select with your mouse any text in "Line 1" 3. Select with your mouse any text in "Line 2" What is the expected behavior? Selection in "Line 1" should be unselected. What went wrong? The first selection is not erased Did this work before? Yes 69.0.3497.23 (Build officiel) beta (64 bits) Does this work in other browsers? N/A Chrome version: 70.0.3511.0 Channel: canary OS Version: 6.1 (Windows 7, Windows Server 2008 R2) Flash Version: Any previous selection is not erased if it is rendered in a slot (shadow tree). "Line 5" and "Line 6" are outside the slot, no problem, the previous selection is correctly erased. The Range in the Selection object is always correctly updated. It seem's to be a ui refresh issue.
,
Aug 6
Able to reproduce the issue on reported chrome version 70.0.3511.0 and on latest chrome# 70.0.3513.0 using Mac 10.12.6, Windows-10 & Ubuntu 14.04 hence providing Bisect Info Bisect Info: ================ Good build: 70.0.3500.0 Bad build: 70.0.3501.0 CHANGELOG URL: https://chromium.googlesource.com/chromium/src/+log/7a2c319459f35920f9d30941b7100c37fe414411..5d3212dab69f0b09168daaf14e3634e0a9d5ae62 Change-Id: Ib4b39c621043d5fe03f46e0ce8b4d2b972e9ed3e Reviewed-on: https://chromium-review.googlesource.com/1125709 @Yoichi Osato: Please confirm the issue and help in re-assigning if it is not related to your change. Adding ReleaseBlock-Stable as it is seems a recent break, feel free to remove it if not applicable. Thanks!
,
Aug 7
Confirmed on Version 70.0.3514.0 (Official Build) canary (64-bit). The patch changed invalidation algorithm. I'll fix it.
,
Aug 7
,
Aug 9
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6e0111a9500d75ea8af9a99a30b7d7025df4ed07 commit 6e0111a9500d75ea8af9a99a30b7d7025df4ed07 Author: Yoichi Osato <yoichio@chromium.org> Date: Thu Aug 09 08:37:35 2018 Let LayoutSelection visit children of display:content element. We stopped traversal flat tree when Node didn't have a LayoutObject but Slot elements appear in the tree w/o LayoutObject. This patch enables LayoutSelection to visit children of such elements. Bug: 870734 Cq-Include-Trybots: luci.chromium.try:linux_layout_tests_layout_ng Change-Id: Id4f7c135fceead131f37485ecb8fa326834d72c3 Reviewed-on: https://chromium-review.googlesource.com/1164724 Reviewed-by: Yoshifumi Inoue <yosin@chromium.org> Commit-Queue: Yoichi Osato <yoichio@chromium.org> Cr-Commit-Position: refs/heads/master@{#581825} [modify] https://crrev.com/6e0111a9500d75ea8af9a99a30b7d7025df4ed07/third_party/blink/renderer/core/editing/layout_selection.cc [modify] https://crrev.com/6e0111a9500d75ea8af9a99a30b7d7025df4ed07/third_party/blink/renderer/core/editing/layout_selection_test.cc
,
Aug 10
|
|||||
►
Sign in to add a comment |
|||||
Comment 1 by vamshi.kommuri@chromium.org
, Aug 6