A11y: Chrome://settings menu does not move screen reader focus to the selected option |
||||||||||||
Issue descriptionChrome: 69.0.3497.23 (Official Build) beta (64-bit) (cohort: Beta) JAWS: 2018 NVDA: 2018.2.1 Steps to repro: # With NVDA or JAWS on, visit Chrome://settings # Click on the menu button # Select an option in the menu # Use arrow keys to read the page # Notice that the screen reader is not in the selected section Expected: The heading of the selected section or first option in selected section would receive focus Actual: The menu doesn't work for screen reader users.
,
Aug 10
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/f8ac232aec054638f6bfd13c783ef7d7d32e48d6 commit f8ac232aec054638f6bfd13c783ef7d7d32e48d6 Author: Peter Kasting <pkasting@chromium.org> Date: Fri Aug 10 22:42:47 2018 Diable a flaky test on CrOS for the same reason as others on this bug. Bug: 870732 Change-Id: I0c7c7a78d7acb2e96f0d0308a758a01059628aa7 TBR: mgiuca Reviewed-on: https://chromium-review.googlesource.com/1171738 Reviewed-by: Peter Kasting <pkasting@chromium.org> Commit-Queue: Peter Kasting <pkasting@chromium.org> Cr-Commit-Position: refs/heads/master@{#582364} [modify] https://crrev.com/f8ac232aec054638f6bfd13c783ef7d7d32e48d6/chrome/browser/password_manager/password_manager_browsertest.cc
,
Aug 24
Same is true on ChromeOS
,
Sep 14
,
Sep 14
,
Sep 18
,
Sep 25
,
Sep 25
,
Oct 9
Issue 711385 has been merged into this issue.
,
Oct 12
,
Oct 12
FYI, the focus seems wrong even without a screen reader. Repro steps (see attachement as well): 1) tab to the navigation menu 2) Hint enter on some item that is further down. The contents are scrolled and the menu closes. 4) Now hit tab again Expected: Focus should continue from the current section (the one that was selected in the nav menu) Actual: The page is scrolled back to the top. I believe fixing the focus would also fix the screen reader issue in this case.
,
Oct 24
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/252d41fc0294718486be1ef7e393d74f8876f57b commit 252d41fc0294718486be1ef7e393d74f8876f57b Author: Esmael El-Moslimany <aee@chromium.org> Date: Wed Oct 24 01:09:23 2018 WebUI: cr-drawer, differeniate between cancel() and close() Bug: 870732 Change-Id: I5cb196b87d339699be8bf5a2091e7e239d38b50d Reviewed-on: https://chromium-review.googlesource.com/c/1289302 Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Cr-Commit-Position: refs/heads/master@{#602203} [modify] https://crrev.com/252d41fc0294718486be1ef7e393d74f8876f57b/chrome/browser/resources/chromeos/emulator/device_emulator_pages.js [modify] https://crrev.com/252d41fc0294718486be1ef7e393d74f8876f57b/chrome/browser/resources/md_extensions/manager.js [modify] https://crrev.com/252d41fc0294718486be1ef7e393d74f8876f57b/chrome/browser/resources/md_history/app.html [modify] https://crrev.com/252d41fc0294718486be1ef7e393d74f8876f57b/chrome/browser/resources/md_history/app.js [modify] https://crrev.com/252d41fc0294718486be1ef7e393d74f8876f57b/chrome/browser/resources/settings/settings_ui/settings_ui.js [modify] https://crrev.com/252d41fc0294718486be1ef7e393d74f8876f57b/chrome/test/data/webui/cr_elements/cr_drawer_tests.js [modify] https://crrev.com/252d41fc0294718486be1ef7e393d74f8876f57b/chrome/test/data/webui/settings/settings_ui_browsertest.js [modify] https://crrev.com/252d41fc0294718486be1ef7e393d74f8876f57b/ui/webui/resources/cr_elements/cr_drawer/BUILD.gn [modify] https://crrev.com/252d41fc0294718486be1ef7e393d74f8876f57b/ui/webui/resources/cr_elements/cr_drawer/cr_drawer.html [modify] https://crrev.com/252d41fc0294718486be1ef7e393d74f8876f57b/ui/webui/resources/cr_elements/cr_drawer/cr_drawer.js
,
Oct 26
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c23e706741a8e9ac6b99c9bf57830184afca3cec commit c23e706741a8e9ac6b99c9bf57830184afca3cec Author: Esmael El-Moslimany <aee@chromium.org> Date: Fri Oct 26 04:22:35 2018 Settings WebUI: focus on section instead of container The container was given focus so that after the menu (dialog) closed, the settings would regain focus and to allow arrow keys to update the scroll position. This introduced the regression that pressing tab moves focus to the first control (as well as https://crbug.com/708960 and https://crbug.com/709359 which are fixed in subsequent CLs). This CL adds a condition that if a section was selected, it will gain focus, otherwise the container gains focus, as was the preexisting fix for https://crbug.com/707106 and related changes that closely followed. Bug: 870732 Change-Id: Ic0ae5b44f2778a56999297018427a9fda9f19eb1 Reviewed-on: https://chromium-review.googlesource.com/c/1284064 Commit-Queue: Esmael El-Moslimany <aee@chromium.org> Reviewed-by: Demetrios Papadopoulos <dpapad@chromium.org> Cr-Commit-Position: refs/heads/master@{#602990} [modify] https://crrev.com/c23e706741a8e9ac6b99c9bf57830184afca3cec/chrome/browser/resources/settings/about_page/about_page.js [modify] https://crrev.com/c23e706741a8e9ac6b99c9bf57830184afca3cec/chrome/browser/resources/settings/basic_page/basic_page.js [modify] https://crrev.com/c23e706741a8e9ac6b99c9bf57830184afca3cec/chrome/browser/resources/settings/settings_main/settings_main.js [modify] https://crrev.com/c23e706741a8e9ac6b99c9bf57830184afca3cec/chrome/browser/resources/settings/settings_page/main_page_behavior.js [modify] https://crrev.com/c23e706741a8e9ac6b99c9bf57830184afca3cec/chrome/browser/resources/settings/settings_page/settings_section.html [modify] https://crrev.com/c23e706741a8e9ac6b99c9bf57830184afca3cec/chrome/browser/resources/settings/settings_page/settings_section.js [modify] https://crrev.com/c23e706741a8e9ac6b99c9bf57830184afca3cec/chrome/browser/resources/settings/settings_ui/settings_ui.html [modify] https://crrev.com/c23e706741a8e9ac6b99c9bf57830184afca3cec/chrome/browser/resources/settings/settings_ui/settings_ui.js [modify] https://crrev.com/c23e706741a8e9ac6b99c9bf57830184afca3cec/chrome/test/data/webui/settings/settings_ui_browsertest.js
,
Oct 26
,
Nov 8
Issue 902202 has been merged into this issue.
,
Nov 13
Fixed as of 72.0.3608.4 (Official Build) canary (64-bit) (cohort: Clang-64) |
||||||||||||
►
Sign in to add a comment |
||||||||||||
Comment 1 by leberly@chromium.org
, Aug 10