New issue
Advanced search Search tips

Issue 870726 link

Starred by 3 users

Issue metadata

Status: Fixed
Owner:
Closed: Sep 18
Cc:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome
Pri: 3
Type: Bug



Sign in to add a comment

Autoscroll does not work after direction change on a fully scrolled element.

Project Member Reported by sahel@chromium.org, Aug 3

Issue description

What steps will reproduce the problem?
(1) Navigate to a URL that has scrollable elements.
(2) Middle click autoscroll on one of the elements and wait till the element is fully scrolled.
(3) Now move the mouse to change the direction of autoscroll

What is the expected result?
Autoscrolling should work in the new direction.

What happens instead?
Autoscrolling does not work in the new direction.


 
I confirm: once end of scrollable element is reached (e.g. top or bottom of page) using autoscroll, it stops working as expected. Cursor still has the autoscroll image, but behaves like normal mouse.

This even happens without any scrolling - if you point the scroll arrow sideways on non-side scrollable window the behavior is the same.
Cc: sahel@chromium.org
 Issue 883152  has been merged into this issue.
Project Member

Comment 4 by bugdroid1@chromium.org, Sep 17

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bdaa29eb9df18cdd6c9b9819dd0438b0eb1deef9

commit bdaa29eb9df18cdd6c9b9819dd0438b0eb1deef9
Author: Sahel Sharify <sahel@chromium.org>
Date: Mon Sep 17 17:42:25 2018

Autoscroll works after direction change on a fully scrolled element.

Without this fix autoscrolling would not work if you start a middle
click autoscroll on a page, wait for it to fully scroll and then
move the mouse to change the direction of the autoscrolling.

The fix excludes GSUs with autoscroll source from overscroll handling
logic.

Bug:  870726 
Test: AutoscrollBrowserTest.AutoscrollDirectionChangeAfterFullyScrolled
Change-Id: Ib54abf6b7e0fb1fbeab46b0bc93e9aec4d708029
Reviewed-on: https://chromium-review.googlesource.com/1162268
Reviewed-by: Timothy Dresser <tdresser@chromium.org>
Reviewed-by: Dave Tapuska <dtapuska@chromium.org>
Commit-Queue: Sahel Sharify <sahel@chromium.org>
Cr-Commit-Position: refs/heads/master@{#591729}
[modify] https://crrev.com/bdaa29eb9df18cdd6c9b9819dd0438b0eb1deef9/content/browser/renderer_host/input/autoscroll_browsertest.cc
[modify] https://crrev.com/bdaa29eb9df18cdd6c9b9819dd0438b0eb1deef9/content/browser/renderer_host/overscroll_controller.cc

Status: Fixed (was: Started)
I wonder if the test has some bug. It just failed randomly in CQ. Opened https://crbug.com/887879 for it.

Sign in to add a comment