Findit has detected flake occurrences for the test USS/TwoClientBookmarksSyncTestIncludingUssTests.MC_NonEmptyFolderNameChangeAndDeletionConflict/0 Culprit (100.0% confidence): https://chromium-review.googlesource.com/q/I50a85bde068dd9414e4e22bc1a33529fb3dfffa1 Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyigILEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLTAWNocm9taXVtLm1lbW9yeS9MaW51eCBNU2FuIFRlc3RzLzExMDUxL25vdF9zaXRlX3Blcl9wcm9jZXNzX3N5bmNfaW50ZWdyYXRpb25fdGVzdHMvVlZOVEwxUjNiME5zYVdWdWRFSnZiMnR0WVhKcmMxTjVibU5VWlhOMFNXNWpiSFZrYVc1blZYTnpWR1Z6ZEhNdVRVTmZUbTl1Ulcxd2RIbEdiMnhrWlhKT1lXMWxRMmhoYm1kbFFXNWtSR1ZzWlhScGIyNURiMjVtYkdsamRDOHcMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Please revert the culprit, or disable the test and find the appropriate owner. https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20USS/TwoClientBookmarksSyncTestIncludingUssTests.MC_NonEmptyFolderNameChangeAndDeletionConflict/0&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyigILEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLTAWNocm9taXVtLm1lbW9yeS9MaW51eCBNU2FuIFRlc3RzLzExMDUxL25vdF9zaXRlX3Blcl9wcm9jZXNzX3N5bmNfaW50ZWdyYXRpb25fdGVzdHMvVlZOVEwxUjNiME5zYVdWdWRFSnZiMnR0WVhKcmMxTjVibU5VWlhOMFNXNWpiSFZrYVc1blZYTnpWR1Z6ZEhNdVRVTmZUbTl1Ulcxd2RIbEdiMnhrWlhKT1lXMWxRMmhoYm1kbFFXNWtSR1ZzWlhScGIyNURiMjVtYkdsamRDOHcMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA
Findit identified the culprit r580436 with confidence 100.0% in the config "chromium.memory / Linux MSan Tests" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyigILEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLTAWNocm9taXVtLm1lbW9yeS9MaW51eCBNU2FuIFRlc3RzLzExMDUxL25vdF9zaXRlX3Blcl9wcm9jZXNzX3N5bmNfaW50ZWdyYXRpb25fdGVzdHMvVlZOVEwxUjNiME5zYVdWdWRFSnZiMnR0WVhKcmMxTjVibU5VWlhOMFNXNWpiSFZrYVc1blZYTnpWR1Z6ZEhNdVRVTmZUbTl1Ulcxd2RIbEdiMnhrWlhKT1lXMWxRMmhoYm1kbFFXNWtSR1ZzWlhScGIyNURiMjVtYkdsamRDOHcMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA If the culprit above is wrong, please file a bug using this link and hit submit: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20USS/TwoClientBookmarksSyncTestIncludingUssTests.MC_NonEmptyFolderNameChangeAndDeletionConflict/0&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyigILEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCLTAWNocm9taXVtLm1lbW9yeS9MaW51eCBNU2FuIFRlc3RzLzExMDUxL25vdF9zaXRlX3Blcl9wcm9jZXNzX3N5bmNfaW50ZWdyYXRpb25fdGVzdHMvVlZOVEwxUjNiME5zYVdWdWRFSnZiMnR0WVhKcmMxTjVibU5VWlhOMFNXNWpiSFZrYVc1blZYTnpWR1Z6ZEhNdVRVTmZUbTl1Ulcxd2RIbEdiMnhrWlhKT1lXMWxRMmhoYm1kbFFXNWtSR1ZzWlhScGIyNURiMjVtYkdsamRDOHcMCxITTWFzdGVyRmxha2VBbmFseXNpcxgBDA Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/c0439d22bf577600fde02f6d4919da679224447e commit c0439d22bf577600fde02f6d4919da679224447e Author: Balazs Engedy <engedy@chromium.org> Date: Fri Aug 03 11:55:53 2018 Revert "Reland "[Sync::USS] Bookmark sync conflict resolution"" This reverts commit a445460b34772c35f3c43b76a8c08177d70fda1d. Reason for revert: MSAN warning in USS/TwoClientBookmarksSyncTestIncludingUssTests.CreateSyncedBookmarks See: https://ci.chromium.org/p/chromium/builders/luci.chromium.ci/Linux%20MSan%20Tests/11051 https://chromium-swarm.appspot.com/task?id=3f17cf427082ec10&refresh=10&show_raw=1 Original change's description: > Reland "[Sync::USS] Bookmark sync conflict resolution" > > This is a reland of 553ec6dab428099a9b73418e016c68f4d45edbf8 > > Original change's description: > > [Sync::USS] Bookmark sync conflict resolution > > > > This patch addresses the problem of conflict in bookmarks upon > > receiving a remote update for a node that has local changes. > > > > The general polic that is implemented is that server wins except in > > case of deletion. > > > > Bug: 516866 > > Change-Id: I50a85bde068dd9414e4e22bc1a33529fb3dfffa1 > > Reviewed-on: https://chromium-review.googlesource.com/1157006 > > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > > Cr-Commit-Position: refs/heads/master@{#580436} > > Bug: 516866 > Change-Id: I73bb31e143aa7baadd5fa8c0afd3d91554c9aa6e > Reviewed-on: https://chromium-review.googlesource.com/1161861 > Reviewed-by: Mikel Astiz <mastiz@chromium.org> > Commit-Queue: Mohamed Amir Yosef <mamir@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580496} TBR=mastiz@chromium.org,mamir@chromium.org Change-Id: I22a2a0f518fdbefe7baa3c4840884090459e62a3 No-Presubmit: true No-Tree-Checks: true No-Try: true Bug: 516866, 870668 Reviewed-on: https://chromium-review.googlesource.com/1161884 Commit-Queue: Balazs Engedy <engedy@chromium.org> Reviewed-by: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580509} [modify] https://crrev.com/c0439d22bf577600fde02f6d4919da679224447e/chrome/browser/sync/test/integration/two_client_bookmarks_sync_test.cc [modify] https://crrev.com/c0439d22bf577600fde02f6d4919da679224447e/components/sync_bookmarks/bookmark_remote_updates_handler.cc [modify] https://crrev.com/c0439d22bf577600fde02f6d4919da679224447e/components/sync_bookmarks/bookmark_remote_updates_handler.h [modify] https://crrev.com/c0439d22bf577600fde02f6d4919da679224447e/components/sync_bookmarks/synced_bookmark_tracker.cc [modify] https://crrev.com/c0439d22bf577600fde02f6d4919da679224447e/components/sync_bookmarks/synced_bookmark_tracker.h [modify] https://crrev.com/c0439d22bf577600fde02f6d4919da679224447e/components/sync_bookmarks/synced_bookmark_tracker_unittest.cc
I have reverted this again, assigning it to mamir@ for permanent fix.
Test deleted
Comment 1 by Findit
, Aug 3