New issue
Advanced search Search tips

Issue 870656 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Closed: Aug 22
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 2
Type: Bug-Regression



Sign in to add a comment

Regression: Users GAIA picture is shown in toolbar even when user cancels the browser sign in.

Reported by pranjali...@etouch.net, Aug 3

Issue description

Chrome version : 70.0.3510.2 (Official Build) 19bbe7b51081dd5aca29d10d5f881cce7eb95ff8-refs/branch-heads/3510@{#4}(32/64-bit) 

OS :Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14)  and Linux(14.04 LTS)  OS

Steps to reproduce:
1. Launch chrome , click on avatar icon and click on 'sign in to chrome' button.
2. Enter valid username ,password and click on 'Next' button.
3. Now click on 'undo' button on 'You've signed in and turned on Sync' overlay .
4. Observe.

Actual Result: Users GAIA picture is shown in toolbar even when user cancels the browser sign in.
Expected Result:  Users GAIA picture should not be seen in toolbar when user cancels the browser sign in ,instead grey icon should be seen.

This is a regression issue broken in ‘M-69’ and below is bisect info.
Good build: 69.0.3479.0
Bad build: 69.0.3480.0

(Unable to narrow down the range using per-revision bisect, hence providing bisect using old script)
CHANGELOG URL:
The script might not always return single CL as suspect as some perf builds might get missing due to failure.

https://chromium.googlesource.com/chromium/src/+log/2b58507e5e94974512345db6653fde0e81593d5e..7fdc10d9c7373625982b59739b8688ec6fa87680	

Suspect: https://chromium.googlesource.com/chromium/src/+/a333057417bcd81aa5a6f6ab082f81dd8023f452

@tangltom: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.

Thank You

 
Actual Result.mp4
570 KB View Download
Expected Result.mp4
515 KB View Download
Cc: ew...@chromium.org pbos@chromium.org
Labels: -Pri-1 Pri-2
This was probably introduced with one of my or pbos@'s changes to the AvatarToolbarButton.

I just tested it on my machine. It's reproducible, but as soon as the I click the icon, it changes back. So it's probably a missing-observer issue.
I'll look into it.

Eli, how severe is this issue? I prioritized it with 2 for now.
For what it's worth, I can't reproduce this with Unity turned on.

I would view this as P2. As long as the picture eventually resets to the local avatar, that should be sufficient.

For those who are able to reproduce it: does the picture go away if you open a new tab and navigate somewhere? Or does it only go away if you click the avatar button?
Status: Started (was: Assigned)
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c2f5b2df7f21c1bc0d41ce0e0d929c2ef193e002

commit c2f5b2df7f21c1bc0d41ce0e0d929c2ef193e002
Author: Thomas Tangl <tangltom@chromium.org>
Date: Wed Aug 22 17:49:35 2018

Update avatar toolbar button when account is removed

Update the icon of the avatar toolbar button when
an account is signed out.
This happens for instance when the user selects cancel
on the sync-confirmation dialog.

Bug:  870656 
Change-Id: Id557500c02ef2ac10d704cde75a9afe9db5e7655
Reviewed-on: https://chromium-review.googlesource.com/1185195
Reviewed-by: Elly Fong-Jones <ellyjones@chromium.org>
Commit-Queue: Thomas Tangl <tangltom@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585148}
[modify] https://crrev.com/c2f5b2df7f21c1bc0d41ce0e0d929c2ef193e002/chrome/browser/ui/views/profiles/avatar_toolbar_button.cc
[modify] https://crrev.com/c2f5b2df7f21c1bc0d41ce0e0d929c2ef193e002/chrome/browser/ui/views/profiles/avatar_toolbar_button.h

Status: Fixed (was: Started)
I was a bit late on this, but should we merge this back?
From my perspective this would be totally okay since it's a very trivial change (5 lines), just listening for Account removals and updating the icon in this case.
Without your change, when does the avatar revert back? Is it only when you click on the button, or does it change back eventually by itself (e.g. if you open a new tab or navigate somewhere else)?

FWIW, I don't view this as P1, so I think it's fine to let the fix roll out in 70.
It only reverts back when you click on the button or go to chrome://settings.

However, I just checked and the only way this can happen is when the user selects "Cancel" on the sync confirmation dialog. And I can't reproduce this on Mac.

This means if we are fine that for some users on Linux and Windows this happens, we can let the fix roll out in 70.
Does it get fixed when Chrome gets restarted?

As long as it gets fixed on restart, I don't think this is worth a merge back.
Yes, restart fixes it too. Okay, then it'll be in 70.
Labels: TE-Verified-M70 TE-Verified-70.0.3532.0
Update:
Rechecked the above issue on Win(7,8,8.1,10) ,Mac(10.12.6 , 10.13.1 , 10.13.6, 10.14)  and Linux(14.04 LTS)  OS using latest canary build#70.0.3532.0 and issue is fix. Users GAIA picture disappears from toolbar when user cancels the browser sign in.

Please refer attached screencast for reference.

Thank You...
Canary Behaviour.mp4
418 KB View Download
Perfect. WAI :)

Sign in to add a comment