New issue
Advanced search Search tips
Note: Color blocks (like █ or █) mean that a user may not be available. Tooltip shows the reason.

Issue 870652 link

Starred by 3 users
Status: Fixed
Owner:
█ apaci...@chromium.org
no longer active
Closed: Aug 10
Cc:
ajha@chromium.org
jbanavatu@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression: PiP icon is missing in casting tab - MacOS

Project Member Reported by jbanavatu@chromium.org, Aug 3 
Chrome Version: 70.0.3511.0
OS:MacOS 10.13.6

What steps will reproduce the problem?
(1)Navigate to https://googlechrome.github.io/samples/picture-in-picture/
(2)Toggle to PiP mode and Observe PiP icon in casting tab.

What is the expected result?
PiP icon should be seen in casting tab.

What happens instead?
PiP icon is missing.

This is regression issue broken in M70. will provide bisect info soon.

Attaching screen-cast for reference.

Thanks!
Aug 3 2018 3_42 PM.webm
1.8 MB View Download

Comment 1 by jbanavatu@chromium.org, Aug 3

Cc: ajha@chromium.org

Comment 2 by jbanavatu@chromium.org, Aug 3

Labels: hasbisect-per-revision
Owner: apaci...@chromium.org
Status: Assigned (was: Untriaged)
Using the per-revision bisect providing the bisect results,
Good Build: 70.0.3510.0
Bad Build: 70.0.3511.0

CHANGE-LOG URL:
---------------
https://chromium.googlesource.com/chromium/src/+log/b185ae7e27babd4dda596d88aa56ecd889ab4c14..8f245415132da4dbcab74a3008e0e3c0ce65782a

From the CL above, assigning the issue to the concern owner

@ apacible: Could you please look into the issue, pardon me if it has nothing to do with your changes and if possible please assign it to concern owner.Adding RB stable for M68 please remove if not the case

Reviewed-on: https://chromium-review.googlesource.com/1159993

Thanks!

Comment 3 by jbanavatu@chromium.org, Aug 3

Labels: ReleaseBlock-Stable
Adding RB stable label.Please undo if not the case.
Note: Issue is only seen in Mac OS. Working fine in Windows10 & Debian.

Thanks!

Comment 4 by apaci...@chromium.org, Aug 3

Labels: OS-Windows
I can also repro on Win 10, but not on linux.
Project Member

Comment 5 by bugdroid1@chromium.org, Aug 8 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/aadbf55bf7f3546ddbcb72dfa692263f43c447e5

commit aadbf55bf7f3546ddbcb72dfa692263f43c447e5
Author: Jennifer Apacible <apacible@chromium.org>
Date: Wed Aug 08 18:59:12 2018

[Picture in Picture] Fix kPictureInPictureAlt icon.

This change fixes a regression where the icon is not visible on Mac
and Windows platforms.

Bug:  870652 
Change-Id: Id1649a113e13b0168f197c8e53fc91e61655bab2
Reviewed-on: https://chromium-review.googlesource.com/1166450
Reviewed-by: apacible <apacible@chromium.org>
Reviewed-by: Evan Stade <estade@chromium.org>
Commit-Queue: apacible <apacible@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581644}
[modify] https://crrev.com/aadbf55bf7f3546ddbcb72dfa692263f43c447e5/chrome/app/vector_icons/picture_in_picture_alt.icon

Comment 6 by apaci...@chromium.org, Aug 10

Status: Fixed (was: Assigned)

Comment 7 by jbanavatu@chromium.org, Aug 10

Labels: TE-Verified-M70 TE-Verified-70.0.3517.0
Able to reproduce this issue on reported version hence verifying the fix on latest canary 70.0.3517.0 using Mac 10.13.3, Windows 10 .

Now PictureInPicture icon in seen in casting tab. Attaching screenshot for reference.

As fix is working as expected adding Verified labels.

Thanks!
withfix_iconseen.png
1.1 MB View Download
Withfix_icon seen.png
213 KB View Download
►

Sign in to add a comment