New issue
Advanced search Search tips

Issue 870645 link

Starred by 2 users
Status: Verified
Owner:
rbpotter@chromium.org
Closed: Aug 16
Cc:
nyerramilli@chromium.org
rbasuvula@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Mac
Pri: 1
Type: Bug-Regression



Sign in to add a comment

Regression : Font size of "More settings" option doesn't change according to the default font size set in chrome://settings.

Reported by avsha...@etouch.net, Aug 3 
Chrome Version : 70.0.3510.2 (Official Build) 19bbe7b51081dd5aca29d10d5f881cce7eb95ff8-refs/branch-heads/3510@{#4} 32/64 bit
OS : Windows (7, 8, 8.1, 10)

Precondition : Please enable "#enable-new-print-preview" flag from chrome://flags.

What steps will reproduce the problem?
1. Launch chrome, enable above flag and relaunch Chrome.
2. Navigate to chrome://settings page and set 'Font size' to 'Very small'.
3. Hit 'Ctrl + P' and observe the "More settings" option in print preview.

Actual Result : Font size of "More settings" option doesn't change according to the default font size set in chrome://settings.

Expected Result : Font size of "More settings" option should change as per the font size set in chrome://settings page.

This is a regression issue broken in ‘M-70’ and will soon update remaining info.
Good Build : 70.0.3502.3 (Revision : 577760)
Bad Build : 70.0.3503.0 (Revision : 578159)
Actual_Result.mp4
1006 KB View Download
Expected_Result.mp4
871 KB View Download

Comment 1 by avsha...@etouch.net, Aug 3

Labels: hasbisect-per-revision RegressedIn-70 Target-70 FoundIn-70 OS-Linux OS-Mac
Owner: rbpotter@chromium.org
Status: Assigned (was: Unconfirmed)
Summary: Regression : Font size of "More settings" option doesn't change according to the default font size set in chrome://settings. (was: Regression : Font size of "More settings" option doesn't change according the default font size set in chrome://settings.)
This is a regression issue broken in ‘M-70’ and below is the bisect info:
Good Build : 70.0.3502.3 (Revision : 577760)
Bad Build : 70.0.3503.0 (Revision : 578159)

Change Log URL :
https://chromium.googlesource.com/chromium/src/+log/475eede957aa3b5a8f9cf08651970948d7704efe..8d2a282ddc7d679cf0f9d0bab8dd99e40455d00b

Suspect : https://chromium.googlesource.com/chromium/src/+/8d2a282ddc7d679cf0f9d0bab8dd99e40455d00b

rbpotter@ : Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Note : 
1. This issue is also observed in latest Canary build #70.0.3511.0
2. Issue also reproduce in Linux(14.04 LTS) and Mac(10.12.6, 10.13.1, 10.13.6, 10.14) OS

Thank You..!

Comment 2 by rbpotter@chromium.org, Aug 14

Status: Started (was: Assigned)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 14 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e39cbb553a9b9cabbcc77d0a29b1f7e208e192f5

commit e39cbb553a9b9cabbcc77d0a29b1f7e208e192f5
Author: rbpotter <rbpotter@chromium.org>
Date: Tue Aug 14 18:47:48 2018

Print Preview: Inherit font size and family in more settings

Changing more settings to a button that does not use the default styles
in print_preview/new/button_css.html removed the font: inherit styling.
Restore it.

Bug:  870645 
Change-Id: Ic041c065f3d0f6d249a6817b740a8acaf963d38f
Reviewed-on: https://chromium-review.googlesource.com/1162079
Commit-Queue: Rebekah Potter <rbpotter@chromium.org>
Reviewed-by: Scott Chen <scottchen@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582985}
[modify] https://crrev.com/e39cbb553a9b9cabbcc77d0a29b1f7e208e192f5/chrome/browser/resources/print_preview/new/more_settings.html

Comment 4 by avsha...@etouch.net, Aug 16

Labels: TE-Verified-M70 TE-Verified-70.0.3524.0
Update :
Tested above issue in latest Canary build #70.0.3524.0 on Mac(10.12.6, 10.13.1 ,10.13.6, 10.14), Windows (7, 8, 8.1, 10) and Linux(14.04 LTS) OS and the issue is fixed. 
'More settings' option now changes according to the default font size set in chrome://settings, hence adding TE-Verified labels. Kindly review an attached screen-cast for reference.

Thank you..!
Canary_behavior.mp4
860 KB View Download

Comment 5 by rbpotter@chromium.org, Aug 16

Status: Verified (was: Started)
►

Sign in to add a comment