New issue
Advanced search Search tips

Issue 870639 link

Starred by 2 users

Issue metadata

Status: Verified
Owner: ----
Closed: Jan 3
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Mac
Pri: 1
Type: Bug
Team-Accessibility



Sign in to add a comment

Null-dereference READ in blink::ComputedAccessibleNodePromiseResolver::UpdateTreeAndResolve

Project Member Reported by ClusterFuzz, Aug 3

Issue description

Detailed report: https://clusterfuzz.com/testcase?key=4970616533549056

Fuzzer: inferno_twister
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000048
Crash State:
  blink::ComputedAccessibleNodePromiseResolver::UpdateTreeAndResolve
  blink::FrameRequestCallbackCollection::ExecuteCallbacks
  blink::ScriptedAnimationController::ExecuteCallbacks
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=538677:538682

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4970616533549056

Issue filed automatically.

See https://github.com/google/clusterfuzz-tools for more information.
 
Project Member

Comment 1 by ClusterFuzz, Aug 3

Components: Blink>DOM
Labels: Test-Predator-Auto-Components
Automatically applying components based on crash stacktrace and information from OWNERS files.

If this is incorrect, please apply the Test-Predator-Wrong-Components label.
Project Member

Comment 2 by ClusterFuzz, Aug 3

Cc: meredithl@google.com
Labels: Test-Predator-Auto-CC
Automatically adding ccs based on suspected regression changelists:

Refactors ensureUpToDate to use rAF callback. by meredithl@google.com - https://chromium.googlesource.com/chromium/src/+/e35fb3af9c9e2ce800e8f5c9bca93cb650c6f738

If this is incorrect, please let us know why and apply the Test-Predator-Wrong-CLs label.
Cc: -meredithl@google.com
Components: -Blink>DOM Blink>Accessibility
Labels: -Test-Predator-Auto-CC Test-Predator-Wrong-Components
Project Member

Comment 4 by ClusterFuzz, Aug 5

Labels: OS-Mac
Cc: kkaluri@chromium.org
Labels: Test-Predator-Wrong-CLs M-69
Owner: mustaq@chromium.org
Status: Assigned (was: Untriaged)
Predator and CL could not provide any possible suspects.

Using Code Search for the file, "computed_accessible_node.cc" suspecting the below Cl might have caused this issue

Suspect CL: https://chromium.googlesource.com/chromium/src/+/55944cb91cc262f2c7ea016f0267ad974d876d05

mustaq@ -- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Owner: ----
Status: Untriaged (was: Assigned)
The CL mentioned in #c5 is a pure code health CL, doesn't change any functionality.
Owner: smcgruer@chromium.org
Status: Assigned (was: Untriaged)

Using Code Search for the file, "scripted_animation_controller.cc" suspecting the below Cl might have caused this issue

Suspect CL: https://chromium.googlesource.com/chromium/src/+/914837266739366e49adda8275450383ddebd607

smcgruer@ -- Could you please check whether this is caused with respect to your change, if not please help us in assigning it to the right owner.

Thanks!
Cc: haraken@chromium.org aboxhall@chromium.org
Owner: ----
Status: Available (was: Assigned)
My CL is almost definitely unrelated, it just changes some time values unrelated to this stack. From the stack, it appears likely that WebLocalFrameImpl::FromFrame is returning nullptr at https://cs.chromium.org/chromium/src/third_party/blink/renderer/core/aom/computed_accessible_node.cc?l=87&rcl=04add8c6cd47cbac836956d9db9d15ea64d34855

It looks like the person who landed this code has left, so cc the reviewers from https://chromium-review.googlesource.com/c/chromium/src/+/931301 to see if they know who should own this.
Project Member

Comment 9 by ClusterFuzz, Jan 3

ClusterFuzz has detected this issue as fixed in range 619628:619629.

Detailed report: https://clusterfuzz.com/testcase?key=4970616533549056

Fuzzer: inferno_twister
Job Type: linux_asan_content_shell_drt
Platform Id: linux

Crash Type: Null-dereference READ
Crash Address: 0x000000000048
Crash State:
  blink::ComputedAccessibleNodePromiseResolver::UpdateTreeAndResolve
  blink::FrameRequestCallbackCollection::ExecuteCallbacks
  blink::ScriptedAnimationController::ExecuteCallbacks
  
Sanitizer: address (ASAN)

Regressed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=538677:538682
Fixed: https://clusterfuzz.com/revisions?job=linux_asan_content_shell_drt&range=619628:619629

Reproducer Testcase: https://clusterfuzz.com/download?testcase_id=4970616533549056

See https://github.com/google/clusterfuzz-tools for instructions to reproduce this bug locally.

If you suspect that the result above is incorrect, try re-doing that job on the test case report page.
Project Member

Comment 10 by ClusterFuzz, Jan 3

Labels: ClusterFuzz-Verified
Status: Verified (was: Available)
ClusterFuzz testcase 4970616533549056 is verified as fixed, so closing issue as verified.

If this is incorrect, please add ClusterFuzz-Wrong label and re-open the issue.

Sign in to add a comment