Findit has detected flake occurrences for the test WebRtcDataBrowserTest.CanSetupLegacyCall Culprit (90.9% confidence): https://chromium-review.googlesource.com/q/I5d200862e81809af793d28b7751729a1824be76c Analysis: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyrgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ4Y2hyb21pdW0ubWFjL01hYzEwLjEzIFRlc3RzIChkYmcpLzQ0NDgvdml6X2NvbnRlbnRfYnJvd3NlcnRlc3RzL1YyVmlVblJqUkdGMFlVSnliM2R6WlhKVVpYTjBMa05oYmxObGRIVndUR1ZuWVdONVEyRnNiQT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Please revert the culprit, or disable the test and find the appropriate owner. https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20WebRtcDataBrowserTest.CanSetupLegacyCall&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyrgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ4Y2hyb21pdW0ubWFjL01hYzEwLjEzIFRlc3RzIChkYmcpLzQ0NDgvdml6X2NvbnRlbnRfYnJvd3NlcnRlc3RzL1YyVmlVblJqUkdGMFlVSnliM2R6WlhKVVpYTjBMa05oYmxObGRIVndUR1ZuWVdONVEyRnNiQT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw
Findit identified the culprit r580378 with confidence 90.9% in the config "chromium.mac / Mac10.13 Tests (dbg)" based on the flakiness trend: https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyrgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ4Y2hyb21pdW0ubWFjL01hYzEwLjEzIFRlc3RzIChkYmcpLzQ0NDgvdml6X2NvbnRlbnRfYnJvd3NlcnRlc3RzL1YyVmlVblJqUkdGMFlVSnliM2R6WlhKVVpYTjBMa05oYmxObGRIVndUR1ZuWVdONVEyRnNiQT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw If the culprit above is wrong, please file a bug using this link and hit submit: https://bugs.chromium.org/p/chromium/issues/entry?status=Unconfirmed&labels=Pri-1,Test-Findit-Wrong&components=Tools%3ETest%3EFindit%3EFlakiness&summary=%5BFindit%5D%20Flake%20Analyzer%20-%20Wrong%20result%20for%20WebRtcDataBrowserTest.CanSetupLegacyCall&comment=Link%20to%20Analysis%3A%20https://findit-for-me.appspot.com/waterfall/flake?key=ag9zfmZpbmRpdC1mb3ItbWVyrgELEhdNYXN0ZXJGbGFrZUFuYWx5c2lzUm9vdCJ4Y2hyb21pdW0ubWFjL01hYzEwLjEzIFRlc3RzIChkYmcpLzQ0NDgvdml6X2NvbnRlbnRfYnJvd3NlcnRlc3RzL1YyVmlVblJqUkdGMFlVSnliM2R6WlhKVVpYTjBMa05oYmxObGRIVndUR1ZuWVdONVEyRnNiQT09DAsSE01hc3RlckZsYWtlQW5hbHlzaXMYAQw Automatically posted by the findit-for-me app (https://goo.gl/Ot9f7N).
Prepared revert CL: https://chromium-review.googlesource.com/c/chromium/src/+/1162021
See the flakiness dashboard: https://test-results.appspot.com/dashboards/flakiness_dashboard.html#testType=browser_tests%20(with%20patch)&tests=WebViewFocusBrowserPluginSpecificTest.TouchFocusesEmbedder
Issue 870703 has been merged into this issue.
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/6ca8d893b8fde5f896760dc0c09e1f5009db064c commit 6ca8d893b8fde5f896760dc0c09e1f5009db064c Author: Balazs Engedy <engedy@chromium.org> Date: Fri Aug 03 13:32:31 2018 Revert "Convert P2P IPCs to Mojo." This reverts commit 5dc35e997fc12e292128ae2e9af77f0355e9fcbc. Reason for revert: Causes content_browsertests / WebRtcDataBrowserTest.CanSetupLegacyCall to run on a DCHECK failure on fake_audio_input_stream.cc:69. Original change's description: > Convert P2P IPCs to Mojo. > > Bug: 800212 > Cq-Include-Trybots: luci.chromium.try:linux_mojo > Change-Id: I5d200862e81809af793d28b7751729a1824be76c > Reviewed-on: https://chromium-review.googlesource.com/1156566 > Commit-Queue: John Abd-El-Malek <jam@chromium.org> > Reviewed-by: Sergey Ulanov <sergeyu@chromium.org> > Reviewed-by: Nasko Oskov <nasko@chromium.org> > Cr-Commit-Position: refs/heads/master@{#580378} Bug: 870633 TBR=nasko@chromium.org,jam@chromium.org,sergeyu@chromium.org Change-Id: I6b2e278433dc18f8fa49281bf0f7e2bf2c278cd2 Bug: 800212 Cq-Include-Trybots: luci.chromium.try:linux_mojo Reviewed-on: https://chromium-review.googlesource.com/1162021 Reviewed-by: Balazs Engedy <engedy@chromium.org> Commit-Queue: Balazs Engedy <engedy@chromium.org> Cr-Commit-Position: refs/heads/master@{#580525} [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/chrome/common/common_message_generator.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/browser/renderer_host/p2p/socket_dispatcher_host.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/browser/renderer_host/p2p/socket_dispatcher_host.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/browser/renderer_host/p2p/socket_host.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/browser/renderer_host/p2p/socket_host.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/browser/renderer_host/p2p/socket_host_tcp.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/browser/renderer_host/p2p/socket_host_tcp.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/browser/renderer_host/p2p/socket_host_tcp_server.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/browser/renderer_host/p2p/socket_host_tcp_server.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/browser/renderer_host/p2p/socket_host_tcp_server_unittest.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/browser/renderer_host/p2p/socket_host_tcp_unittest.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/browser/renderer_host/p2p/socket_host_test_utils.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/browser/renderer_host/p2p/socket_host_test_utils.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/browser/renderer_host/p2p/socket_host_udp.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/browser/renderer_host/p2p/socket_host_udp.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/browser/renderer_host/p2p/socket_host_udp_unittest.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/browser/renderer_host/render_process_host_impl.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/common/BUILD.gn [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/common/content_message_generator.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/common/native_types.typemap [add] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/common/p2p_messages.h [rename] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/common/p2p_socket_type.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/public/app/mojo/content_browser_manifest.json [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/public/common/common_param_traits.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/public/common/common_param_traits.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/public/common/common_param_traits_macros.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/renderer/media/webrtc/peer_connection_dependency_factory.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/renderer/p2p/host_address_request.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/renderer/p2p/host_address_request.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/renderer/p2p/ipc_socket_factory.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/renderer/p2p/socket_client.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/renderer/p2p/socket_client_delegate.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/renderer/p2p/socket_client_impl.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/renderer/p2p/socket_client_impl.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/renderer/p2p/socket_dispatcher.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/renderer/p2p/socket_dispatcher.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/content/renderer/render_thread_impl.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/net/interfaces/ip_address_struct_traits.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/net/interfaces/ip_endpoint_struct_traits.cc [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/services/network/public/cpp/BUILD.gn [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/services/network/public/cpp/DEPS [delete] https://crrev.com/3d642660a22e0cfe35bc4502c9c26e9c00f60862/services/network/public/cpp/p2p.typemap [delete] https://crrev.com/3d642660a22e0cfe35bc4502c9c26e9c00f60862/services/network/public/cpp/p2p_param_traits.cc [delete] https://crrev.com/3d642660a22e0cfe35bc4502c9c26e9c00f60862/services/network/public/cpp/p2p_param_traits.h [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/services/network/public/cpp/typemaps.gni [modify] https://crrev.com/6ca8d893b8fde5f896760dc0c09e1f5009db064c/services/network/public/mojom/BUILD.gn [delete] https://crrev.com/3d642660a22e0cfe35bc4502c9c26e9c00f60862/services/network/public/mojom/p2p.mojom
Comment 1 by Findit
, Aug 3