The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/97436f6adc3d8e54b2832f6f0eb8178aeda13771

commit 97436f6adc3d8e54b2832f6f0eb8178aeda13771
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Fri Aug 03 12:46:16 2018

[Android] Talkback strings for keyboard accessory

The descriptions of password suggestions are now loaded and read by
Talkback (e.g. "Password for m.park@gmail.com") to uniquely identify the
single list entries.

The key icon now indicates that it toggles the password bottom sheet.

Bug:  870627 
Change-Id: I2efce0c5eea06cab16702cc817f0c081af459aa6
Reviewed-on: https://chromium-review.googlesource.com/1161909
Reviewed-by: Bernhard Bauer <bauerb@chromium.org>
Commit-Queue: Friedrich Horschig <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580518}
[modify] https://crrev.com/97436f6adc3d8e54b2832f6f0eb8178aeda13771/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java
[modify] https://crrev.com/97436f6adc3d8e54b2832f6f0eb8178aeda13771/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewBinder.java
[modify] https://crrev.com/97436f6adc3d8e54b2832f6f0eb8178aeda13771/chrome/android/java/strings/android_chrome_strings.grd
[add] https://crrev.com/97436f6adc3d8e54b2832f6f0eb8178aeda13771/chrome/android/java/strings/android_chrome_strings_grd/IDS_PASSWORD_ACCESSORY_SHEET_TOGGLE.png.sha1

Thanks! I tried this out on latest M70 build. 

I still see following issues with Accessibility / talkback:

1. When double tapped in the password field, only "showing qwerty keyboard" is announced. There is no announcement about the keyboard accessory being shown.

2. The key icon still doesn't have have any name and just announces "Selected. Tap to toggle...". Can we get add a name?

3. when double tapped it just says 'keyboard hidden'. It would be helpful if it announces that the password list is being displayed.

Note: These issues are blocking me from completing the GAR sheet as they don't follow the GAR guidelines.

Thanks for the investigation! I'll have a look.

Some clarifications:

1. is indeed very unintended - my test was wrong, so I (and other testers) always  heard "password keyboard shown" which is actually a two part statement of something else: "password" (because a password might be entered) and "keyboard shown" (because the keyboard came up ... I will definitely add a new, dedicated string - as mentioned in issue 838387.

2. That's a half-true. The name of the icon is "Tap to toggle between password suggestions and keyboard". I see how this can be misleading and will change it so it describes better what it is and less what it does. (Again, the writing of the spoken text would be "Selected 'Tap to toggle...'" - the word "Selected doesn't stand alone).

3. Sounds useful.

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e94d3067b1b9f0c2948a0286e2431e6bcb420142

commit e94d3067b1b9f0c2948a0286e2431e6bcb420142
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Thu Sep 06 17:04:28 2018

[Android] Improve keyboard accessory labels for accessibility

This CL improves accessibility based on feedback of  issue 870627  and
mocks from issue 838387:
1. The keyboard accessory is announced when made visible (string [1]).
Before this CL, android:clickable=true was used to prevent clicks
from propagating to the content area behind it. This caused Talkback
to read "double-tap to activate". This is gone now, by setting the
appropriate listeners when initializing the layout.

2. The key icon's name changed to "Show passwords" (string [4]). Once
triggered, it changes to "Show keyboard" (string [2]) in accordance to
what it does.

3. An opened password sheet is immediately announced with string [3]:
"Showing saved passwords and password options".

4. The title ("Saved passwords for XYZ") doesn't read "Double-tap to
activate" anymore.

5. Disabled entries (e.g. password entries when email fields are
focused) are now read back with the proper "Disabled" suffix.


Uploaded pictures for the new hashes (because there is no way to
download them anywhere):
[1] IDS_AUTOFILL_KEYBOARD_ACCESSORY_CONTENT_DESCRIPTION:
https://photos.app.goo.gl/kiYYx8tzyjfPB7oA7

[2] IDS_KEYBOARD_ACCESSORY_SHEET_HIDE:
https://photos.app.goo.gl/RxuGqCZp6QtmNLUJ9

[3] IDS_PASSWORD_ACCESSORY_SHEET_OPENED:
https://photos.app.goo.gl/NBpw2HavFSiZ5NSq8

[4] IDS_PASSWORD_ACCESSORY_SHEET_TOGGLE:
https://photos.app.goo.gl/fMprsLC8Y8giAdxF7

Bug:  870627 , 838387
Change-Id: Iebccefa8d5ede702b8bdc2dc92f055064981fa80
Reviewed-on: https://chromium-review.googlesource.com/1209405
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/heads/master@{#589199}
[modify] https://crrev.com/e94d3067b1b9f0c2948a0286e2431e6bcb420142/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetViewBinder.java
[modify] https://crrev.com/e94d3067b1b9f0c2948a0286e2431e6bcb420142/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryData.java
[modify] https://crrev.com/e94d3067b1b9f0c2948a0286e2431e6bcb420142/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryView.java
[modify] https://crrev.com/e94d3067b1b9f0c2948a0286e2431e6bcb420142/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewBinder.java
[modify] https://crrev.com/e94d3067b1b9f0c2948a0286e2431e6bcb420142/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java
[modify] https://crrev.com/e94d3067b1b9f0c2948a0286e2431e6bcb420142/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewBinder.java
[modify] https://crrev.com/e94d3067b1b9f0c2948a0286e2431e6bcb420142/chrome/android/java/strings/android_chrome_strings.grd
[add] https://crrev.com/e94d3067b1b9f0c2948a0286e2431e6bcb420142/chrome/android/java/strings/android_chrome_strings_grd/IDS_AUTOFILL_KEYBOARD_ACCESSORY_CONTENT_DESCRIPTION.png.sha1
[add] https://crrev.com/e94d3067b1b9f0c2948a0286e2431e6bcb420142/chrome/android/java/strings/android_chrome_strings_grd/IDS_KEYBOARD_ACCESSORY_SHEET_HIDE.png.sha1
[add] https://crrev.com/e94d3067b1b9f0c2948a0286e2431e6bcb420142/chrome/android/java/strings/android_chrome_strings_grd/IDS_PASSWORD_ACCESSORY_SHEET_OPENED.png.sha1
[modify] https://crrev.com/e94d3067b1b9f0c2948a0286e2431e6bcb420142/chrome/android/java/strings/android_chrome_strings_grd/IDS_PASSWORD_ACCESSORY_SHEET_TOGGLE.png.sha1

It probably makes sense to merge this into 70 to gather feedback. It's also not too intrusive. Any conflicting opinions or good reasons not to?

This bug requires manual review: There is .grd file changes and we are only 38 days from stable.
Please contact the milestone owner if you have questions.
Owners: benmason@(Android), kariahda@(iOS), geohsu@(ChromeOS), abdulsyed@(Desktop)

For more details visit https://www.chromium.org/issue-tracking/autotriage - Your friendly Sheriffbot

Approved for merge into 70, branch 3538.

Updating the same as in issue 838387.
tried out the fix in #33 in 71.0.3545.0. Looks good. Thanks!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/436299f08ce4c0aa54d050208c5c706e1da0154c

commit 436299f08ce4c0aa54d050208c5c706e1da0154c
Author: Friedrich Horschig <fhorschig@chromium.org>
Date: Mon Sep 10 09:14:00 2018

[Android] Improve keyboard accessory labels for accessibility

This CL improves accessibility based on feedback of  issue 870627  and
mocks from issue 838387:
1. The keyboard accessory is announced when made visible (string [1]).
Before this CL, android:clickable=true was used to prevent clicks
from propagating to the content area behind it. This caused Talkback
to read "double-tap to activate". This is gone now, by setting the
appropriate listeners when initializing the layout.

2. The key icon's name changed to "Show passwords" (string [4]). Once
triggered, it changes to "Show keyboard" (string [2]) in accordance to
what it does.

3. An opened password sheet is immediately announced with string [3]:
"Showing saved passwords and password options".

4. The title ("Saved passwords for XYZ") doesn't read "Double-tap to
activate" anymore.

5. Disabled entries (e.g. password entries when email fields are
focused) are now read back with the proper "Disabled" suffix.

Uploaded pictures for the new hashes (because there is no way to
download them anywhere):
[1] IDS_AUTOFILL_KEYBOARD_ACCESSORY_CONTENT_DESCRIPTION:
https://photos.app.goo.gl/kiYYx8tzyjfPB7oA7

[2] IDS_KEYBOARD_ACCESSORY_SHEET_HIDE:
https://photos.app.goo.gl/RxuGqCZp6QtmNLUJ9

[3] IDS_PASSWORD_ACCESSORY_SHEET_OPENED:
https://photos.app.goo.gl/NBpw2HavFSiZ5NSq8

[4] IDS_PASSWORD_ACCESSORY_SHEET_TOGGLE:
https://photos.app.goo.gl/fMprsLC8Y8giAdxF7

(cherry picked from commit e94d3067b1b9f0c2948a0286e2431e6bcb420142)

Bug:  870627 , 838387
Change-Id: Iebccefa8d5ede702b8bdc2dc92f055064981fa80
Reviewed-on: https://chromium-review.googlesource.com/1209405
Reviewed-by: Ioana Pandele <ioanap@chromium.org>
Commit-Queue: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Original-Commit-Position: refs/heads/master@{#589199}
Reviewed-on: https://chromium-review.googlesource.com/1215285
Reviewed-by: Friedrich Horschig [CEST] <fhorschig@chromium.org>
Cr-Commit-Position: refs/branch-heads/3538@{#204}
Cr-Branched-From: 79f7c91a2b2a2932cd447fa6f865cb6662fa8fa6-refs/heads/master@{#587811}
[modify] https://crrev.com/436299f08ce4c0aa54d050208c5c706e1da0154c/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/AccessorySheetViewBinder.java
[modify] https://crrev.com/436299f08ce4c0aa54d050208c5c706e1da0154c/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryData.java
[modify] https://crrev.com/436299f08ce4c0aa54d050208c5c706e1da0154c/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryView.java
[modify] https://crrev.com/436299f08ce4c0aa54d050208c5c706e1da0154c/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/KeyboardAccessoryViewBinder.java
[modify] https://crrev.com/436299f08ce4c0aa54d050208c5c706e1da0154c/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetCoordinator.java
[modify] https://crrev.com/436299f08ce4c0aa54d050208c5c706e1da0154c/chrome/android/java/src/org/chromium/chrome/browser/autofill/keyboard_accessory/PasswordAccessorySheetViewBinder.java
[modify] https://crrev.com/436299f08ce4c0aa54d050208c5c706e1da0154c/chrome/android/java/strings/android_chrome_strings.grd
[add] https://crrev.com/436299f08ce4c0aa54d050208c5c706e1da0154c/chrome/android/java/strings/android_chrome_strings_grd/IDS_AUTOFILL_KEYBOARD_ACCESSORY_CONTENT_DESCRIPTION.png.sha1
[add] https://crrev.com/436299f08ce4c0aa54d050208c5c706e1da0154c/chrome/android/java/strings/android_chrome_strings_grd/IDS_KEYBOARD_ACCESSORY_SHEET_HIDE.png.sha1
[add] https://crrev.com/436299f08ce4c0aa54d050208c5c706e1da0154c/chrome/android/java/strings/android_chrome_strings_grd/IDS_PASSWORD_ACCESSORY_SHEET_OPENED.png.sha1
[modify] https://crrev.com/436299f08ce4c0aa54d050208c5c706e1da0154c/chrome/android/java/strings/android_chrome_strings_grd/IDS_PASSWORD_ACCESSORY_SHEET_TOGGLE.png.sha1

Verified fix in M70 - 70.0.3538.15. Thanks