New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870617 link

Starred by 1 user

Issue metadata

Status: Assigned
Owner:
Cc:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 3
Type: Bug

Blocking:
issue 746956



Sign in to add a comment

Compile //chrome/renderer with jumbo

Project Member Reported by osc...@opera.com, Aug 3

Issue description

//chrome takes around 152 CPU minutes to compile, which is around 25 % of the total build time.

//chrome/renderer takes around 7 CPU minutes. This target does not compile with jumbo. 
 
Project Member

Comment 1 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c9543723c28198b17db81043181ec5830bff4f54

commit c9543723c28198b17db81043181ec5830bff4f54
Author: Oscar Johansson <oscarj@opera.com>
Date: Mon Aug 06 08:20:59 2018

Rename constants to be unique (chrome/renderer)

When building using jumbo, files gets merged and
constants with the same name may end up in the
same namespace and conflict. This happens for:
chrome/renderer/chrome_content_renderer_client.cc
chrome/renderer/extensions/extension_hooks_delegate.cc
chrome/renderer/extensions/tabs_hooks_delegate.cc

This commit solves the issue by renaming the constants
to something more file specific.

Bug: 870617
Change-Id: I3ded3625b3851724362d496191c5bd25dda081f6
Reviewed-on: https://chromium-review.googlesource.com/1161803
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#580821}
[modify] https://crrev.com/c9543723c28198b17db81043181ec5830bff4f54/chrome/renderer/chrome_content_renderer_client.cc
[modify] https://crrev.com/c9543723c28198b17db81043181ec5830bff4f54/chrome/renderer/extensions/extension_hooks_delegate.cc
[modify] https://crrev.com/c9543723c28198b17db81043181ec5830bff4f54/chrome/renderer/extensions/tabs_hooks_delegate.cc

Project Member

Comment 2 by bugdroid1@chromium.org, Aug 6

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/2150e6d4444bf6717dcc079034be06cbc4c447e2

commit 2150e6d4444bf6717dcc079034be06cbc4c447e2
Author: Oscar Johansson <oscarj@opera.com>
Date: Mon Aug 06 09:04:58 2018

Enable jumbo support in //chrome/renderer

Without jumbo, chrome/renderer takes around
7 CPU minutes, which is around 1.2 % of the
total build time.

This commit will enable jumbo support for
this target, reducing build time when using
jumbo.

Bug: 870617
Change-Id: I4b35b6fc69e30c61dc1f24082bbaa338ad96b4ef
Reviewed-on: https://chromium-review.googlesource.com/1161804
Reviewed-by: Scott Violet <sky@chromium.org>
Commit-Queue: Oscar Johansson <oscarj@opera.com>
Cr-Commit-Position: refs/heads/master@{#580827}
[modify] https://crrev.com/2150e6d4444bf6717dcc079034be06cbc4c447e2/chrome/renderer/BUILD.gn

Owner: brat...@opera.com
Status: Assigned (was: Started)
Blocking: 746956
Cc: osc...@opera.com

Sign in to add a comment