https://chromium-review.googlesource.com/c/chromium/src/+/1163349

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a9dac60b6b9359c29e211b70cd1e92a06eaf8e74

commit a9dac60b6b9359c29e211b70cd1e92a06eaf8e74
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Mon Aug 06 23:13:05 2018

Generate deterministic zip file for remoting

build_utils.ZipDir uses fixed timestamp and this makes zipped file deterministic.

This is a part of effort to utilize cache of test execution on swarming.

Bug:  870611 
Change-Id: Ie370f1f5a3e08834c6280b0088f90b31d038e3be
Reviewed-on: https://chromium-review.googlesource.com/1163349
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581034}
[modify] https://crrev.com/a9dac60b6b9359c29e211b70cd1e92a06eaf8e74/remoting/host/installer/build-installer-archive.py
[modify] https://crrev.com/a9dac60b6b9359c29e211b70cd1e92a06eaf8e74/remoting/host/installer/mac/BUILD.gn
[modify] https://crrev.com/a9dac60b6b9359c29e211b70cd1e92a06eaf8e74/remoting/host/installer/win/BUILD.gn
[modify] https://crrev.com/a9dac60b6b9359c29e211b70cd1e92a06eaf8e74/remoting/webapp/build-webapp.py
[modify] https://crrev.com/a9dac60b6b9359c29e211b70cd1e92a06eaf8e74/remoting/webapp/build_template.gni
[modify] https://crrev.com/a9dac60b6b9359c29e211b70cd1e92a06eaf8e74/tools/determinism/deterministic_build_whitelist.pyl

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/bc9d7d7030c1a4ecafe92354b965bf9d6cb8969a

commit bc9d7d7030c1a4ecafe92354b965bf9d6cb8969a
Author: Peter Kasting <pkasting@chromium.org>
Date: Tue Aug 07 00:01:24 2018

Revert "Generate deterministic zip file for remoting"

This reverts commit a9dac60b6b9359c29e211b70cd1e92a06eaf8e74.

Reason for revert: May have broken compile on https://ci.chromium.org/buildbot/chromium.chrome/Google%20Chrome%20Win/35014

Original change's description:
> Generate deterministic zip file for remoting
> 
> build_utils.ZipDir uses fixed timestamp and this makes zipped file deterministic.
> 
> This is a part of effort to utilize cache of test execution on swarming.
> 
> Bug:  870611 
> Change-Id: Ie370f1f5a3e08834c6280b0088f90b31d038e3be
> Reviewed-on: https://chromium-review.googlesource.com/1163349
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581034}

TBR=jamiewalch@chromium.org,thakis@chromium.org,yuweih@chromium.org,tikuta@chromium.org

Change-Id: I54ed04c00775bd7b0818e10e3bfc9df0619b828b
No-Presubmit: true
No-Tree-Checks: true
No-Try: true
Bug:  870611 
Reviewed-on: https://chromium-review.googlesource.com/1164129
Reviewed-by: Peter Kasting <pkasting@chromium.org>
Commit-Queue: Peter Kasting <pkasting@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581044}
[modify] https://crrev.com/bc9d7d7030c1a4ecafe92354b965bf9d6cb8969a/remoting/host/installer/build-installer-archive.py
[modify] https://crrev.com/bc9d7d7030c1a4ecafe92354b965bf9d6cb8969a/remoting/host/installer/mac/BUILD.gn
[modify] https://crrev.com/bc9d7d7030c1a4ecafe92354b965bf9d6cb8969a/remoting/host/installer/win/BUILD.gn
[modify] https://crrev.com/bc9d7d7030c1a4ecafe92354b965bf9d6cb8969a/remoting/webapp/build-webapp.py
[modify] https://crrev.com/bc9d7d7030c1a4ecafe92354b965bf9d6cb8969a/remoting/webapp/build_template.gni
[modify] https://crrev.com/bc9d7d7030c1a4ecafe92354b965bf9d6cb8969a/tools/determinism/deterministic_build_whitelist.pyl

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/d9fad9a32583d3cdb293e4f6a5c115a907f99ab1

commit d9fad9a32583d3cdb293e4f6a5c115a907f99ab1
Author: Takuto Ikuta <tikuta@chromium.org>
Date: Wed Aug 08 16:33:59 2018

Reland "Generate deterministic zip file for remoting"

This is a reland of a9dac60b6b9359c29e211b70cd1e92a06eaf8e74

I added an optional arg to ZipDir not to change zipped path.

Original change's description:
> Generate deterministic zip file for remoting
>
> build_utils.ZipDir uses fixed timestamp and this makes zipped file deterministic.
>
> This is a part of effort to utilize cache of test execution on swarming.
>
> Bug:  870611 
> Change-Id: Ie370f1f5a3e08834c6280b0088f90b31d038e3be
> Reviewed-on: https://chromium-review.googlesource.com/1163349
> Commit-Queue: Nico Weber <thakis@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581034}

Cq-Include-Trybots: master.tryserver.chromium.win:win_chrome_official
Bug:  870611 
Change-Id: Iffa3c8e2c4fd22b60c120052612f22491d588951
Reviewed-on: https://chromium-review.googlesource.com/1164682
Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
Cr-Commit-Position: refs/heads/master@{#581590}
[modify] https://crrev.com/d9fad9a32583d3cdb293e4f6a5c115a907f99ab1/build/android/gyp/util/build_utils.py
[modify] https://crrev.com/d9fad9a32583d3cdb293e4f6a5c115a907f99ab1/remoting/host/installer/build-installer-archive.py
[modify] https://crrev.com/d9fad9a32583d3cdb293e4f6a5c115a907f99ab1/remoting/host/installer/mac/BUILD.gn
[modify] https://crrev.com/d9fad9a32583d3cdb293e4f6a5c115a907f99ab1/remoting/host/installer/win/BUILD.gn
[modify] https://crrev.com/d9fad9a32583d3cdb293e4f6a5c115a907f99ab1/remoting/webapp/build-webapp.py
[modify] https://crrev.com/d9fad9a32583d3cdb293e4f6a5c115a907f99ab1/remoting/webapp/build_template.gni
[modify] https://crrev.com/d9fad9a32583d3cdb293e4f6a5c115a907f99ab1/tools/determinism/deterministic_build_whitelist.pyl

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c4cb08693796ad4d0a58d9c32d7f0c7db352db53

commit c4cb08693796ad4d0a58d9c32d7f0c7db352db53
Author: Joe Downing <joedow@chromium.org>
Date: Fri Aug 17 02:05:56 2018

Revert "Reland "Generate deterministic zip file for remoting""

This reverts commit d9fad9a32583d3cdb293e4f6a5c115a907f99ab1.

Reason for revert: Our Windows and Mac packages started failing the signing process the day after this CL was landed.  I would like to revert and see if our build succeeds tonight.

Original change's description:
> Reland "Generate deterministic zip file for remoting"
> 
> This is a reland of a9dac60b6b9359c29e211b70cd1e92a06eaf8e74
> 
> I added an optional arg to ZipDir not to change zipped path.
> 
> Original change's description:
> > Generate deterministic zip file for remoting
> >
> > build_utils.ZipDir uses fixed timestamp and this makes zipped file deterministic.
> >
> > This is a part of effort to utilize cache of test execution on swarming.
> >
> > Bug:  870611 
> > Change-Id: Ie370f1f5a3e08834c6280b0088f90b31d038e3be
> > Reviewed-on: https://chromium-review.googlesource.com/1163349
> > Commit-Queue: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581034}
> 
> Cq-Include-Trybots: master.tryserver.chromium.win:win_chrome_official
> Bug:  870611 
> Change-Id: Iffa3c8e2c4fd22b60c120052612f22491d588951
> Reviewed-on: https://chromium-review.googlesource.com/1164682
> Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
> Reviewed-by: Nico Weber <thakis@chromium.org>
> Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#581590}

TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org,thakis@chromium.org,yuweih@chromium.org,tikuta@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  870611 
Change-Id: I27fa4b1ae9e3c93781e2a6de508695a775a5e57a
Cq-Include-Trybots: master.tryserver.chromium.win:win_chrome_official
Reviewed-on: https://chromium-review.googlesource.com/1179242
Reviewed-by: Joe Downing <joedow@chromium.org>
Commit-Queue: Joe Downing <joedow@chromium.org>
Cr-Commit-Position: refs/heads/master@{#583938}
[modify] https://crrev.com/c4cb08693796ad4d0a58d9c32d7f0c7db352db53/build/android/gyp/util/build_utils.py
[modify] https://crrev.com/c4cb08693796ad4d0a58d9c32d7f0c7db352db53/remoting/host/installer/build-installer-archive.py
[modify] https://crrev.com/c4cb08693796ad4d0a58d9c32d7f0c7db352db53/remoting/host/installer/mac/BUILD.gn
[modify] https://crrev.com/c4cb08693796ad4d0a58d9c32d7f0c7db352db53/remoting/host/installer/win/BUILD.gn
[modify] https://crrev.com/c4cb08693796ad4d0a58d9c32d7f0c7db352db53/remoting/webapp/build-webapp.py
[modify] https://crrev.com/c4cb08693796ad4d0a58d9c32d7f0c7db352db53/remoting/webapp/build_template.gni
[modify] https://crrev.com/c4cb08693796ad4d0a58d9c32d7f0c7db352db53/tools/determinism/deterministic_build_whitelist.pyl

CL was reverted for
https://bugs.chromium.org/p/chromium/issues/detail?id=875279

I will set some extra info for zipinfo to see whether that prevents the issue.
e.g. https://docs.python.org/2/library/zipfile.html#zipfile.ZipInfo.CRC

AddToZipHermetic seems not set some attributes.
https://cs.chromium.org/chromium/src/build/android/gyp/util/build_utils.py?l=299&rcl=f4e5d36f777d9fb5fce3c1a3915a6fdab439b30b

I'm comparing remoting-webapp.v2.zip with and without that patch. The first difference I see is that the version with the patch doesn't have any compression, while without the patch we get regular compression (for remoting-webapp.v2.zip, that's the difference between 4 and 8 MB).

Also, the order of files is different.

But other than that, metadata etc look pretty similar, CRC is filled in and everything:

Nicos-MacBook-Pro:src thakis$ cat zipmetadata.py 
import sys
import zipfile

f = zipfile.ZipFile(sys.argv[1])

for i in f.infolist():
  print i.filename, i.date_time, i.compress_type, i.comment, i.extra, i.create_system, i.create_version, i.extract_version, i.reserved, i.flag_bits, i.volume, i.internal_attr, i.external_attr, i.header_offset, i.CRC, i.compress_size, i.file_size

Nicos-MacBook-Pro:src thakis$ python zipmetadata.py remoting-webapp.v2.bad.zip | tail
remoting-webapp.v2/window_frame.js (2001, 1, 1, 0, 0, 0) 0   3 20 20 0 0 0 0 27525120 9388033 3679487914 7273 7273
remoting-webapp.v2/window_message_dispatcher.js (2001, 1, 1, 0, 0, 0) 0   3 20 20 0 0 0 0 27525120 9395370 984094217 2837 2837
remoting-webapp.v2/window_shape.js (2001, 1, 1, 0, 0, 0) 0   3 20 20 0 0 0 0 27525120 9398284 3163594453 4356 4356
remoting-webapp.v2/xhr.js (2001, 1, 1, 0, 0, 0) 0   3 20 20 0 0 0 0 27525120 9402704 3359642143 12650 12650
remoting-webapp.v2/xhr_event_writer.js (2001, 1, 1, 0, 0, 0) 0   3 20 20 0 0 0 0 27525120 9415409 4131964427 4891 4891
remoting-webapp.v2/xhr_proxy.js (2001, 1, 1, 0, 0, 0) 0   3 20 20 0 0 0 0 27525120 9420368 3239756847 2797 2797
remoting-webapp.v2/xmpp_connection.js (2001, 1, 1, 0, 0, 0) 0   3 20 20 0 0 0 0 27525120 9423226 2277230568 10789 10789
remoting-webapp.v2/xmpp_error_cache.js (2001, 1, 1, 0, 0, 0) 0   3 20 20 0 0 0 0 27525120 9434082 2248131086 3386 3386
remoting-webapp.v2/xmpp_login_handler.js (2001, 1, 1, 0, 0, 0) 0   3 20 20 0 0 0 0 27525120 9437536 2274910192 12511 12511
remoting-webapp.v2/xmpp_stream_parser.js (2001, 1, 1, 0, 0, 0) 0   3 20 20 0 0 0 0 27525120 9450117 3453245628 7257 7257

Nicos-MacBook-Pro:src thakis$ python zipmetadata.py remoting-webapp.v2.good.zip | tail
remoting-webapp.v2/_locales/sv/messages.json (2018, 10, 24, 9, 53, 20) 8   3 20 20 0 0 0 0 2175008768 4236207 354644156 7535 29537
remoting-webapp.v2/_locales/sw/messages.json (2018, 10, 24, 9, 53, 20) 8   3 20 20 0 0 0 0 2175008768 4243816 1464629813 7498 30234
remoting-webapp.v2/_locales/ta/messages.json (2018, 10, 24, 9, 53, 20) 8   3 20 20 0 0 0 0 2175008768 4251388 214220936 9057 53430
remoting-webapp.v2/_locales/te/messages.json (2018, 10, 24, 9, 53, 20) 8   3 20 20 0 0 0 0 2175008768 4260519 1468042328 9298 53367
remoting-webapp.v2/_locales/th/messages.json (2018, 10, 24, 9, 53, 20) 8   3 20 20 0 0 0 0 2175008768 4269891 470412484 8638 48656
remoting-webapp.v2/_locales/tr/messages.json (2018, 10, 24, 9, 53, 20) 8   3 20 20 0 0 0 0 2175008768 4278603 355195488 7901 31258
remoting-webapp.v2/_locales/uk/messages.json (2018, 10, 24, 9, 53, 20) 8   3 20 20 0 0 0 0 2175008768 4286578 1732163703 8798 40676
remoting-webapp.v2/_locales/vi/messages.json (2018, 10, 24, 9, 53, 20) 8   3 20 20 0 0 0 0 2175008768 4295450 516968969 7779 34010
remoting-webapp.v2/_locales/zh_CN/messages.json (2018, 10, 24, 9, 53, 20) 8   3 20 20 0 0 0 0 2175008768 4303303 1480518275 7741 28294
remoting-webapp.v2/_locales/zh_TW/messages.json (2018, 10, 24, 9, 53, 20) 8   3 20 20 0 0 0 0 2175008768 4311121 583587601 7827 28164


joedow, can you elaborate on what you mean by "open the zip file and look at the metadata on the files" in https://bugs.chromium.org/p/chromium/issues/detail?id=875279#c6

For the me2me host zip, I see bigger differences (built like `ninja -C out\gnrel remoting-me2me-host-win-unsupported.zip`). I think I have enough for now to poke at it a bit locally.

I figured it out. It's not due to metadata. It's because lots of input data is missing on Windows. This makes things go:

diff --git a/build/android/gyp/util/build_utils.py b/build/android/gyp/util/build_utils.py
index 4fe157673e5c..6feddce7f10f 100644
--- a/build/android/gyp/util/build_utils.py
+++ b/build/android/gyp/util/build_utils.py
@@ -306,8 +306,9 @@ def AddToZipHermetic(zip_file, zip_path, src_path=None, data=None,
     return

   if src_path:
-    with file(src_path) as f:
+    with open(src_path, 'rb') as f:
       data = f.read()


Not needed for correctness, but to not regress compression, we probably also want:

diff --git a/remoting/host/installer/build-installer-archive.py b/remoting/host/installer/build-installer-archive.py
index 9c2d65abedc1..90828eb1a6d4 100755
--- a/remoting/host/installer/build-installer-archive.py
+++ b/remoting/host/installer/build-installer-archive.py
@@ -195,6 +195,7 @@ def buildHostArchive(temp_dir, zip_path, source_file_roots, source_files,

   build_utils.ZipDir(
     zip_path, temp_dir,
+    compress_fn=lambda _: zipfile.ZIP_DEFLATED,
     zip_prefix_path=os.path.splitext(os.path.basename(zip_path))[0])


diff --git a/remoting/webapp/build-webapp.py b/remoting/webapp/build-webapp.py
index 2c64e5f3c2a1..03e2b74a3335 100755
--- a/remoting/webapp/build-webapp.py
+++ b/remoting/webapp/build-webapp.py
@@ -338,6 +338,7 @@ def buildWebApp(buildtype, version, destination, zip_path,
   # Make the zipfile.
   build_utils.ZipDir(
     zip_path, destination,
+    compress_fn=lambda _: zipfile.ZIP_DEFLATED,
     zip_prefix_path=os.path.splitext(os.path.basename(zip_path))[0])


tikuta, want to reland with those changes?


(Also, I found bug 898537 while working on this.)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/e7b1af94c4c678d0ca451d47e5b81602bab28d10

commit e7b1af94c4c678d0ca451d47e5b81602bab28d10
Author: Nico Weber <thakis@chromium.org>
Date: Wed Oct 24 20:03:37 2018

Make build_utils.ZipDir() work on Windows.

Bug:  870611 
Change-Id: I311f2dcdafe25fea71ce0494424602e0e1989bb7
Reviewed-on: https://chromium-review.googlesource.com/c/1298174
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602415}
[modify] https://crrev.com/e7b1af94c4c678d0ca451d47e5b81602bab28d10/build/android/gyp/util/build_utils.py

Responding to comment #11 (I was out earlier, sorry), the issue was that the files in the broken zip package were missing several of the entries from this resource file (https://cs.chromium.org/chromium/src/remoting/host/win/version.rc.jinja2)  If you dump the file properties or view the details by right-clicking and choosing properties>details you can see the difference between the valid files and the broken files.

I'm calling it metadata but perhaps that is the wrong terminology, sorry if that is the case.  This missing info on the CRD files is what tripped up the signing script.

Attempting a reland after the fix here: https://chromium-review.googlesource.com/c/chromium/src/+/1299293

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a143152d2ba086eb12b3aa41a90317a4173befd3

commit a143152d2ba086eb12b3aa41a90317a4173befd3
Author: Nico Weber <thakis@chromium.org>
Date: Thu Oct 25 15:50:25 2018

Reland "Reland "Generate deterministic zip file for remoting""

This reverts commit c4cb08693796ad4d0a58d9c32d7f0c7db352db53.

Reason for revert:
The last time this was reverted because of https://crbug.com/875279
That was fixed in https://chromium-review.googlesource.com/c//1298174
so let's try again. Also make sure to actually use compression for
the outputs.

Original change's description:
> Revert "Reland "Generate deterministic zip file for remoting""
>
> This reverts commit d9fad9a32583d3cdb293e4f6a5c115a907f99ab1.
>
> Reason for revert: Our Windows and Mac packages started failing the signing process the day after this CL was landed.  I would like to revert and see if our build succeeds tonight.
>
> Original change's description:
> > Reland "Generate deterministic zip file for remoting"
> >
> > This is a reland of a9dac60b6b9359c29e211b70cd1e92a06eaf8e74
> >
> > I added an optional arg to ZipDir not to change zipped path.
> >
> > Original change's description:
> > > Generate deterministic zip file for remoting
> > >
> > > build_utils.ZipDir uses fixed timestamp and this makes zipped file deterministic.
> > >
> > > This is a part of effort to utilize cache of test execution on swarming.
> > >
> > > Bug:  870611 
> > > Change-Id: Ie370f1f5a3e08834c6280b0088f90b31d038e3be
> > > Reviewed-on: https://chromium-review.googlesource.com/1163349
> > > Commit-Queue: Nico Weber <thakis@chromium.org>
> > > Reviewed-by: Nico Weber <thakis@chromium.org>
> > > Reviewed-by: Jamie Walch <jamiewalch@chromium.org>
> > > Cr-Commit-Position: refs/heads/master@{#581034}
> >
> > Cq-Include-Trybots: master.tryserver.chromium.win:win_chrome_official
> > Bug:  870611 
> > Change-Id: Iffa3c8e2c4fd22b60c120052612f22491d588951
> > Reviewed-on: https://chromium-review.googlesource.com/1164682
> > Reviewed-by: Lambros Lambrou <lambroslambrou@chromium.org>
> > Reviewed-by: Nico Weber <thakis@chromium.org>
> > Commit-Queue: Takuto Ikuta <tikuta@chromium.org>
> > Cr-Commit-Position: refs/heads/master@{#581590}
>
> TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org,thakis@chromium.org,yuweih@chromium.org,tikuta@chromium.org
>
> # Not skipping CQ checks because original CL landed > 1 day ago.
>
> Bug:  870611 
> Change-Id: I27fa4b1ae9e3c93781e2a6de508695a775a5e57a
> Cq-Include-Trybots: master.tryserver.chromium.win:win_chrome_official
> Reviewed-on: https://chromium-review.googlesource.com/1179242
> Reviewed-by: Joe Downing <joedow@chromium.org>
> Commit-Queue: Joe Downing <joedow@chromium.org>
> Cr-Commit-Position: refs/heads/master@{#583938}

TBR=jamiewalch@chromium.org,lambroslambrou@chromium.org,thakis@chromium.org,joedow@chromium.org,yuweih@chromium.org,tikuta@chromium.org

# Not skipping CQ checks because original CL landed > 1 day ago.

Bug:  870611 
Change-Id: Ic28b7aeeac4a76e77bf8ffe951b04413ff43ec17
Reviewed-on: https://chromium-review.googlesource.com/c/1299293
Commit-Queue: Nico Weber <thakis@chromium.org>
Reviewed-by: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602722}
[modify] https://crrev.com/a143152d2ba086eb12b3aa41a90317a4173befd3/build/android/gyp/util/build_utils.py
[modify] https://crrev.com/a143152d2ba086eb12b3aa41a90317a4173befd3/remoting/host/installer/build-installer-archive.py
[modify] https://crrev.com/a143152d2ba086eb12b3aa41a90317a4173befd3/remoting/host/installer/mac/BUILD.gn
[modify] https://crrev.com/a143152d2ba086eb12b3aa41a90317a4173befd3/remoting/host/installer/win/BUILD.gn
[modify] https://crrev.com/a143152d2ba086eb12b3aa41a90317a4173befd3/remoting/webapp/build-webapp.py
[modify] https://crrev.com/a143152d2ba086eb12b3aa41a90317a4173befd3/remoting/webapp/build_template.gni
[modify] https://crrev.com/a143152d2ba086eb12b3aa41a90317a4173befd3/tools/determinism/deterministic_build_whitelist.pyl

Let me pass this issue to thakis.

Let's optimistically close this and hope that remoting works fine this time :-)

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/5762c703c1482925dc1735e3ad5b3ee512a647d0

commit 5762c703c1482925dc1735e3ad5b3ee512a647d0
Author: Nico Weber <thakis@chromium.org>
Date: Thu Oct 25 20:59:17 2018

Update determinism whitelist now that remoting zips are deterministic.

Notably, browsertests.isolate is now deterministic (on a single machine. I've
seen some files in there be different when it's built at the same revision
on different machines).

Bug:  870611 
Change-Id: Ifa54e61cdd1aa6be820bd8fb2d265273720b705e
Reviewed-on: https://chromium-review.googlesource.com/c/1299667
Reviewed-by: Takuto Ikuta <tikuta@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#602852}
[modify] https://crrev.com/5762c703c1482925dc1735e3ad5b3ee512a647d0/tools/determinism/deterministic_build_whitelist.pyl

Thank you for taking this!

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/70e151d16404bbcd3c58d5b6a8006147f872361e

commit 70e151d16404bbcd3c58d5b6a8006147f872361e
Author: Nico Weber <thakis@chromium.org>
Date: Fri Oct 26 14:47:26 2018

Make build_utils.ZipDir() preserve executable bit.

This function is now used to zip the remoting installer on mac. That
zip contains a .sh script that the build server extracts and tries to
run, so make sure it remains executable after unpacking.

Bug: 875279, 870611 
Change-Id: Ia515a997f9d67943daa8e09907b52ec070650de2
Reviewed-on: https://chromium-review.googlesource.com/c/1301793
Commit-Queue: Nico Weber <thakis@chromium.org>
Commit-Queue: agrieve <agrieve@chromium.org>
Reviewed-by: agrieve <agrieve@chromium.org>
Cr-Commit-Position: refs/heads/master@{#603088}
[modify] https://crrev.com/70e151d16404bbcd3c58d5b6a8006147f872361e/build/android/gyp/util/build_utils.py

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/c59577a4fe417b3a947f1176eb09bf79e67350d6

commit c59577a4fe417b3a947f1176eb09bf79e67350d6
Author: Nico Weber <thakis@chromium.org>
Date: Wed Oct 31 10:22:18 2018

Make build_utils.ZipDir() preserve group and other executable bits too.

Apparenly preserving the user x bit isn't enough for remoting's installer.
Follow-up to https://chromium-review.googlesource.com/c/chromium/src/+/1301793

Bug:  900303 ,875279, 870611 
Change-Id: Ibbdf71b1d33941b0d6bde5e6cc3c964404a653c0
Reviewed-on: https://chromium-review.googlesource.com/c/1308759
Reviewed-by: agrieve <agrieve@chromium.org>
Commit-Queue: Nico Weber <thakis@chromium.org>
Cr-Commit-Position: refs/heads/master@{#604198}
[modify] https://crrev.com/c59577a4fe417b3a947f1176eb09bf79e67350d6/build/android/gyp/util/build_utils.py