New issue
Advanced search Search tips

Issue 870609 link

Starred by 1 user
Status: Fixed
Owner: ----
Closed: Sep 10
Cc:
mlamouri@chromium.org
Components:
EstimatedDays: ----
NextAction: ----
OS: Linux , Windows , Chrome , Mac
Pri: 3
Type: Bug



Sign in to add a comment

Picture-in-Picture video should prevent extension background page to be killed

Project Member Reported by fbeaufort@chromium.org, Aug 3 
When an extension background page contains a video playing in Picture-in-Picture mode, it should not be killed as video is tied to the web content. In other words, as soon as background page is killed, the Picture-in-Picture window is closed.

I think we should make prevent extension backgrond page to be killed as long a video is playing in Picture-in-Picture mode.

Comment 1 by mlamouri@chromium.org, Aug 21

Cc: mlamo...@google.com
fbeaufort@, is this something you are considering working on?

Comment 2 by mlamouri@chromium.org, Aug 21

Cc: -mlamo...@google.com mlamouri@chromium.org

Comment 3 by fbeaufort@chromium.org, Aug 22

Status: Started (was: Untriaged)
WIP at https://chromium-review.googlesource.com/c/chromium/src/+/1161805
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 28 

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/a2f0a3cadca2aa8183a1e6428b1beff059be33da

commit a2f0a3cadca2aa8183a1e6428b1beff059be33da
Author: François Beaufort <beaufort.francois@gmail.com>
Date: Tue Aug 28 12:46:11 2018

Keep extension background page alive when video is Picture-in-Picture.

This CL makes sure extension background page is kept alive when a
video in background page is in Picture-in-Picture mode.

Bug:  870609 
Change-Id: Ifa3c8fc9a4a049ac60e3bde9ca64353b6f1c6569
Reviewed-on: https://chromium-review.googlesource.com/1161805
Commit-Queue: François Beaufort <beaufort.francois@gmail.com>
Reviewed-by: Jochen Eisinger <jochen@chromium.org>
Reviewed-by: Devlin <rdevlin.cronin@chromium.org>
Cr-Commit-Position: refs/heads/master@{#586668}
[modify] https://crrev.com/a2f0a3cadca2aa8183a1e6428b1beff059be33da/chrome/browser/extensions/lazy_background_page_apitest.cc
[add] https://crrev.com/a2f0a3cadca2aa8183a1e6428b1beff059be33da/chrome/test/data/extensions/api_test/lazy_background_page/browser_action_picture_in_picture/background.js
[add] https://crrev.com/a2f0a3cadca2aa8183a1e6428b1beff059be33da/chrome/test/data/extensions/api_test/lazy_background_page/browser_action_picture_in_picture/manifest.json
[modify] https://crrev.com/a2f0a3cadca2aa8183a1e6428b1beff059be33da/content/browser/media/media_web_contents_observer.cc
[modify] https://crrev.com/a2f0a3cadca2aa8183a1e6428b1beff059be33da/content/browser/web_contents/web_contents_impl.cc
[modify] https://crrev.com/a2f0a3cadca2aa8183a1e6428b1beff059be33da/content/browser/web_contents/web_contents_impl.h
[modify] https://crrev.com/a2f0a3cadca2aa8183a1e6428b1beff059be33da/content/public/browser/web_contents_observer.h
[modify] https://crrev.com/a2f0a3cadca2aa8183a1e6428b1beff059be33da/extensions/browser/extension_host.cc
[modify] https://crrev.com/a2f0a3cadca2aa8183a1e6428b1beff059be33da/extensions/browser/extension_web_contents_observer.cc
[modify] https://crrev.com/a2f0a3cadca2aa8183a1e6428b1beff059be33da/extensions/browser/extension_web_contents_observer.h
[modify] https://crrev.com/a2f0a3cadca2aa8183a1e6428b1beff059be33da/testing/buildbot/filters/chromeos.mash.fyi.browser_tests.filter

Comment 5 by fbeaufort@chromium.org, Sep 10

Status: Fixed (was: Started)
►

Sign in to add a comment