New issue
Advanced search Search tips

Issue 870604 link

Starred by 2 users

Issue metadata

Status: Assigned
Owner:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 1
Type: Bug



Sign in to add a comment

"WebViewFocusBrowserPluginSpecificTest.TouchFocusesEmbedder" is flaky

Project Member Reported by chromium...@appspot.gserviceaccount.com, Aug 3

Issue description

"WebViewFocusBrowserPluginSpecificTest.TouchFocusesEmbedder" is flaky.

This issue was created automatically by the chromium-try-flakes app. Please find the right owner to fix the respective test/step and assign this issue to them. If the step/test is infrastructure-related, please add Infra-Troopers label and change issue status to Untriaged. When done, please remove the issue from Sheriff Bug Queue by removing the Sheriff-Chromium label.

We have detected 4 recent flakes. List of all flakes can be found at https://chromium-try-flakes.appspot.com/all_flake_occurrences?key=ahVzfmNocm9taXVtLXRyeS1mbGFrZXNyRQsSBUZsYWtlIjpXZWJWaWV3Rm9jdXNCcm93c2VyUGx1Z2luU3BlY2lmaWNUZXN0LlRvdWNoRm9jdXNlc0VtYmVkZGVyDA.

Flaky tests should be disabled within 30 minutes unless culprit CL is found and reverted. Please see more details here: https://sites.google.com/a/chromium.org/dev/developers/tree-sheriffs/sheriffing-bug-queues#triaging-auto-filed-flakiness-bugs
 
Owner: wjmaclean@chromium.org
Status: Assigned (was: Untriaged)
James, I disabled the test on Linux for now, passing this to you for perma-fix.
Project Member

Comment 2 by bugdroid1@chromium.org, Aug 3

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/9569d21a06f422ba93b4ee4a6959b41fa262d6c9

commit 9569d21a06f422ba93b4ee4a6959b41fa262d6c9
Author: Balazs Engedy <engedy@chromium.org>
Date: Fri Aug 03 10:40:38 2018

Disable flaky WebViewFocusBrowserPluginSpecificTest.TouchFocusesEmbedder.

The test is extremely flaky on Linux.

Bug: 870604
Change-Id: I02242da7c685075ce148a6f302b67afe1b5804a4
TBR: lazyboy@chromium.org
Reviewed-on: https://chromium-review.googlesource.com/1161921
Reviewed-by: Balazs Engedy <engedy@chromium.org>
Commit-Queue: Balazs Engedy <engedy@chromium.org>
Cr-Commit-Position: refs/heads/master@{#580498}
[modify] https://crrev.com/9569d21a06f422ba93b4ee4a6959b41fa262d6c9/chrome/browser/apps/guest_view/web_view_browsertest.cc

Labels: -Sheriff-Chromium
Project Member

Comment 4 by bugdroid1@chromium.org, Aug 10

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/8eb68052e037952a13565c5545ca3fdc9dbac2b9

commit 8eb68052e037952a13565c5545ca3fdc9dbac2b9
Author: Ehsan Karamad <ekaramad@chromium.org>
Date: Fri Aug 10 21:39:23 2018

Move BrowserPluginSpecific tests out of web_view_browsertest.cc

The WebViewBrowserPluginSpecificTest class includes tests which use a
BrowserPluign-based GuestView. Since all GuestViews except MimeHandlerViewGuest
are now based on cross-process frames, these tests should not be implemented as
WebViewGuest tests anymore.

This CL introduces a new chrome browser test target for such
BrowserPluginSpecific tests where the tests instantiate a MimeHandlerViewGuest
instead of a <webview>.

Ideally, the tests should have lived with the rest of MimeHandlerViewTests in
extension layer; however, due to chrome layer dependencies it is not possible.

Bug: 659750, 533069, 330264, 870604
Change-Id: Ica252a60e94bad47cabbff8b9275b8f9fb05d7ae
Reviewed-on: https://chromium-review.googlesource.com/1168734
Commit-Queue: Ehsan Karamad <ekaramad@chromium.org>
Reviewed-by: James MacLean <wjmaclean@chromium.org>
Cr-Commit-Position: refs/heads/master@{#582345}
[modify] https://crrev.com/8eb68052e037952a13565c5545ca3fdc9dbac2b9/chrome/browser/apps/guest_view/web_view_browsertest.cc
[add] https://crrev.com/8eb68052e037952a13565c5545ca3fdc9dbac2b9/chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_browsertest.cc
[modify] https://crrev.com/8eb68052e037952a13565c5545ca3fdc9dbac2b9/chrome/test/BUILD.gn
[modify] https://crrev.com/8eb68052e037952a13565c5545ca3fdc9dbac2b9/chrome/test/data/extensions/api_test/mime_handler_view/index.js

Sign in to add a comment