New issue
Advanced search Search tips
Note: Color blocks (like or ) mean that a user may not be available. Tooltip shows the reason.

Issue 870602 link

Starred by 1 user

Issue metadata

Status: Fixed
Owner:
Last visit > 30 days ago
Closed: Aug 23
Cc:
Components:
EstimatedDays: ----
NextAction: ----
OS: ----
Pri: 2
Type: Bug
Proj-VR



Sign in to add a comment

[WPT] New failures introduced in external/wpt/webxr by import https://crrev.com/c/1161617

Project Member Reported by monorail...@ecosystem-infra.iam.gserviceaccount.com, Aug 3

Issue description

WPT import https://crrev.com/c/1161617 introduced new failures in external/wpt/webxr:

List of new failures:
external/wpt/webxr/idlharness.https.window.html new failing tests: https://crrev.com/c/1161617/4/third_party/WebKit/LayoutTests/external/wpt/webxr/idlharness.https.window-expected.txt

This import contains upstream changes from c82a9f16b158508dd100617352c6e2e60d0910d0 to 1d73b48a813903b363972cddafdd864099aed233:
Check cache.keys() when there are requests with VARY headers.: https://github.com/web-platform-tests/wpt/commit/1d73b48a813903b363972cddafdd864099aed233
Test NotificationEvent only in service workers (#12286): https://github.com/web-platform-tests/wpt/commit/78cdede8c4847b3dd51430c9b838ac38c56813c1
Fix webusb IDL test (#12274): https://github.com/web-platform-tests/wpt/commit/896f8e65c74296db709eacb430694093c5a0144d
Update the notifications IDL file (#11859): https://github.com/web-platform-tests/wpt/commit/cdf07c95993dd35ba073d54a60a1f309b9bded72
Cookie Store API: Remove `httpOnly` option: https://github.com/web-platform-tests/wpt/commit/ca6120560c151d9dac81afa6a834a217db6e5ed6
Update the push-api IDL and tests (#11925): https://github.com/web-platform-tests/wpt/commit/0faf45e40a52f7b2dfa291ab1b68b002a77bb257
Merge pull request #12271 from jan-ivar/ended: https://github.com/web-platform-tests/wpt/commit/6d2c774db441cc8dafa21d2c4fd407557b098a31
Update the WebXR IDL file + test (#11872): https://github.com/web-platform-tests/wpt/commit/4799e567ecb0217ebe0bfd26094f7cf9e8bea171 [affecting this directory]
Update the css-typed-om IDL file + test (#11893): https://github.com/web-platform-tests/wpt/commit/b66333a7e818b32c829b6ee1ad2373f551dbeb8b
Update selenium from 3.13.0 to 3.14.0: https://github.com/web-platform-tests/wpt/commit/016c7a7400a1d4be17e0c3710148163d2a247f82
Update selenium from 3.13.0 to 3.14.0: https://github.com/web-platform-tests/wpt/commit/c0a7dbbb96e73e835789b4d90950178095d1625d
Update selenium from 3.13.0 to 3.14.0: https://github.com/web-platform-tests/wpt/commit/2203f16c7f21c582395455303ae15411955ba19b
Update selenium from 3.13.0 to 3.14.0: https://github.com/web-platform-tests/wpt/commit/c1579120e855828706e6a0c613be7c5def14d7f8
Update selenium from 3.13.0 to 3.14.0: https://github.com/web-platform-tests/wpt/commit/5107d39e27801e40ab034f1583dc4e84810603a4
Update selenium from 3.13.0 to 3.14.0: https://github.com/web-platform-tests/wpt/commit/ae2067a994d02dfb356706726c853a3278834788
Update selenium from 3.13.0 to 3.14.0: https://github.com/web-platform-tests/wpt/commit/ccc336b3cd3341e5c8d00c87f71c1ea9c9a9d0c5
Merge pull request #12230 from fippo/webrtc-muxpolicy: https://github.com/web-platform-tests/wpt/commit/c6e86383a5c00d5e78da28f92a7fefb8dc71db67
Update payment-handler IDL and tests (#11932): https://github.com/web-platform-tests/wpt/commit/adaebd60424a8f87f1b17ff6094ec490c16aff3a
Add the webrtc-stats IDL file + test (#11699): https://github.com/web-platform-tests/wpt/commit/ec8570ebda567074ecd4982253f46931be5eb03b
Add a default name ("idl_test setup") for idl_test (#12276): https://github.com/web-platform-tests/wpt/commit/70413d8d6bf4bf581e52bc3a5edddd205fbd7a41
Update media-capabilities IDL + test (#11947): https://github.com/web-platform-tests/wpt/commit/e90038bd29b39c5e4846e08762de475a48d64910
[idlharness.js] Catch IdlArray.test bugs better (#12272): https://github.com/web-platform-tests/wpt/commit/e9f3244421c353a63142dd9742e0ed6edc509cc8
Updated navigation-timing IDL file (#11945): https://github.com/web-platform-tests/wpt/commit/4a15e98c1339681493dff207de2c69ea29efa602
Use .tar.gz for test archives: https://github.com/web-platform-tests/wpt/commit/5c0e7ca33a26cb7b4ba027ec80a112e05d1e220d
URL: additional tests for URLSearchParams's sort(): https://github.com/web-platform-tests/wpt/commit/7cee0d238c42272d48fd06935c5abcf1e490b394
WPT for Clear-Site-Data executionContexts: https://github.com/web-platform-tests/wpt/commit/09d362241ad99dffc7d4c17f70ebbc0ae36743d6
Test that removal from a MediaStream fires ended on media elements.: https://github.com/web-platform-tests/wpt/commit/39f4392538758af2ae82a993b17f0faec72e50b2
Modernize MediaStream-removetrack.https.html: https://github.com/web-platform-tests/wpt/commit/bbf272bb0053ea7f4341814da1fa696aee9953fc
webrtc: throw InvalidAccessError on mismatching rtcpmuxPolicy in setRemoteDescription: https://github.com/web-platform-tests/wpt/commit/c548b25d60df95a17b42116f6ebd798f101abca0

 
Cc: offenwanger@chromium.org
Labels: Proj-XR Pri-2 Type-Bug
Owner: offenwanger@chromium.org
Status: Assigned (was: Untriaged)
Project Member

Comment 3 by bugdroid1@chromium.org, Aug 22

The following revision refers to this bug:
  https://chromium.googlesource.com/chromium/src.git/+/3950bdd91db23dcc8e6a864f0fcf263950f8439a

commit 3950bdd91db23dcc8e6a864f0fcf263950f8439a
Author: Anna Offenwanger <offenwanger@chromium.org>
Date: Wed Aug 22 23:41:32 2018

Correct WebXR idlharness test

XR devices and sessions cannot be obtained without a physical device
connected to the system or a system to mock out the backend APIs. As
setting up such as system would take a lot of work, it is unlikely to be
worthwhile while the spec is still undergoing so much change. Therefore,
the incorrect calls to get device and session have been removed, and can
be written correctly at a later date.

Bug:  870602 
Change-Id: I0c9f512605d17dc3df890d699da016a8bc1e1c0c
Reviewed-on: https://chromium-review.googlesource.com/1185285
Commit-Queue: Anna Offenwanger <offenwanger@chromium.org>
Reviewed-by: Brandon Jones <bajones@chromium.org>
Cr-Commit-Position: refs/heads/master@{#585306}
[modify] https://crrev.com/3950bdd91db23dcc8e6a864f0fcf263950f8439a/third_party/WebKit/LayoutTests/external/wpt/webxr/idlharness.https.window-expected.txt
[modify] https://crrev.com/3950bdd91db23dcc8e6a864f0fcf263950f8439a/third_party/WebKit/LayoutTests/external/wpt/webxr/idlharness.https.window.js
[delete] https://crrev.com/0f225b910d0b7d5a590a15832c2eb8413077cb59/third_party/WebKit/LayoutTests/external/wpt/webxr/interfaces.https-expected.txt

Status: Fixed (was: Assigned)

Sign in to add a comment