img not showing
Reported by
zmorta...@gmail.com,
Aug 3
|
|||||||
Issue descriptionUserAgent: Mozilla/5.0 (Windows NT 10.0; Win64; x64) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/68.0.3440.84 Safari/537.36 Steps to reproduce the problem: 1. http://jobs.convertball.com/reviews 2. src img ../../../../assets/thumbon.png not working 3. only on chrome What is the expected behavior? show image What went wrong? src img ../../../../assets/thumbon.png not working only on chrome Did this work before? N/A Chrome version: 68.0.3440.84 Channel: stable OS Version: 10.0 Flash Version:
,
Aug 6
,
Aug 7
Able to reproduce the issue on Mac 10.13.3, Win-10 and Ubuntu 17.104 using chrome reported version #68.0.3440.84 and latest canary #70.0.3515.0. This is a non-regression issue as it is observed from M60 old builds. Hence, marking it as untriaged to get more inputs from dev team. Thanks...!!
,
Aug 7
This appears to be a layout issue, or maybe style resolution. The computed height of the image is 0px. It's specified as 100% but no parent element has 0 height. Forcing re-layout seems to fix it in that docking Devtools causes the height to compute and the image to appear, as does disabling the height: 100%; CSS rule on the image.
,
Aug 8
Looks like an invalidation problem, the image takes awhile to load and once it is loaded it never updates the height of the element. Interesting.
,
Dec 11
Looks like the culprit is |image_size_is_constrained| in LayoutImage::InvalidatePaintAndMarkForLayoutIfNeeded - it's not strict enough in this case and thus not triggering a layout when the image dimensions arrive.
,
Dec 13
,
Dec 14
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/fbc553f0671c6123db3b7a840cafbbc44f875981 commit fbc553f0671c6123db3b7a840cafbbc44f875981 Author: Fredrik Söderquist <fs@opera.com> Date: Fri Dec 14 09:55:18 2018 Refactor "needs layout" check in LayoutImage Move the conditions used to check if layout is needed when the intrinsic size changes out into a new function, and call that from LayoutImage::InvalidatePaintAndMarkForLayoutIfNeeded. Replace open-coded HasRelativeLogicalWidth() with a call to that method. Bug: 870599 Change-Id: Iae480326083eb493d58233378d95af8c1dd62f0a Reviewed-on: https://chromium-review.googlesource.com/c/1373839 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#616624} [modify] https://crrev.com/fbc553f0671c6123db3b7a840cafbbc44f875981/third_party/blink/renderer/core/layout/layout_image.cc [modify] https://crrev.com/fbc553f0671c6123db3b7a840cafbbc44f875981/third_party/blink/renderer/core/layout/layout_image.h
,
Dec 18
The following revision refers to this bug: https://chromium.googlesource.com/chromium/src.git/+/934d262005cdf2110da6fe3d1660e6e45cde6925 commit 934d262005cdf2110da6fe3d1660e6e45cde6925 Author: Fredrik Söderquist <fs@opera.com> Date: Tue Dec 18 11:33:12 2018 Narrow "is constrained" check for LayoutImage layout invalidation If our containing block has auto height, we need to relayout. Add !HasAutoHeightOrContainingBlockWithAutoHeight() to the condition for |image_size_is_constrained|. Bug: 870599 Change-Id: I22858843d7ad87c63eb7b8d6e771e0f8d6cfa09d Reviewed-on: https://chromium-review.googlesource.com/c/1373823 Commit-Queue: Fredrik Söderquist <fs@opera.com> Reviewed-by: Morten Stenshorne <mstensho@chromium.org> Cr-Commit-Position: refs/heads/master@{#617446} [modify] https://crrev.com/934d262005cdf2110da6fe3d1660e6e45cde6925/third_party/blink/renderer/core/layout/layout_box_model_object.cc [modify] https://crrev.com/934d262005cdf2110da6fe3d1660e6e45cde6925/third_party/blink/renderer/core/layout/layout_box_model_object.h [modify] https://crrev.com/934d262005cdf2110da6fe3d1660e6e45cde6925/third_party/blink/renderer/core/layout/layout_image.cc [add] https://crrev.com/934d262005cdf2110da6fe3d1660e6e45cde6925/third_party/blink/web_tests/external/wpt/css/css-sizing/percentage-height-replaced-content-in-auto-cb.html
,
Dec 18
|
|||||||
►
Sign in to add a comment |
|||||||
Comment 1 by viswa.karala@chromium.org
, Aug 6